Page MenuHomePhabricator

Mobile diff doesn't have review buttons
Closed, DeclinedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

What happens?:

No review buttons.

What should have happened instead?:

Should be able to mark changes as reviewed.

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Seems like normal diff links started to redirect to mobile diff special page. Normal diff had the review links.

Event Timeline

I assume this is about Flagged Revisions?

Seems like normal diff links started to redirect to mobile diff special page. Normal diff had the review links.

Does that mean you cannot reach non-mobile https://pl.wikipedia.org/wiki/Specjalna:Różnica_mobilna/71469982 anymore? Because I can.

Does that mean you cannot reach non-mobile https://pl.wikipedia.org/wiki/Specjalna:Różnica_mobilna/71469982 anymore? Because I can.

I can, but I don't want to ;-)

I cannot reach this page (when on my phone):
https://pl.m.wikipedia.org/w/index.php?title=Czas_letni&diff=71469982&oldid=71261550

Or to be more exact I need this buttons on a diff page:

obraz.png (129×408 px, 7 KB)

I assume this is about Flagged Revisions?

Yes, mostly about this form:

<form method="post" action="/w/index.php?title=Specjalna:Oznaczenie_wersji&amp;action=submit" id="mw-fr-reviewform">
<fieldset class="flaggedrevs_reviewform noprint cdx-card" style="font-size: 90%;">
<span id="mw-fr-reviewformlegend"><span class="cdx-card__text__title">Oznacz tę wersję</span>
...
</form>

I would be happy if I would be able to disable the MobileDiff completely (you might connect this to an existing advance mode preference for mobile). At the very least, removing the redirect in advanced mode would help. I think the redirect is a recent addition.

Special:MobileDiffnormal diff
obraz.png (1×947 px, 93 KB)
obraz.png (1×947 px, 110 KB)

I can understand readers or less advanced editor might want a simple view, but it doesn't work for me. Note how much more I can do on normal diff (review = oznacz tę wersję, undo = anuluj edycję, rollback = cofnij edycję).

Tacsipacsi subscribed.

As far as I remember, one-revision diffs have redirected to MobileDiff since July(?) 2017 (I remember quite exactly because I was abroad and tried to check my watchlist from mobile when the diffs started to become unusable 🙂). However, at that time, diffs between non-consecutive diffs (e.g. https://pl.m.wikipedia.org/w/index.php?title=Czas_letni&diff=71512840&oldid=71512745) didn’t redirect yet, so that may be a new thing indeed.

I think MobileDiff should be removed for everyone and sown with salt; now with the inline toggle in normal diffs, it provides no extra features, just breaks existing ones.

Jdlrobson changed the task status from Open to Stalled.Oct 19 2023, 3:34 PM
Jdlrobson subscribed.

Stalling on T117279

We have a path to remove the diff page and there has been recent activity towards that goal over the last few weeks. This can be reconsidered once that's done.

Interfaces should no longer be linking to MobileDiff. If you get mobile diff, you can click the desktop view link in the footer and then click the mobile view link to get back to it.
T358293 will remove the associated code.