Page MenuHomePhabricator
Create Task
Maniphest T349026

function-schemata: Decide whether Z507's keys should be quoted & implement the decision
Closed, ResolvedPublic
Actions

Description

Description

Neither key of Z507/error_in_evaluation is declared as Z99/Quote, but the method createZErrorInstance() in errorFormatter.js (function-schemata) does quote values of both of Z507's keys.

  • Determine which of Z507's keys should be quoted
  • Depending on that determination, update Z507 and/or createZErrorInstance() as needed
  • Update all error-creation code & related tests as needed.
    • WikiLambda
    • function-orchestrator

Completion checklist

Details

SubjectRepoBranchLines +/-
wikifunctions: Upgrade evaluators from 2023-11-29-143341 to 2024-01-18-182630operations/deployment-chartsmaster+2 -2
wikifunctions: Upgrade orchestrator from 2023-11-29-152839 to 2024-01-09-190638operations/deployment-chartsmaster+1 -1
wikifunctions: Upgrade orchestrator from 2023-11-29-152839 to 2024-01-18-182456operations/deployment-chartsmaster+1 -1
Update function-schemata sub-module to HEAD (1a02a7d)mediawiki/extensions/WikiLambdamaster+2 -2
Update PHP code for change in definition of Z507mediawiki/extensions/WikiLambdamaster+1 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

DMartin-WMF created this task.Oct 16 2023, 6:53 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 16 2023, 6:53 PM
DMartin-WMF renamed this task from function-schemata: Determine whether Z507's keys should be quoted to function-schemata: Decide whether Z507's keys should be quoted & implement the decision.Oct 16 2023, 6:54 PM
DMartin-WMF added a parent task: T321113: Audit and update creation and manipulation of errors in the orchestrator and evaluator.
DMartin-WMF mentioned this in T349017: function-schemata: Audit use of Z99/Quote in error types.
Maintenance_bot added a project: Abstract Wikipedia team.Oct 16 2023, 7:30 PM
Jdforrester-WMF triaged this task as Medium priority.Oct 19 2023, 4:42 PM
Jdforrester-WMF moved this task from To Triage to Backlog on the Abstract Wikipedia team board.
DMartin-WMF claimed this task.Dec 13 2023, 5:42 AM
DMartin-WMF moved this task from Backlog to In Progress on the Abstract Wikipedia team board.
CodeReviewBot added a project: Patch-For-Review.Dec 18 2023, 3:48 AM

dmartin opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-schemata/-/merge_requests/66

Draft: definitions: Declare Z507K1 as Z99/Quote & update JS code accordingly

CodeReviewBot added a comment.Dec 18 2023, 3:24 PM

dmartin opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/116

Draft: Update tests for change in definition of Z507

gerritbot added a comment.Jan 3 2024, 2:46 AM

Change 987212 had a related patch set uploaded (by David Martin; author: David Martin):

[mediawiki/extensions/WikiLambda@master] Update PHP code for change in definition of Z507

https://gerrit.wikimedia.org/r/987212

gerritbot added a comment.Jan 4 2024, 12:55 PM

Change 987212 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Update PHP code for change in definition of Z507

https://gerrit.wikimedia.org/r/987212

Jdforrester-WMF changed the task status from Open to In Progress.Jan 4 2024, 12:59 PM
Jdforrester-WMF updated the task description. (Show Details)
ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.13; 2024-01-09 ).Jan 4 2024, 1:00 PM
CodeReviewBot added a comment.Jan 8 2024, 7:10 PM

jforrester merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-schemata/-/merge_requests/66

definitions: Declare Z507K1 as Z99/Quote & update JS code accordingly

CodeReviewBot added a comment.Jan 8 2024, 7:25 PM

jforrester merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/116

Update tests for change in definition of Z507

Maintenance_bot removed a project: Patch-For-Review.Jan 8 2024, 7:30 PM
Jdforrester-WMF moved this task from In Progress to To deploy on the Abstract Wikipedia team board.Jan 8 2024, 9:03 PM
CodeReviewBot added a project: Patch-For-Review.Jan 9 2024, 5:20 AM

dmartin opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-evaluator/-/merge_requests/140

Update function-schemata sub-module to HEAD (2a825b7)

gerritbot added a comment.Jan 9 2024, 5:24 AM

Change 988754 had a related patch set uploaded (by David Martin; author: David Martin):

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (2a825b7)

https://gerrit.wikimedia.org/r/988754

CodeReviewBot added a comment.Jan 9 2024, 2:10 PM

jforrester merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-evaluator/-/merge_requests/140

Update function-schemata sub-module to HEAD (2a825b7)

gerritbot added a comment.Jan 9 2024, 7:03 PM

Change 988754 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (1a02a7d)

https://gerrit.wikimedia.org/r/988754

Maintenance_bot removed a project: Patch-For-Review.Jan 9 2024, 7:30 PM
Jdforrester-WMF moved this task from To deploy to Verify in production on the Abstract Wikipedia team board.Jan 11 2024, 5:24 PM
Jdforrester-WMF updated the task description. (Show Details)Jan 11 2024, 9:04 PM
Jdforrester-WMF closed this task as Resolved.Jan 22 2024, 3:12 PM
gerritbot added a comment.Jan 22 2024, 6:45 PM

Change 992225 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2023-11-29-152839 to 2024-01-18-182456

https://gerrit.wikimedia.org/r/992225

gerritbot added a project: Patch-For-Review.Jan 22 2024, 6:45 PM
gerritbot added a comment.Jan 22 2024, 6:48 PM

Change 992227 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Upgrade evaluators from 2023-11-29-143341 to 2024-01-18-182630

https://gerrit.wikimedia.org/r/992227

gerritbot added a comment.Jan 22 2024, 7:27 PM

Change 992225 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2023-11-29-152839 to 2024-01-18-182456

https://gerrit.wikimedia.org/r/992225

gerritbot added a comment.Jan 22 2024, 7:45 PM

Change 992229 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2023-11-29-152839 to 2024-01-09-190638

https://gerrit.wikimedia.org/r/992229

gerritbot added a comment.Jan 22 2024, 7:46 PM

Change 992229 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2023-11-29-152839 to 2024-01-09-190638

https://gerrit.wikimedia.org/r/992229

gerritbot added a comment.Jan 22 2024, 7:53 PM

Change 992227 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Upgrade evaluators from 2023-11-29-143341 to 2024-01-18-182630

https://gerrit.wikimedia.org/r/992227

Maintenance_bot removed a project: Patch-For-Review.Jan 22 2024, 8:31 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits