ExpensiveUserImpact.php on line 144
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Urbanecm_WMF
	Oct 19 2023, 12:36 PM

Description

Steps to replicate the issue (include links if applicable):

Access Special:Homepage locally with new impact enabled

What happens?:

A deprecation warning shows:

Deprecated: DateTime::__construct(): Passing null to parameter #1 ($datetime) of type string is deprecated in /var/www/html/w/extensions/GrowthExperiments/includes/UserImpact/ExpensiveUserImpact.php on line 144

What should have happened instead?:

No deprecation warning

Software version (skip for WMF-hosted wikis like Wikipedia):

urbanecm@wmf3345 GrowthExperiments % git show -s HEAD
commit 68c84322cfdc944ed975ed4bc30b46578521a469 (HEAD -> master, origin/master, origin/HEAD)
Author: [BOT] Translation updater bot <l10n-bot@translatewiki.net>
Date:   Thu Oct 19 08:42:19 2023 +0200

    Localisation updates from https://translatewiki.net.
    
    Change-Id: If2a376ef3982790b9f2f2a5a60d325c87aab00bc

urbanecm@wmf3345 core % git show -s HEAD
commit 5df8b7758d4acd70430053d7c00acea74995866a (HEAD -> master, origin/master, origin/HEAD)
Author: [BOT] Translation updater bot <l10n-bot@translatewiki.net>
Date:   Thu Oct 19 08:22:51 2023 +0200

    Localisation updates from https://translatewiki.net.
    
    Change-Id: I11f571d1349dbb683594340da5f753c81db84e65
urbanecm@wmf3345 core %

Details

	Subject	Repo	Branch	Lines +/-
	ExpensiveUserImpact: Do not pass null to DateTime constructor	mediawiki/extensions/GrowthExperiments	master	+43 -1

Customize query in gerrit

Event Timeline

Urbanecm_WMF created this task.Oct 19 2023, 12:36 PM

Restricted Application added a project: Growth-Team. · View Herald TranscriptOct 19 2023, 12:36 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Reedy added a project: PHP 8.1 support.Oct 19 2023, 2:34 PM

Change 968761 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] ExpensiveUserImpact: Do not pass null to DateTime constructor

https://gerrit.wikimedia.org/r/968761

gerritbot added a project: Patch-For-Review.Oct 25 2023, 9:53 PM

Upon reviewing this, I feel like ExpensiveUserImpact::isPageViewDataStale returns false for no-pageview scenario, even though it probably shouldn't. See justification in the commit message.

Urbanecm_WMF moved this task from Incoming to Code Review on the Growth-Team (Sprint 1 (Growth Team)) board.Oct 25 2023, 9:54 PM

Urbanecm_WMF moved this task from Code Review to QA on the Growth-Team (Sprint 1 (Growth Team)) board.Oct 26 2023, 12:42 PM

Change 968761 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] ExpensiveUserImpact: Do not pass null to DateTime constructor

https://gerrit.wikimedia.org/r/968761

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.3; 2023-10-31).Oct 26 2023, 1:00 PM

Maintenance_bot removed a project: Patch-For-Review.Oct 26 2023, 1:10 PM

Etonkovidova moved this task from QA to Test in Production on the Growth-Team (Sprint 1 (Growth Team)) board.Oct 27 2023, 12:20 AM

Etonkovidova closed this task as Resolved.Nov 3 2023, 11:22 PM