Page MenuHomePhabricator
Create Task
Maniphest T349387

Curation toolbar: Convert Wikilove component to Vue.js
Closed, ResolvedPublic3 Estimated Story Points
Actions

Assigned To
Dillon
Authored By
Samwalton9-WMF
Oct 20 2023, 2:35 PM
Tags
Referenced Files
F65961415: image.png
Sep 4 2025, 6:12 PM
F65949615: Screenshot 2025-09-02 at 12.50.28.png
Sep 2 2025, 6:56 PM
F65949613: Screenshot 2025-09-02 at 12.55.59.png
Sep 2 2025, 6:56 PM
F38924102: Screenshot 2023-10-20 at 15.34.37.png
Oct 20 2023, 2:35 PM
Subscribers
Aklapper
jsn.sherman
Kgraessle
Novem_Linguae
Samwalton9-WMF
Scardenasmolinar

Description

As part of our efforts to migrate PageTriage to Vue.js, we want to take a piecemeal approach to converting the Curation Toolbar - going one component at a time.

This task covers conversion of the Wikilove component:

Screenshot 2023-10-20 at 15.34.37.png (278×1 px, 71 KB)

Acceptance criteria:

  • duplicates current behavior, with the possible exception of bug fixes
  • as similar as possible to current style as possible
  • protected by pagetriage_ui=wikilove url parameter feature flag
  • uses common flyout code T376103
  • uses updated toolIcon code T376101

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Fixed tags button whitespace regressionmediawiki/extensions/PageTriagemaster+9 -0
Convert WikiLove component to Vuemediawiki/extensions/PageTriagemaster+588 -131
Customize query in gerrit

Related Objects
Search...

Event Timeline

Samwalton9-WMF created this task.Oct 20 2023, 2:35 PM
Samwalton9-WMF mentioned this in T340117: PageTriage: Implement Curation Toolbar in Vue.js.Oct 20 2023, 2:43 PM
Samwalton9-WMF moved this task from Backlog to Vue migration bugs on the PageTriage board.Oct 20 2023, 3:37 PM
MPGuy2824 moved this task from Vue migration bugs to Other bugs on the PageTriage board.Dec 2 2023, 9:54 AM
MPGuy2824 moved this task from Other bugs to Vue migration bugs on the PageTriage board.
Novem_Linguae moved this task from Vue migration bugs to Vue migration rewrites on the PageTriage board.Jan 9 2024, 4:16 PM
Samwalton9-WMF moved this task from Inbox to Triaged on the Moderator-Tools-Team board.Apr 8 2024, 11:37 AM
jsn.sherman updated the task description. (Show Details)Oct 1 2024, 5:20 PM
jsn.sherman moved this task from Triaged to To be estimated on the Moderator-Tools-Team board.
jsn.sherman set the point value for this task to 3.Oct 2 2024, 5:22 PM
jsn.sherman moved this task from To be estimated to Up next on the Moderator-Tools-Team board.Oct 9 2024, 5:53 PM
Samwalton9-WMF moved this task from Up next to Estimated on the Moderator-Tools-Team board.Oct 28 2024, 5:14 PM
Scardenasmolinar triaged this task as Low priority.Jan 7 2025, 4:31 PM
jsn.sherman assigned this task to Dillon.Aug 5 2025, 3:07 PM
jsn.sherman edited projects, added Moderator-Tools-Team (Kanban); removed Moderator-Tools-Team.
jsn.sherman changed the task status from Open to In Progress.Aug 12 2025, 2:44 PM
jsn.sherman moved this task from Ready to In Progress on the Moderator-Tools-Team (Kanban) board.
gerritbot added a comment.Aug 15 2025, 10:38 PM

Change #1179229 had a related patch set uploaded (by Dillon; author: Dillon):

[mediawiki/extensions/PageTriage@master] Convert WikiLove component to Vue

https://gerrit.wikimedia.org/r/1179229

gerritbot added a project: Patch-For-Review.Aug 15 2025, 10:38 PM
Scardenasmolinar moved this task from In Progress to Eng review on the Moderator-Tools-Team (Kanban) board.Aug 16 2025, 12:40 AM
Kgraessle moved this task from Eng review to Reviewed (waiting for changes) on the Moderator-Tools-Team (Kanban) board.Aug 18 2025, 4:16 PM
Kgraessle moved this task from Reviewed (waiting for changes) to Eng review on the Moderator-Tools-Team (Kanban) board.Aug 21 2025, 7:19 PM
Kgraessle moved this task from Eng review to Reviewed (waiting for changes) on the Moderator-Tools-Team (Kanban) board.Aug 21 2025, 9:43 PM
Dillon moved this task from Reviewed (waiting for changes) to Eng review on the Moderator-Tools-Team (Kanban) board.Aug 28 2025, 3:11 PM
PatchDemoBot added a comment.Aug 28 2025, 8:25 PM

Test wiki created on Patch demo by KGraessle-WMF using patch(es) linked to this task:
https://769779a8b0.catalyst.wmcloud.org/w/

Kgraessle moved this task from Eng review to Reviewed (waiting for changes) on the Moderator-Tools-Team (Kanban) board.Aug 28 2025, 8:53 PM
Dillon moved this task from Reviewed (waiting for changes) to Eng review on the Moderator-Tools-Team (Kanban) board.Sep 2 2025, 4:06 PM
PatchDemoBot added a comment.Sep 2 2025, 6:40 PM

Test wiki on Patch demo by KGraessle-WMF using patch(es) linked to this task was deleted:

https://769779a8b0.catalyst.wmcloud.org/w/

PatchDemoBot added a comment.Sep 2 2025, 6:42 PM

Test wiki created on Patch demo by KGraessle-WMF using patch(es) linked to this task:
https://bb1a8e54a5.catalyst.wmcloud.org/w/

Scardenasmolinar subscribed.Sep 2 2025, 6:56 PM

I think this patch is almost ready to merge, just one final comment, per the code review I made on Gerrit.

The page creator always needs to be the first editor on the list, regardless of the edit count.

This is the current behavior:

Screenshot 2025-09-02 at 12.55.59.png (404×1 px, 74 KB)

This is the latest patch:

Screenshot 2025-09-02 at 12.50.28.png (478×1 px, 80 KB)

Scardenasmolinar moved this task from Eng review to Reviewed (waiting for changes) on the Moderator-Tools-Team (Kanban) board.Sep 2 2025, 6:58 PM
Dillon added a comment.Sep 2 2025, 7:41 PM
In T349387#11140822, @Scardenasmolinar wrote:

I think this patch is almost ready to merge, just one final comment, per the code review I made on Gerrit.

The page creator always needs to be the first editor on the list, regardless of the edit count.

This is the current behavior:

Screenshot 2025-09-02 at 12.55.59.png (404×1 px, 74 KB)

This is the latest patch:

Screenshot 2025-09-02 at 12.50.28.png (478×1 px, 80 KB)

Fixed!

Scardenasmolinar added a comment.Sep 2 2025, 10:01 PM

I don't see the changes in the Gerrit patch. Can you check if you uploaded the changes?

Dillon moved this task from Reviewed (waiting for changes) to Eng review on the Moderator-Tools-Team (Kanban) board.Sep 3 2025, 3:15 PM
Dillon added a comment.Sep 3 2025, 3:21 PM
In T349387#11141748, @Scardenasmolinar wrote:

I don't see the changes in the Gerrit patch. Can you check if you uploaded the changes?

All the changes should be pushed now.

Scardenasmolinar moved this task from Eng review to QA on the Moderator-Tools-Team (Kanban) board.Sep 3 2025, 4:45 PM
gerritbot added a comment.Sep 3 2025, 6:06 PM

Change #1179229 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] Convert WikiLove component to Vue

https://gerrit.wikimedia.org/r/1179229

Maintenance_bot removed a project: Patch-For-Review.Sep 3 2025, 6:32 PM
ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.18; 2025-09-09).Sep 3 2025, 7:00 PM
Kgraessle moved this task from QA to In Progress on the Moderator-Tools-Team (Kanban) board.Sep 4 2025, 6:06 PM
Scardenasmolinar added a comment.Sep 4 2025, 6:12 PM

Looks like we have a small bug that needs to be fixed. It probably has to do with code erased in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/PageTriage/+/1179229/20/modules/ext.pageTriage.toolbar/ToolbarView.less

image.png (531×666 px, 76 KB)

gerritbot added a comment.Sep 4 2025, 6:26 PM

Change #1184897 had a related patch set uploaded (by Dillon; author: Dillon):

[mediawiki/extensions/PageTriage@master] Fixed tags button whitespace regression

https://gerrit.wikimedia.org/r/1184897

gerritbot added a project: Patch-For-Review.Sep 4 2025, 6:26 PM
Dillon moved this task from In Progress to Eng review on the Moderator-Tools-Team (Kanban) board.Sep 4 2025, 6:28 PM
PatchDemoBot added a comment.Sep 4 2025, 7:11 PM

Test wiki on Patch demo by KGraessle-WMF using patch(es) linked to this task was deleted:

https://bb1a8e54a5.catalyst.wmcloud.org/w/

PatchDemoBot added a comment.Sep 4 2025, 7:13 PM

Test wiki created on Patch demo by KGraessle-WMF using patch(es) linked to this task:
https://35a7d8bbe2.catalyst.wmcloud.org/w/

PatchDemoBot added a comment.Sep 4 2025, 7:16 PM

Test wiki on Patch demo by KGraessle-WMF using patch(es) linked to this task was deleted:

https://35a7d8bbe2.catalyst.wmcloud.org/w/

PatchDemoBot added a comment.Sep 4 2025, 7:18 PM

Test wiki created on Patch demo by KGraessle-WMF using patch(es) linked to this task:
https://848d6dfaa3.catalyst.wmcloud.org/w/

Kgraessle subscribed.Sep 4 2025, 7:32 PM
This comment was removed by Kgraessle.
gerritbot added a comment.Sep 5 2025, 12:30 AM

Change #1184897 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] Fixed tags button whitespace regression

https://gerrit.wikimedia.org/r/1184897

Maintenance_bot removed a project: Patch-For-Review.Sep 5 2025, 12:31 AM
Scardenasmolinar moved this task from Eng review to QA on the Moderator-Tools-Team (Kanban) board.Sep 5 2025, 1:28 AM
Samwalton9-WMF mentioned this in T404405: Cannot type in some textboxes from the page curation toolbar.Sep 15 2025, 8:10 AM
Scardenasmolinar added a comment.Sep 17 2025, 6:22 PM

@Samwalton9-WMF, can you help us QA this ticket in enwiki?

Samwalton9-WMF added a comment.Sep 18 2025, 11:33 AM

T404909 is the only thing I noticed, LGTM otherwise!

Kgraessle closed this task as Resolved.Sep 18 2025, 4:04 PM
Kgraessle moved this task from QA to Done on the Moderator-Tools-Team (Kanban) board.
PatchDemoBot added a comment.Sep 25 2025, 6:07 PM

Test wiki on Patch demo by KGraessle-WMF using patch(es) linked to this task was deleted:

https://848d6dfaa3.catalyst.wmcloud.org/w/

jsn.sherman updated the task description. (Show Details)Oct 7 2025, 1:45 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits