Diff of templates in table detects unchanged templates as changed
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Esanders
	Oct 30 2023, 1:43 PM

Description

All these rows were unchanged:

Subject	Repo	Branch	Lines +/-
Update VE core submodule to master (df7099eab)	mediawiki/extensions/VisualEditor	master	+2 -1
Tree diffs: Use VisualDiff#compareNodes	VisualEditor/VisualEditor	master	+4 -9
Tree diffs: Add failing test case for templates in table diff	VisualEditor/VisualEditor	master	+22 -0

Mentioned In: T332791: Some unchanged table cells shown as empty in visual diff

Change 969952 had a related patch set uploaded (by Esanders; author: Esanders):

[VisualEditor/VisualEditor@master] Tree diffs: Use VisualDiff#compareNodes

Change 970383 had a related patch set uploaded (by Esanders; author: Esanders):

[VisualEditor/VisualEditor@master] Tree diffs: Add failing test case for templates in table diff

After:

Change 970383 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] Tree diffs: Add failing test case for templates in table diff

Change 969952 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] Tree diffs: Use VisualDiff#compareNodes

Change 972466 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (df7099eab)

Change 972466 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (df7099eab)

	F41449882: image.png
	Nov 5 2023, 1:22 PM