Some unchanged table cells shown as empty in visual diff
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	matmarex
	Mar 22 2023, 3:20 PM

Description

Some unchanged table cells shown as empty in this visual diff: https://www.mediawiki.org/w/index.php?title=Extension%3ADiscussionTools%2FComparison&diff=prev&oldid=5839291&diffmode=visual

Compare to this diff, which shows the expected cell content: https://www.mediawiki.org/w/index.php?title=Extension%3ADiscussionTools%2FComparison&diff=prev&oldid=5839289&diffmode=visual

Maybe related to https://gerrit.wikimedia.org/r/c/VisualEditor/VisualEditor/+/754609? I haven't seen this issue ever before.

Details

Subject	Repo	Branch	Lines +/-
Update VE core submodule to master (df7099eab)	mediawiki/extensions/VisualEditor	master	+2 -1
Tree diffs: Use VisualDiff#compareNodes	VisualEditor/VisualEditor	master	+4 -9
Tree diffs: Add failing test case for templates in table diff	VisualEditor/VisualEditor	master	+22 -0

Customize query in gerrit

Related Objects

Mentioned Here: T350032: Diff of templates in table detects unchanged templates as changed

Event Timeline

matmarex created this task.Mar 22 2023, 3:20 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 22 2023, 3:20 PM

Couldn't reproduce in the editor, so could be a quirk of the history page diff:

Esanders attached a referenced file: F36922859: image.png. (Show Details)Mar 22 2023, 3:56 PM

ppelberg moved this task from To Triage to Triaged on the VisualEditor board.Mar 23 2023, 3:49 PM

matmarex added a project: VisualEditor-VisualDiffs.Nov 4 2023, 1:55 AM

Could be a duplicate of T350032

Fixed by https://gerrit.wikimedia.org/r/c/VisualEditor/VisualEditor/+/969952/2

Change 970383 had a related patch set uploaded (by Bartosz Dziewoński; author: Esanders):

[VisualEditor/VisualEditor@master] Tree diffs: Add failing test case for templates in table diff

https://gerrit.wikimedia.org/r/970383

Change 969952 had a related patch set uploaded (by Bartosz Dziewoński; author: Esanders):

[VisualEditor/VisualEditor@master] Tree diffs: Use VisualDiff#compareNodes

https://gerrit.wikimedia.org/r/969952

Change 970383 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] Tree diffs: Add failing test case for templates in table diff

https://gerrit.wikimedia.org/r/970383

Change 969952 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] Tree diffs: Use VisualDiff#compareNodes

https://gerrit.wikimedia.org/r/969952

Maintenance_bot removed a project: Patch-For-Review.Nov 7 2023, 8:30 PM

Change 972466 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (df7099eab)

https://gerrit.wikimedia.org/r/972466

gerritbot added a project: Patch-For-Review.Nov 7 2023, 8:42 PM

Change 972466 merged by jenkins-bot: