Page MenuHomePhabricator

TypeError: DOMElement::setAttribute() expects parameter 2 to be string, null given
Closed, ResolvedPublic

Description

TypeError: DOMElement::setAttribute() expects parameter 2 to be string, null given in /srv/mediawiki/w/vendor/wikimedia/parsoid/src/Wt2Html/PP/Processors/AddMediaInfo.php on line 193

Running MediaWiki 1.40 and php 7.4.

This is triggered when running parsoidCachePrewarm job (not all the time but seems to happen frequently enough).

Event Timeline

Change 971537 had a related patch set uploaded (by Paladox; author: Paladox):

[mediawiki/services/parsoid@REL1_40] Fix "DOMElement::setAttribute() expects parameter 2 to be string, null given"

https://gerrit.wikimedia.org/r/971537

Change 971537 merged by jenkins-bot:

[mediawiki/services/parsoid@REL1_40] Fix "DOMElement::setAttribute() expects parameter 2 to be string, null given"

https://gerrit.wikimedia.org/r/971537

Change 972412 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/vendor@REL1_40] Update wikimedia/parsoid to 0.17.2

https://gerrit.wikimedia.org/r/972412

cscott claimed this task.

Change 972412 abandoned by Reedy:

[mediawiki/vendor@REL1_40] Update wikimedia/parsoid to 0.17.2

Reason:

Iebabdfb8aa91996409f75ca16481a5dc587e33d2 bumped to 0.17.3

https://gerrit.wikimedia.org/r/972412

Can this change be backported to the 1.39 LTS branch? This is a reproducible bug, see https://github.com/openstreetmap/operations/issues/1025

Change 1000085 had a related patch set uploaded (by Arlolra; author: Paladox):

[mediawiki/services/parsoid@REL1_39] Fix "DOMElement::setAttribute() expects parameter 2 to be string, null given"

https://gerrit.wikimedia.org/r/1000085

Change 1000085 merged by jenkins-bot:

[mediawiki/services/parsoid@REL1_39] Fix "DOMElement::setAttribute() expects parameter 2 to be string, null given"

https://gerrit.wikimedia.org/r/1000085

Change 1002652 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/vendor@REL1_39] Update wikimedia/parsoid to 0.16.3

https://gerrit.wikimedia.org/r/1002652

Change 1002655 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/core@REL1_39] Update wikimedia/parsoid to 0.16.3

https://gerrit.wikimedia.org/r/1002655

Change 1002652 merged by Arlolra:

[mediawiki/vendor@REL1_39] Update wikimedia/parsoid to 0.16.3

https://gerrit.wikimedia.org/r/1002652

Change 1002655 merged by jenkins-bot:

[mediawiki/core@REL1_39] Update wikimedia/parsoid to 0.16.3

https://gerrit.wikimedia.org/r/1002655