Page MenuHomePhabricator

[S] Make ReportIncident available on all skins
Closed, ResolvedPublic

Assigned To
Authored By
Madalina
Nov 7 2023, 11:46 AM
Referenced Files
F41468066: image.png
Nov 9 2023, 2:49 PM
F41468002: image.png
Nov 9 2023, 2:49 PM
F41467987: image.png
Nov 9 2023, 2:49 PM
F41467862: image.png
Nov 9 2023, 2:49 PM
F41467852: image.png
Nov 9 2023, 2:49 PM
F41467701: image.png
Nov 9 2023, 2:49 PM
F41467709: image.png
Nov 9 2023, 2:49 PM
F41467521: image.png
Nov 9 2023, 2:49 PM

Description

Background

Currently ReportIncident is only available on Vector and Minerva skins. As not everyone is using these, we might prevent some users from accessing ReportIncident and filing reports.

Acceptance Criteria

  • ReportIncident is available on all skins (Vector 2022, Vector 2010, Minerva, Monobook, Timeless)

Event Timeline

Change 972380 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/ReportIncident@master] ReportIncidentController: Allow wildcard for all skins

https://gerrit.wikimedia.org/r/972380

Change 972380 merged by jenkins-bot:

[mediawiki/extensions/ReportIncident@master] ReportIncidentController: Allow wildcard for all skins

https://gerrit.wikimedia.org/r/972380

Change 972392 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/ReportIncident@master] Fixes to code to support Timeless and Monobook

https://gerrit.wikimedia.org/r/972392

For QA I suggest (for patchdemo or betawikis):

  1. Switching to a skin other than Vector 2022 or Monobook in Special:Preferences
  2. Going to a user talk page
  3. Verifying that the Report links are shown

You can repeat these steps for a variety of skins if desired.

Dreamy_Jazz renamed this task from Make ReportIncident available on all skins to [S] Make ReportIncident available on all skins.Nov 7 2023, 3:36 PM

Test wiki created on Patch demo by DJacksonA using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/9c288a6eec/w

Change 972470 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/ReportIncident@master] Remove ability to restrict availability by skin

https://gerrit.wikimedia.org/r/972470

Test wiki created on Patch demo by DJacksonA using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/aca05b71da/w

Change 972470 merged by jenkins-bot:

[mediawiki/extensions/ReportIncident@master] Remove ability to restrict availability by skin

https://gerrit.wikimedia.org/r/972470

Per the ticket Description, I have verified the new code has been implemented.
Thank you @Dreamy_Jazz for the QA Steps.


Testing was executed at the following urls:
https://ca.wikipedia.beta.wmflabs.org
https://cs.wikipedia.beta.wmflabs.org
https://crh.m.wikipedia.beta.wmflabs.org
https://de.wikipedia.beta.wmflabs.org
https://en.wikipedia.beta.wmflabs.org
https://eo.wikipedia.beta.wmflabs.org
https://fa.wikipedia.beta.wmflabs.org
https://he.wikipedia.beta.wmflabs.org
https://hi.wikipedia.beta.wmflabs.org
https://ko.wikipedia.beta.wmflabs.org
https://patchdemo.wmflabs.org/wikis/9c288a6eec/w
https://patchdemo.wmflabs.org/wikis/aca05b71da/w


Old Vector 2010 skin using Beta Wiki

image.png (667×1 px, 144 KB)


Timeless skin using Beta Wiki

image.png (928×1 px, 270 KB)


Monobook skin using Beta Wiki

image.png (956×1 px, 178 KB)

image.png (557×1 px, 307 KB)


Vector 2022 skin using Beta Wiki

image.png (775×1 px, 281 KB)


Minerva skin using Beta Wiki

image.png (948×1 px, 336 KB)


Monobook skin using Patch Demo

image.png (777×1 px, 95 KB)


Minerva skin using Patch Demo

image.png (704×1 px, 81 KB)


Timeless skin using Patch Demo

image.png (909×1 px, 105 KB)


Vector 2010 skin using Patch Demo

image.png (751×1 px, 83 KB)


Vector 2022 skin using Patch Demo

image.png (740×1 px, 81 KB)


Cologne Blue skin using Patch Demo

image.png (814×1 px, 87 KB)


Modern skin using Patch Demo

image.png (622×813 px, 58 KB)

Dreamy_Jazz updated the task description. (Show Details)

Test wiki on Patch demo by DJacksonA using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/9c288a6eec/w/

Test wiki on Patch demo by DJacksonA using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/aca05b71da/w/