Page MenuHomePhabricator

Use expression builder instead of raw SQL in CentralNotice
Closed, ResolvedPublic

Description

Now that T210206: Deprecate raw SQL conditions for IDatabase methods (select, insert, etc.) is done, this extension should migrate away from building and passing around raw SQL to expression builders.

It improves readability and security of the code and is more aligned with industry practices easing onboarding.

For more information check T210206 and T350075.

Calls to Database::addQuotes(), ::buildLike(), ::makeList() indicate that raw SQL is being built and passed around.

Event Timeline

Change #1033107 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/CentralNotice@master] pagers: Use expression builder

https://gerrit.wikimedia.org/r/1033107

Change #1037446 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/CentralNotice@master] Use expression builder to replace addQuotes

https://gerrit.wikimedia.org/r/1037446

Change #1037446 merged by jenkins-bot:

[mediawiki/extensions/CentralNotice@master] Use expression builder to replace addQuotes

https://gerrit.wikimedia.org/r/1037446

Change #1033107 merged by jenkins-bot:

[mediawiki/extensions/CentralNotice@master] pagers: Use expression builder

https://gerrit.wikimedia.org/r/1033107

Change #1052668 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/CentralNotice@wmf_deploy] Merge branch 'master' into wmf_deploy

https://gerrit.wikimedia.org/r/1052668

Change #1052668 merged by jenkins-bot:

[mediawiki/extensions/CentralNotice@wmf_deploy] Merge branch 'master' into wmf_deploy

https://gerrit.wikimedia.org/r/1052668