Use expression builder instead of raw SQL in ContentTranslation
Open, LowPublic
Actions

Assigned To

None

Authored By

	Maintenance_bot
	Nov 10 2023, 4:20 PM

Description

Now that T210206: Deprecate raw SQL conditions for IDatabase methods (select, insert, etc.) is done, this extension should migrate away from building and passing around raw SQL to expression builders.

It improves readability and security of the code and is more aligned with industry practices easing onboarding.

For more information check T210206 and T350075.

Calls to Database::addQuotes(), ::buildLike(), ::makeList() indicate that raw SQL is being built and passed around.

	Subject	Repo	Branch	Lines +/-
	Use expression builder to build where conditions	mediawiki/extensions/ContentTranslation	master	+4 -11
	Store: Inline conditions into SelectQueryBuilder call	mediawiki/extensions/ContentTranslation	master	+31 -36

		Status	Subtype	Assigned	Task
		Open		None	T350075 Migrate raw SQL building in conditions to expression builder in WMF-deployed extensions
		Open		None	T350967 Use expression builder instead of raw SQL in ContentTranslation

Pginer-WMF triaged this task as Low priority.Nov 20 2023, 11:16 AM

Change #1032879 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/ContentTranslation@master] Store: Inline conditions into SelectQueryBuilder call

Change #1032879 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] Store: Inline conditions into SelectQueryBuilder call

Change #1037447 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/ContentTranslation@master] Use expression builder to replace addQuotes

Change #1037447 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] Use expression builder to build where conditions