Page MenuHomePhabricator
Create Task
Maniphest T350967

Use expression builder instead of raw SQL in ContentTranslation
Closed, ResolvedPublic
Actions

Description

Now that T210206: Deprecate raw SQL conditions for IDatabase methods (select, insert, etc.) is done, this extension should migrate away from building and passing around raw SQL to expression builders.

It improves readability and security of the code and is more aligned with industry practices easing onboarding.

For more information check T210206 and T350075.

Calls to Database::addQuotes(), ::buildLike(), ::makeList() indicate that raw SQL is being built and passed around.

Details

SubjectRepoBranchLines +/-
Use expression builder to avoid IDatabase::makeListmediawiki/extensions/ContentTranslationmaster+15 -27
Use expression builder for sql escaping in RecentSignificantEditStoremediawiki/extensions/ContentTranslationmaster+2 -2
Use expression builder to build where conditionsmediawiki/extensions/ContentTranslationmaster+4 -11
Store: Inline conditions into SelectQueryBuilder callmediawiki/extensions/ContentTranslationmaster+31 -36
Customize query in gerrit

Related Objects
Search...

Event Timeline

Maintenance_bot created this task.Nov 10 2023, 4:20 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 10 2023, 4:20 PM
Ladsgroup added a project: ContentTranslation.Nov 10 2023, 5:09 PM
Pginer-WMF triaged this task as Low priority.Nov 20 2023, 11:16 AM
Pginer-WMF added a project: Language-Team (Language-2023-October-December).
Pginer-WMF moved this task from Needs Triage to Enhancements on the ContentTranslation board.
gerritbot added a comment.May 17 2024, 9:53 PM

Change #1032879 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/ContentTranslation@master] Store: Inline conditions into SelectQueryBuilder call

https://gerrit.wikimedia.org/r/1032879

gerritbot added a project: Patch-For-Review.May 17 2024, 9:53 PM
gerritbot added a comment.May 20 2024, 11:51 AM

Change #1032879 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] Store: Inline conditions into SelectQueryBuilder call

https://gerrit.wikimedia.org/r/1032879

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.6; 2024-05-21).May 20 2024, 12:00 PM
Maintenance_bot removed a project: Patch-For-Review.May 20 2024, 12:31 PM
gerritbot added a comment.May 30 2024, 9:19 AM

Change #1037447 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/ContentTranslation@master] Use expression builder to replace addQuotes

https://gerrit.wikimedia.org/r/1037447

gerritbot added a project: Patch-For-Review.May 30 2024, 9:19 AM
gerritbot added a comment.Jun 3 2024, 7:13 PM

Change #1037447 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] Use expression builder to build where conditions

https://gerrit.wikimedia.org/r/1037447

Maintenance_bot removed a project: Patch-For-Review.Jun 3 2024, 7:31 PM
ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.8; 2024-06-04); removed MW-1.43-notes (1.43.0-wmf.6; 2024-05-21).Jun 3 2024, 8:00 PM
gerritbot added a comment.Jul 21 2024, 3:18 PM

Change #1055586 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/ContentTranslation@master] Use expression builder to avoid IDatabase::makeList

https://gerrit.wikimedia.org/r/1055586

gerritbot added a project: Patch-For-Review.Jul 21 2024, 3:18 PM
gerritbot added a comment.Jul 21 2024, 7:59 PM

Change #1055615 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/ContentTranslation@master] Use expression builder for sql escaping in RecentSignificantEditStore

https://gerrit.wikimedia.org/r/1055615

gerritbot added a comment.Aug 5 2024, 12:26 PM

Change #1055615 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] Use expression builder for sql escaping in RecentSignificantEditStore

https://gerrit.wikimedia.org/r/1055615

ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.17; 2024-08-06); removed MW-1.43-notes (1.43.0-wmf.8; 2024-06-04).Aug 5 2024, 1:00 PM
Atieno closed this task as Resolved.Sep 12 2024, 10:19 AM
gerritbot added a comment.Oct 1 2024, 7:54 PM

Change #1055586 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] Use expression builder to avoid IDatabase::makeList

https://gerrit.wikimedia.org/r/1055586

ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.26; 2024-10-08); removed MW-1.43-notes (1.43.0-wmf.17; 2024-08-06).Oct 1 2024, 8:00 PM
Maintenance_bot removed a project: Patch-For-Review.Oct 1 2024, 8:31 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits