Page MenuHomePhabricator

Consider adding key for 'function' or 'function call' to Z506 & Z517
Closed, ResolvedPublic

Description

Description

Z506 / Argument type mismatch and Z517 / Return type mismatch are error types that can result from specific function calls. When an instance of one of these error types gets reported back to a user, it may not be clear to the user which function call led to the error. (In many cases, it will be implicitly clear from context, but not always. For example, a top-level call to a composition function can involve calls to many nested functions.) Thus, it will be helpful in such cases to report back to the user which function call led to the error.

  • Consider adding a key to Z506 and to Z517 to report either the entire function call, or the called function's identity.
  • If that is done, upgrade each usage of those 2 error types in the orchestrator to employ the new key.
  • If that is done, upgrade each usage of those 2 error types in the evaluator, if any, to employ the new key.

Completion checklist

Event Timeline

After reviewing other error types used by the orchestrator (of which only one reports the complete function call object), I believe this ticket is not well justified. I believe the added information would only be useful in rare cases. Some orchestrator code would need to be modified to support this, in addition to deploying the updated definitions, and the effort doesn't seem warranted.