Page MenuHomePhabricator
Create Task
Maniphest T351474

Special:NewPagesFeed: change New Page Patrol and Articles For Creation tabs to buttons
Closed, ResolvedPublicBUG REPORT
Actions

Description

Reported by @Significa_liberdade on Discord

Steps to replicate the issue (include links if applicable):

What happens?:

  • Not obvious that these are buttons

image.png (534×2 px, 74 KB)

What should have happened instead?:

  • Make it obvious that these are buttons. I suggest using cdx-toggle-button cdx-toggle-button--framed cdx-toggle-button--toggled-on and cdx-toggle-button cdx-toggle-button--framed cdx-toggle-button--toggled-off

image.png (123×369 px, 3 KB)

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

  • Will also fix the below bug, which happens when you scroll down a bit:

image.png (519×2 px, 83 KB)

Details

SubjectRepoBranchLines +/-
Fix accessibility concerns with top tabsmediawiki/extensions/PageTriagemaster+37 -19
Customize query in gerrit

Event Timeline

Novem_Linguae created this task.Nov 16 2023, 10:07 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 16 2023, 10:07 PM
Novem_Linguae updated the task description. (Show Details)Nov 16 2023, 10:09 PM
Novem_Linguae moved this task from Backlog to Vue migration bugs on the PageTriage board.Nov 16 2023, 10:17 PM
Significa_liberdade added a comment.Nov 16 2023, 10:36 PM

As this update is made, it also needs to be noted that when using a keyboard only (which is an accessibility concern), the user cannot switch between NPP and AfC.

gerritbot added a comment.Nov 17 2023, 10:33 AM

Change 975237 had a related patch set uploaded (by Sohom Datta; author: Sohom Datta):

[mediawiki/extensions/PageTriage@master] Fix accessibility concerns with top tabs

https://gerrit.wikimedia.org/r/975237

gerritbot added a project: Patch-For-Review.Nov 17 2023, 10:33 AM
MPGuy2824 assigned this task to Soda.Nov 19 2023, 5:41 AM
MPGuy2824 moved this task from Vue migration bugs to Code Review on the PageTriage board.
Scardenasmolinar added a project: Moderator-Tools-Team (Kanban).Nov 29 2023, 4:11 AM
Scardenasmolinar moved this task from Ready to Code review on the Moderator-Tools-Team (Kanban) board.
gerritbot added a comment.Nov 29 2023, 6:17 PM

Change 975237 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] Fix accessibility concerns with top tabs

https://gerrit.wikimedia.org/r/975237

Scardenasmolinar moved this task from Code review to Done on the Moderator-Tools-Team (Kanban) board.Nov 29 2023, 6:19 PM
Scardenasmolinar moved this task from Code Review to Waiting for enwiki deploy on the PageTriage board.
Maintenance_bot removed a project: Patch-For-Review.Nov 29 2023, 6:30 PM
ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.9; 2023-12-12).Nov 29 2023, 7:00 PM
MPGuy2824 closed this task as Resolved.Dec 15 2023, 2:31 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL