Page MenuHomePhabricator

Codex content guidelines: fast follows
Closed, ResolvedPublic

Description

Background/Goal

Small tasks to follow the release of T311671.

Open questions

None

Acceptance criteria (or Done)

Design

  • update height of 'Do' image for Trustworthy in Writing for copy section
  • update the 'Do' and 'Don't' images to make the text more readable

Code

  • update 'Do' image for Trustworthy in Writing for copy section
  • use less spacing between Do/Dont image and icon/text label
  • update border to 2px
  • update font size to 14px
  • update the 'Do' and 'Don't' images with the text bigger
  • revise Link page heading links to match other components for table of contents
  • update do/dont on Contributing/Designing icons with new style
  • update do/dont on Contributing/Designing new components with new style

Event Timeline

@DTorsani-WMF while working on the design sign-off in T311671, I've found some improvements for the Do and Don't sections, so adding them here so we can work on them:

Generic feedback:
  1. Do and Don't examples in all the Content guidelines:
    • I would reduce the green and red lines from 2px since the current 4px is too big comparing it with the Do and Don't texts below.
    • What if we make the Do and Don't description text smaller (14px)?
      Captura de pantalla 2023-11-28 a las 20.31.01.png (736×1 px, 139 KB)
Voice & Tone:
  1. The Do and Don't images in the Second person section: the text is too small and not enough readable when Do and Don't images are next to each other (it's not ok on desktop and tablet, but it's ok on mobile when the images are one above each other). Could we increase it on the desktop?
    Captura de pantalla 2023-11-28 a las 19.31.32.png (782×1 px, 106 KB)
Writing for content:
  1. I would remove the bullets when there is just one Do or Don't. If we want to keep the bullets included when there is just one item in the list of Do/Don't, then I would add them in the Voice and tone > Second person.
    Captura de pantalla 2023-11-28 a las 20.16.54.png (1×1 px, 150 KB)
  1. "Is this relevant?" section: the text in the image is not readable, could we increase it by making the input more narrow?
    Captura de pantalla 2023-11-28 a las 20.20.34.png (806×1 px, 139 KB)
  1. "Design for consistency", "This is for everyone" and "Trustworthy yet joyful" sections: same here, the text in these images is not readable enough, could we increase it by making the components in these images more narrow?
    Captura de pantalla 2023-11-28 a las 20.23.00.png (964×1 px, 157 KB)
Recommendations for components:
  1. Images in their "Content" sections: we have the same problem with the images here since the text in these images is not readable enough. Could we increase these component's size to make the text more readable? In mostly of them we could solve it by making the component in the image more narrow.
    Captura de pantalla 2023-11-28 a las 20.41.46.png (650×1 px, 101 KB)

@bmartinezcalvo Thank you for providing this feedback. I'm glad you are commenting on the images feeling too small. I felt the same but it is helpful to hear that from another designer. The reason the images are the size they are is because everything is sized at 100% and proportional to one another. What I want to avoid is making one component or element larger in some cases and that not be proportional to another element in another screenshot. So I will try to see if I can make everything generally larger, as long as I can keep everything proportional. But I definitely agree that overall things need to be more legible. Thank you for this affirmation!

Change 978682 had a related patch set uploaded (by Dtorsani; author: Dtorsani):

[design/codex@main] docs: Misc fixes for content guidelines

https://gerrit.wikimedia.org/r/978682

@DTorsani-WMF I've reviewed your last patch with all the changes listed in the task. Everything looks great!

Change 978682 merged by jenkins-bot:

[design/codex@main] docs: Misc fixes for content guidelines

https://gerrit.wikimedia.org/r/978682

Change 980902 had a related patch set uploaded (by Anne Tomasevich; author: Anne Tomasevich):

[mediawiki/core@master] Update Codex from v1.0.1 to v1.1.1

https://gerrit.wikimedia.org/r/980902

Test wiki created on Patch demo by ATomasevich (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/d419984345/w

Change 980902 merged by jenkins-bot:

[mediawiki/core@master] Update Codex from v1.0.1 to v1.1.1

https://gerrit.wikimedia.org/r/980902

Test wiki on Patch demo by ATomasevich (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/d419984345/w/