Page MenuHomePhabricator
Create Task
Maniphest T35236

SF_Utils::formDropdownHTML needs proper i18n
Closed, ResolvedPublicBUG REPORT
Actions

Description

SF_Utils::formDropdownHTML Uses namespace name + colon as label for a <select>. Should use a message without hardcoded colon. In addition it should be wrapped with <label> to join it to the dropdown.

Version: unspecified
Severity: minor

Details

Reference
bz33236
SubjectRepoBranchLines +/-
Add i18n message for "Form:" labelmediawiki/extensions/PageFormsmaster+5 -9
Customize query in gerrit

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 21 2014, 11:58 PM
• bzimport added projects: MediaWiki-extensions-Page_Forms, I18n.
• bzimport set Reference to bz33236.
Nikerabbit created this task.Dec 18 2011, 3:31 PM
Yaron_Koren added a comment.Dec 19 2011, 1:52 AM

Thanks; I believe both of these are fixed now in SVN.

Nikerabbit added a comment.Dec 19 2011, 8:46 AM

I'd really like to have a real translatable message here, instead of trying to reuse the namespace name.

Aklapper removed Yaron_Koren as the assignee of this task.Sep 2 2015, 3:54 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 2 2015, 3:54 PM
Rammanojpotla added subscribers: Yaron_Koren, Rammanojpotla.Feb 12 2018, 5:29 AM

@Yaron_Koren is this issue got fixed?

Aklapper triaged this task as Low priority.Feb 4 2022, 8:07 PM
Aklapper changed the subtype of this task from "Task" to "Bug Report".
gerritbot added a comment.Apr 28 2023, 3:02 PM

Change 913214 had a related patch set uploaded (by Yaron Koren; author: Yaron Koren):

[mediawiki/extensions/PageForms@master] Add i18n message for "Form:" label

https://gerrit.wikimedia.org/r/913214

gerritbot added a project: Patch-For-Review.Apr 28 2023, 3:02 PM
gerritbot added a comment.Apr 28 2023, 3:40 PM

Change 913214 merged by jenkins-bot:

[mediawiki/extensions/PageForms@master] Add i18n message for "Form:" label

https://gerrit.wikimedia.org/r/913214

Yaron_Koren added a comment.Apr 28 2023, 3:44 PM

@Nikerabbit - better late than never, I hope!

Maintenance_bot removed a project: Patch-For-Review.Apr 28 2023, 4:11 PM
Yaron_Koren closed this task as Resolved.May 1 2023, 1:20 PM
Yaron_Koren claimed this task.

Marking as "Resolved" - I believe this is fully fixed now.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL