Page MenuHomePhabricator

Sitenotice elements are not centered in Serbian Wikipedia
Open, Needs TriagePublicBUG REPORT

Assigned To
None
Authored By
Kizule
Dec 3 2023, 12:30 PM
Referenced Files
F41582075: image.png
Dec 8 2023, 6:47 PM
F41582044: image.png
Dec 8 2023, 6:47 PM
F41557033: image.png
Dec 3 2023, 12:30 PM

Description

Steps to replicate the issue (include links if applicable):

  • Open Serbian Wikipedia

What happens?:
Elements from sitenotice are a lot on the left side.

What should have happened instead?:
It should be centered to align better.

Software version (skip for WMF-hosted wikis like Wikipedia):
Serbian Wikipedia and Vector 2022 skin.

Other information (browser name/version, screenshots, etc.):

image.png (472×1 px, 65 KB)

Event Timeline

You can see the same issue with other skins, e.g. https://sr.wikipedia.org/wiki/Главна_страна?safemode=1&debug=true&useskin=monobook

In the mediawiki/extensions/DismissableSiteNotice code repository, the file /modules/ext.dismissableSiteNotice.css defines

/* @noflip */ .sitedir-ltr .mw-dismissable-notice-body {
	margin: 0.5em 20% 0.5em 5em;
}

/* @noflip */ .sitedir-rtl .mw-dismissable-notice-body {
	margin: 0.5em 5em 0.5em 20%;
}

You can see the same issue with other skins, e.g. https://sr.wikipedia.org/wiki/Главна_страна?safemode=1&debug=true&useskin=monobook

In the mediawiki/extensions/DismissableSiteNotice code repository, the file /modules/ext.dismissableSiteNotice.css defines

/* @noflip */ .sitedir-ltr .mw-dismissable-notice-body {
	margin: 0.5em 20% 0.5em 5em;
}

/* @noflip */ .sitedir-rtl .mw-dismissable-notice-body {
	margin: 0.5em 5em 0.5em 20%;
}

Oh, I didn't know that it's the case for the other skins as well. Thank you for letting me know!

@Aklapper, I would like to confirm that the sitenotice alignment issue has been observed. Specifically, on both ckbwiki and kuwiki, we currently have an identical sitenotice.

image.png (768×1 px, 263 KB)
image.png (768×1 px, 226 KB)
On kuwiki, It is apparent that the sitenotice appears more left-aligned and lacks centering. No custom CSS styles has been applied in this case. kuwiki is a ltr site.On ckbwiki, it wasn't centered already, but I had to force it to be centered by adding custom CSS styles as you can see here. ckbwiki is a rtl site.