Page MenuHomePhabricator

[S] Update campaign ID format in fundraising campaign metrics
Closed, ResolvedPublic

Description

We should update the campaign_id that we send in the action_data key to fundraising campaign metrics.

iOS currently looks like: app_2023_enIT_iOS_control, app_2023_enNL_iOS_control
Android currently looks like NL_2023_11, IT_2023_11

We should update the campaign IDs to a format like: {assetlang}{campaign object id}_{platform}. For example: enNL_2023_11_iOS itIT_2023_11_Android

Speaking in terms of the config, use the id value, prefix the assets language, and append the platform.

This work should be done after Big English 2023.

Event Timeline

Tsevener renamed this task from Update campaign ID format in fundraising campaign metrics to [S] Update campaign ID format in fundraising campaign metrics.May 7 2024, 3:24 PM
Tsevener claimed this task.

Metrics fixed starting in TestFlight 7.5.1 (3601). This is going out to beta testers today.

SNowick_WMF claimed this task.
SNowick_WMF subscribed.

Validating we are seeing the expected new campaign ID values in action_data data

@SNowick_WMF We have a new proposition to send the Android format (JP_2024_05) to the FR Tech backend (See https://phabricator.wikimedia.org/T367360#9918686), and I feel like it would be confusing if campaign_ids we send to you do not match what we send to FR Tech. Should I undo the changes I made in this ticket to match Android?

@Tsevener As long as I have the correct values for querying each dataset it's fine for them to not match, I would defer to whatever FR Tech prefers for us to send and I can work around any inconsistencies - I use all their data for transactions, counts and financials and our in-app data for impressions. As long as I can differentiate impressions by campaign we are good.