base_string
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	AManWithNoPlan
	Dec 5 2023, 9:35 PM

Description

See: https://github.com/search?q=repo%3Awikimedia%2Fmediawiki-oauthclient-php%20base_string&type=code

$request->base_string is set several places, but does no appear to be read. Also, it is not defined within the class.

Details

	Subject	Repo	Branch	Lines +/-
	This variable is no longer used	mediawiki/oauthclient-php	master	+0 -3

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T314099 PHP 8.2: Dynamic property creation is deprecated
		Resolved	BUG REPORT	AManWithNoPlan	T352814 Undefined/unused variable $request->base_string

Event Timeline

AManWithNoPlan created this task.Dec 5 2023, 9:35 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 5 2023, 9:35 PM

Aklapper renamed this task from Undefined/unused variable to Undefined/unused variable $request->base_string.Dec 5 2023, 9:39 PM

Also:
Creation of dynamic property MediaWiki\OAuthClient\Client::$setExtraParams is deprecated in /data/project/citations/public_html/vendor/mediawiki/oauthclient/src/Client.php on line 203

Umherirrender added a project: PHP 8.2 support.Sun, Jun 30, 7:07 PM

Umherirrender added a parent task: T314099: PHP 8.2: Dynamic property creation is deprecated.Sun, Jun 30, 7:14 PM

https://gerrit.wikimedia.org/r/c/mediawiki/oauthclient-php/+/1021394

Change #1021394 had a related patch set uploaded (by Gergő Tisza; author: AManWithNoPlan):

[mediawiki/oauthclient-php@master] This variable is no longer used

https://gerrit.wikimedia.org/r/1021394

gerritbot added a project: Patch-For-Review.Mon, Jul 1, 12:21 PM

Tgr closed this task as Resolved.Mon, Jul 1, 12:28 PM

Tgr assigned this task to AManWithNoPlan.

Change #1021394 merged by jenkins-bot:

[mediawiki/oauthclient-php@master] This variable is no longer used

https://gerrit.wikimedia.org/r/1021394