Deferred update '....UploadCompleteHandler->onUploadComplete' failed to run.
Closed, DeclinedPublicPRODUCTION ERROR
Actions

Description

Error

Logstash single document

message

Deferred update 'MediaWiki\Deferred\MWCallableUpdate_MediaWiki\Extension\MediaModeration\Hooks\Handlers\UploadCompleteHandler->onUploadComplete' failed to run.

exception

Cannot access the database: Connection timed out (db2115)

trace

from /srv/mediawiki/php-1.42.0-wmf.7/includes/libs/rdbms/loadbalancer/LoadBalancer.php(1149)
#0 /srv/mediawiki/php-1.42.0-wmf.7/includes/libs/rdbms/loadbalancer/LoadBalancer.php(805): Wikimedia\Rdbms\LoadBalancer->reportConnectionError()
#1 /srv/mediawiki/php-1.42.0-wmf.7/includes/libs/rdbms/loadbalancer/LoadBalancer.php(793): Wikimedia\Rdbms\LoadBalancer->getServerConnection(integer, string, integer)
#2 /srv/mediawiki/php-1.42.0-wmf.7/includes/libs/rdbms/database/DBConnRef.php(103): Wikimedia\Rdbms\LoadBalancer->getConnectionInternal(integer, array, string, integer)
#3 /srv/mediawiki/php-1.42.0-wmf.7/includes/libs/rdbms/database/DBConnRef.php(117): Wikimedia\Rdbms\DBConnRef->ensureConnection()
#4 /srv/mediawiki/php-1.42.0-wmf.7/includes/libs/rdbms/database/DBConnRef.php(338): Wikimedia\Rdbms\DBConnRef->__call(string, array)
#5 /srv/mediawiki/php-1.42.0-wmf.7/includes/libs/rdbms/querybuilder/SelectQueryBuilder.php(726): Wikimedia\Rdbms\DBConnRef->selectField(array, string, array, string, array, array)
#6 /srv/mediawiki/php-1.42.0-wmf.7/extensions/MediaModeration/src/Services/MediaModerationDatabaseLookup.php(36): Wikimedia\Rdbms\SelectQueryBuilder->fetchField()
#7 /srv/mediawiki/php-1.42.0-wmf.7/extensions/MediaModeration/src/Services/MediaModerationDatabaseManager.php(34): MediaWiki\Extension\MediaModeration\Services\MediaModerationDatabaseLookup->fileExistsInScanTable(LocalFile, integer)
#8 /srv/mediawiki/php-1.42.0-wmf.7/extensions/MediaModeration/src/Services/MediaModerationFileProcessor.php(145): MediaWiki\Extension\MediaModeration\Services\MediaModerationDatabaseManager->insertFileToScanTable(LocalFile)
#9 /srv/mediawiki/php-1.42.0-wmf.7/extensions/MediaModeration/src/Hooks/Handlers/UploadCompleteHandler.php(50): MediaWiki\Extension\MediaModeration\Services\MediaModerationFileProcessor->insertFile(LocalFile)
#10 [internal function]: MediaWiki\Extension\MediaModeration\Hooks\Handlers\UploadCompleteHandler->MediaWiki\Extension\MediaModeration\Hooks\Handlers\{closure}()
#11 /srv/mediawiki/php-1.42.0-wmf.7/includes/deferred/MWCallableUpdate.php(42): call_user_func(Closure)
#12 /srv/mediawiki/php-1.42.0-wmf.7/includes/deferred/DeferredUpdates.php(469): MediaWiki\Deferred\MWCallableUpdate->doUpdate()
#13 /srv/mediawiki/php-1.42.0-wmf.7/includes/deferred/DeferredUpdates.php(198): MediaWiki\Deferred\DeferredUpdates::attemptUpdate(MediaWiki\Deferred\MWCallableUpdate)
#14 /srv/mediawiki/php-1.42.0-wmf.7/includes/deferred/DeferredUpdates.php(282): MediaWiki\Deferred\DeferredUpdates::run(MediaWiki\Deferred\MWCallableUpdate)
#15 /srv/mediawiki/php-1.42.0-wmf.7/includes/deferred/DeferredUpdatesScope.php(269): MediaWiki\Deferred\DeferredUpdates::MediaWiki\Deferred\{closure}(MediaWiki\Deferred\MWCallableUpdate, integer)
#16 /srv/mediawiki/php-1.42.0-wmf.7/includes/deferred/DeferredUpdatesScope.php(198): MediaWiki\Deferred\DeferredUpdatesScope->processStageQueue(integer, integer, Closure)
#17 /srv/mediawiki/php-1.42.0-wmf.7/includes/deferred/DeferredUpdates.php(301): MediaWiki\Deferred\DeferredUpdatesScope->processUpdates(integer, Closure)
#18 /srv/mediawiki/php-1.42.0-wmf.7/includes/MediaWiki.php(1170): MediaWiki\Deferred\DeferredUpdates::doUpdates()
#19 /srv/mediawiki/php-1.42.0-wmf.7/includes/MediaWiki.php(888): MediaWiki->restInPeace()
#20 /srv/mediawiki/php-1.42.0-wmf.7/api.php(130): MediaWiki->doPostOutputShutdown()
#21 /srv/mediawiki/php-1.42.0-wmf.7/api.php(48): wfApiMain()
#22 /srv/mediawiki/w/api.php(3): require(string)
#23 {main}

Impact

Means that the image is not stored in the mediamoderation_scan table.

Related Objects
Search...

Status	Subtype	Assigned	Task
Open		None	T351200 [EPIC] Start automated scanning
Open		None	T351400 Run the maintenance script scanning images in mediamoderation_scan on WMF wikis
Resolved		kostajh	T351544 [Sub EPIC] Start test wiki scan
Resolved		None	T351546 [Sub EPIC] Set up rows
Declined	PRODUCTION ERROR	None	T353391 Deferred update '....UploadCompleteHandler->onUploadComplete' failed to run.
Open		None	T353442 Update MediaModerationPhotoDNAServiceProvider::getThumbnailForFile to choose a thumbnail that meets minimum height requirements for PhotoDNA API
Resolved	BUG REPORT	Dreamy_Jazz	T353758 MediaModerationPhotoDNAServiceProvider provides false to FileBackend::getFileContents causing a PHP Notice
Resolved		Dreamy_Jazz	T351399 Create a maintenance script to automatically scan files listed in mediamoderation_scan
Resolved		kostajh	T351401 Create service(s) to send an image to PhotoDNA for a scan
Resolved		Dreamy_Jazz	T351407 Create a service that sends an email when a file matches
Resolved		Dreamy_Jazz	T351417 Create a service that creates LocalFile and ArchivedFile objects for files that have a given SHA-1
Resolved		Dreamy_Jazz	T351416 [S] Explore how many rows in the file tables have duplicated SHA-1 values on WMF wikis
Resolved		Dreamy_Jazz	T351409 Expand the database lookup service to get rows from the mediamoderation_scan table
Resolved		Dreamy_Jazz	T351112 [S] Create an initial service to lookup scan rows from the database
Resolved		Dreamy_Jazz	T350321 [M] Create database table to store status of scans

Event Timeline

Dreamy_Jazz created this task.Dec 13 2023, 10:22 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 13 2023, 10:22 PM

Dreamy_Jazz updated the task description. (Show Details)Dec 13 2023, 10:22 PM

Dreamy_Jazz updated the task description. (Show Details)

Dreamy_Jazz added a parent task: T351546: [Sub EPIC] Set up rows .Dec 13 2023, 10:24 PM

This is happening infrequently enough that I think we can ignore it and decline this task. As part of the automation work, we can make sure that we handle backfilling rows in mediamoderation_scan if/when the DB connection is lost at file upload time.

In T353391#9409092, @kostajh wrote:

This is happening infrequently enough that I think we can ignore it and decline this task. As part of the automation work, we can make sure that we handle backfilling rows in mediamoderation_scan if/when the DB connection is lost at file upload time.

If we decline this task, I suggest that we create a task to track running the import maintenance script automatically to account for this?

Otherwise we risk forgetting about this later down the line.

Closing as declined in favour of T354372.

Dreamy_Jazz mentioned this in T356071: TypeError from MediaModeration UploadCompleteHandler.Jan 29 2024, 6:34 PM

Deferred update '....UploadCompleteHandler->onUploadComplete' failed to run.Closed, DeclinedPublicPRODUCTION ERRORActions