Page MenuHomePhabricator
Create Task
Maniphest T353563

[toolforge-cd] remove duplicated run on tag and push to master (just do one if possible)
Closed, ResolvedPublicBUG REPORT
Actions

Description

It seems like we are running two gitlab ci/cd pipelines after a patch is merged and this seems to have been going on for sometime now.
For example after patch !51 was merged 1 month ago pipeline 31240 was executed (this is the expected pipeline). But then after the first pipeline executed after merge there is a second pipeline 31242 and this pipeline only ran pre-commit and blubber-test (which was already done in the last ci/cd pipeline).

This is probably a bug but in case it is not, can someone who know about it comment?

Details

TitleReferenceAuthorSource BranchDest Branch
[gitlab-cd] add ci rules to pre-commit and blubber-testrepos/cloud/cicd/gitlab-ci!30raymond-ndibeadd_rules_to_pre_commit_and_blubber_testmain
Customize query in GitLab

Related Objects
Search...

Event Timeline

Raymond_Ndibe created this task.Dec 15 2023, 10:46 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 15 2023, 10:46 PM
Raymond_Ndibe changed the task status from Open to In Progress.Dec 15 2023, 10:46 PM
Raymond_Ndibe claimed this task.
Raymond_Ndibe moved this task from Next Up to In Progress on the Toolforge (Toolforge iteration 02) board.
Raymond_Ndibe updated the task description. (Show Details)
Raymond_Ndibe added a parent task: T353514: [toolforge-cd] gitlab-ci refactor.Dec 15 2023, 10:49 PM
Raymond_Ndibe mentioned this in T353740: [toolforge-cd] minimize test repetitions from merge request ci/cd pipelines.Dec 19 2023, 5:54 PM
dcaro edited projects, added Toolforge (Toolforge iteration 03); removed Toolforge (Toolforge iteration 02).Jan 9 2024, 3:28 PM
dcaro moved this task from Next Up to In Progress on the Toolforge (Toolforge iteration 03) board.
dcaro edited projects, added Toolforge (Toolforge iteration 04); removed Toolforge (Toolforge iteration 03).Jan 24 2024, 9:17 AM
dcaro moved this task from Next Up to In Progress on the Toolforge (Toolforge iteration 04) board.
dcaro subscribed.Feb 6 2024, 2:37 PM

The difference is in the trigger, one was triggered by the push to main, and the other by the tag creation (due to the release creation), we can skip the second adding a filter to the tests.

dcaro edited projects, added Toolforge (Toolforge iteration 05); removed Toolforge (Toolforge iteration 04).Feb 6 2024, 5:43 PM
dcaro moved this task from Next Up to In Progress on the Toolforge (Toolforge iteration 05) board.
dcaro triaged this task as Medium priority.Feb 7 2024, 10:12 AM
dcaro edited projects, added Toolforge (Toolforge iteration 06); removed Toolforge (Toolforge iteration 05).Feb 21 2024, 10:10 AM
dcaro moved this task from Next Up to In Progress on the Toolforge (Toolforge iteration 06) board.
dcaro renamed this task from [toolforge-cd] find out why we run two gitlab ci/cd pipelines after merge to [toolforge-cd] remove duplicated run on tag and push to master (just do one if possible).Mar 5 2024, 2:35 PM
dcaro edited projects, added Toolforge (Toolforge iteration 07); removed Toolforge (Toolforge iteration 06).Mar 5 2024, 5:12 PM
dcaro moved this task from Next Up to In Progress on the Toolforge (Toolforge iteration 07) board.
CodeReviewBot added a project: Patch-For-Review.Apr 2 2024, 7:22 PM

raymond-ndibe opened https://gitlab.wikimedia.org/repos/cloud/cicd/gitlab-ci/-/merge_requests/30

[gitlab-cd] add ci rules to pre-commit and blubber-test

Raymond_Ndibe moved this task from In Progress to In Review on the Toolforge (Toolforge iteration 07) board.Apr 2 2024, 7:23 PM
dcaro edited projects, added Toolforge (Toolforge iteration 08); removed Toolforge (Toolforge iteration 07).Apr 3 2024, 4:14 PM
dcaro moved this task from Next Up to In Review on the Toolforge (Toolforge iteration 08) board.
CodeReviewBot added a comment.Apr 9 2024, 8:29 PM

raymond-ndibe merged https://gitlab.wikimedia.org/repos/cloud/cicd/gitlab-ci/-/merge_requests/30

[gitlab-cd] add ci rules to pre-commit and blubber-test

Maintenance_bot removed a project: Patch-For-Review.Apr 9 2024, 8:30 PM
Raymond_Ndibe closed this task as Resolved.Apr 16 2024, 3:00 AM
Raymond_Ndibe moved this task from In Review to Done on the Toolforge (Toolforge iteration 08) board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL