"New comments could not be found. They might have been deleted or moved." always appears when following a bundled notification
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	matmarex
	Dec 16 2023, 2:30 AM

Description

"New comments could not be found. They might have been deleted or moved." always appears when following a bundled notification.

	Subject	Repo	Branch	Lines +/-
	Stop comment-not-found notification always showing when requestedSince	mediawiki/extensions/DiscussionTools	master	+1 -1

I think it's this line:

if ( highlightResult.highlighted.length === 0 && highlightResult.requested.length > 1 || highlightResult.requestedSince ) {

...which is always going to evaluate to true if requestedSince.

I'll write a patch.

Change 983517 had a related patch set uploaded (by DLynch; author: DLynch):

[mediawiki/extensions/DiscussionTools@master] Stop comment-not-found notification always showing when requestedSince

Change 983517 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Stop comment-not-found notification always showing when requestedSince

matmarex added a project: Editing QA.

Ryasmeen edited projects, added Verified; removed Editing QA.

Ryasmeen closed this task as Resolved.Dec 22 2023, 7:52 PM

Ryasmeen claimed this task.