Page MenuHomePhabricator
Create Task
Maniphest T353741

Current JavaScript executor does not support Object.hasOwn
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

What happens?:
We get an error message "Z507K1 bit a function"

What should have happened instead?:
The function should run

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

The problem is that Object.hasOwn, which is here used in line 66, has only been implemented in QuickJS 0.24.0 or later. The issue will go away as soon as we deploye QuickJS 0.24.0.

That was the only place where JavaScript implementations used Object.hasOwn, so this is not urgent. We will just deploy it as the new QickJS version propagates through.

Thanks to Racecard who reported an issue here: https://www.wikifunctions.org/wiki/Talk:Z10944

Related Objects

Event Timeline

DVrandecic created this task.Dec 19 2023, 6:18 PM
DVrandecic mentioned this in T353742: Error message too terse for missing Object.hasOwn.Dec 19 2023, 6:26 PM
Mcastro triaged this task as High priority.Dec 21 2023, 5:35 PM
Mcastro lowered the priority of this task from High to Low.
Mcastro moved this task from To triage to Backlog on the Abstract Wikipedia team board.
Jdforrester-WMF moved this task from Backlog to 24Q4 (Apr–Jun) on the Abstract Wikipedia team board.Apr 1 2024, 6:51 PM
Jdforrester-WMF edited projects, added Abstract Wikipedia team (24Q4 (Apr–Jun)); removed Abstract Wikipedia team.
Jdforrester-WMF moved this task from Incoming to Ready, Bugs on the Abstract Wikipedia team (24Q4 (Apr–Jun)) board.Apr 1 2024, 7:08 PM
cmassaro subscribed.Apr 4 2024, 2:59 PM

Looks like this got merged into wasmedge-quickjs in February: https://github.com/second-state/wasmedge-quickjs/commit/d76ccf4aed0745e4ff7aad2f6aac4caf4acdfca2

And when I try locally, it does seem to work:

root@631fc176bc66:/srv/service# . ./programming-languages/wasmedge/wasmedge-binary/env 
root@631fc176bc66:/srv/service# cat << EOF > script.js
> import * as std from 'std';
> const obj = { a: 1 };
> print(Object.hasOwn(obj, 'a'));
> EOF
root@631fc176bc66:/srv/service# wasmedge --dir .:. ./programming-languages/wasmedge_quickjs_uncompiled.wasm script.js 
true

I'll move this to To Deploy.

cmassaro claimed this task.Apr 4 2024, 2:59 PM
cmassaro moved this task from 24Q4 (Apr–Jun) to To deploy on the Abstract Wikipedia team board.
cmassaro edited projects, added Abstract Wikipedia team; removed Abstract Wikipedia team (24Q4 (Apr–Jun)).
cmassaro moved this task from To deploy to Verify in production on the Abstract Wikipedia team board.Apr 4 2024, 5:55 PM
Jdforrester-WMF closed this task as Resolved.Apr 4 2024, 7:43 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits