Page MenuHomePhabricator

EntitySchema CI broken on master with OutOfMemory error in browser test
Closed, ResolvedPublic

Description

Adding a noop change to the tip of EntitySchema master (Empty change to test CI (Icb8881d4)) currently reproducibly fails in CI for the first browser test:

00:02:28.492   1) Schema Edit Page
00:02:28.492        given that a user is allowed
00:02:28.492          "before each" hook for "returns to schema view page on submit":
00:02:28.492      AssertionError: Timed out retrying after 4000ms: Expected to find element: `input[name=label]`, but never found it.
00:02:28.492 
00:02:28.492 Because this error occurred during a `before each` hook we are skipping the remaining tests in the current suite: `Schema Edit Page`
00:02:28.492       at SpecialNewEntitySchemaPage.enterLabel (webpack://EntitySchema/./cypress/support/pageObjects/SpecialNewEntitySchemaPage.js:8:5)
00:02:28.492       at Context.eval (webpack://EntitySchema/./cypress/e2e/editEntitySchema.cy.js:17:4)

(from the logs)

Subsequent browser tests are green.

The related screenshot shows an out of memory error when trying to open Special:NewEntitySchema:

image.png (720×1 px, 78 KB)

(source of screenshot)

Though, this only seems to occur the very first time the wiki receives a request. Even the dedicated browser tests for the Special:NewEntitySchema page itself are green.

Acceptance criteria:

  • CI for EntitySchema is green on master

Event Timeline

It looks like the memory limit there is 128M. Is there an easy way to see what happens if we just boost memory_limit to 256M?

Change 987396 had a related patch set uploaded (by Arthur taylor; author: Arthur taylor):

[mediawiki/extensions/EntitySchema@master] [DNM] Try adding a fake request to the start of the suite

https://gerrit.wikimedia.org/r/987396

Change 987396 merged by jenkins-bot:

[mediawiki/extensions/EntitySchema@master] Add dispensable start-up request to editEntitySchema tests

https://gerrit.wikimedia.org/r/987396

We've added a workaround for that specific test-suite. I don't consider it a good long-term solution. I would be good to investigate what's causing the OOM - when that first appeared, and what we can do to avoid it. But CI for EntitySchema on Master is green again now.

Did you create a task for that investigation? If not, can you please create one and tag it wmde-wikidata-tech?

Change 1008855 had a related patch set uploaded (by Arthur taylor; author: Arthur taylor):

[mediawiki/extensions/EntitySchema@master] Remove dispensable start-up request introduced as CI workaround

https://gerrit.wikimedia.org/r/1008855

Change #1008855 merged by jenkins-bot:

[mediawiki/extensions/EntitySchema@master] Remove dispensable start-up request introduced as CI workaround

https://gerrit.wikimedia.org/r/1008855