Page MenuHomePhabricator
Create Task
Maniphest T354298

Wikimedia\Assert\PreconditionException: Expected MediaWiki\Block\AbstractBlock to belong to the local wiki, but it belongs to 'xxxwiki'
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error
normalized_message
[{reqId}] {exception_url}   Wikimedia\Assert\PreconditionException: Expected MediaWiki\Block\AbstractBlock to belong to the local wiki, but it belongs to 'enwiki'
exception.trace
from /srv/mediawiki/php-1.42.0-wmf.12/includes/dao/WikiAwareEntityTrait.php(59)
#0 /srv/mediawiki/php-1.42.0-wmf.12/includes/block/AbstractBlock.php(415): MediaWiki\Block\AbstractBlock->assertWiki(boolean)
#1 /srv/mediawiki/php-1.42.0-wmf.12/includes/block/AbstractBlock.php(112): MediaWiki\Block\AbstractBlock->setTarget(string)
#2 /srv/mediawiki/php-1.42.0-wmf.12/includes/block/DatabaseBlock.php(88): MediaWiki\Block\AbstractBlock->__construct(array)
#3 /srv/mediawiki/php-1.42.0-wmf.12/includes/block/DatabaseBlockStore.php(714): MediaWiki\Block\DatabaseBlock->__construct(array)
#4 /srv/mediawiki/php-1.42.0-wmf.12/includes/block/DatabaseBlockStore.php(910): MediaWiki\Block\DatabaseBlockStore->newFromRow(Wikimedia\Rdbms\DBConnRef, stdClass)
#5 /srv/mediawiki/php-1.42.0-wmf.12/extensions/CentralAuth/includes/User/CentralAuthUser.php(2757): MediaWiki\Block\DatabaseBlockStore->newListFromConds(array)
#6 /srv/mediawiki/php-1.42.0-wmf.12/extensions/CentralAuth/includes/User/CentralAuthUser.php(2573): MediaWiki\Extension\CentralAuth\User\CentralAuthUser->localUserData(string)
#7 /srv/mediawiki/php-1.42.0-wmf.12/extensions/CentralAuth/includes/User/CentralAuthUser.php(2542): MediaWiki\Extension\CentralAuth\User\CentralAuthUser->queryAttached()
#8 /srv/mediawiki/php-1.42.0-wmf.12/extensions/CentralAuth/includes/Hooks/Handlers/PasswordPoliciesHookHandler.php(57): MediaWiki\Extension\CentralAuth\User\CentralAuthUser->getLocalGroups()
#9 /srv/mediawiki/php-1.42.0-wmf.12/includes/HookContainer/HookContainer.php(161): MediaWiki\Extension\CentralAuth\Hooks\Handlers\PasswordPoliciesHookHandler->onPasswordPoliciesForUser(MediaWiki\User\User, array)
#10 /srv/mediawiki/php-1.42.0-wmf.12/includes/HookContainer/HookRunner.php(3058): MediaWiki\HookContainer\HookContainer->run(string, array)
#11 /srv/mediawiki/php-1.42.0-wmf.12/includes/password/UserPasswordPolicy.php(192): MediaWiki\HookContainer\HookRunner->onPasswordPoliciesForUser(MediaWiki\User\User, array)
#12 /srv/mediawiki/php-1.42.0-wmf.12/includes/password/UserPasswordPolicy.php(82): UserPasswordPolicy->getPoliciesForUser(MediaWiki\User\User)
#13 /srv/mediawiki/php-1.42.0-wmf.12/includes/user/User.php(982): UserPasswordPolicy->checkUserPassword(MediaWiki\User\User, string)
#14 /srv/mediawiki/php-1.42.0-wmf.12/includes/auth/AbstractPasswordPrimaryAuthenticationProvider.php(112): MediaWiki\User\User->checkPasswordValidity(string)
#15 /srv/mediawiki/php-1.42.0-wmf.12/includes/auth/TemporaryPasswordPrimaryAuthenticationProvider.php(161): MediaWiki\Auth\AbstractPasswordPrimaryAuthenticationProvider->checkPasswordValidity(string, string)
#16 /srv/mediawiki/php-1.42.0-wmf.12/includes/auth/AuthManager.php(559): MediaWiki\Auth\TemporaryPasswordPrimaryAuthenticationProvider->beginPrimaryAuthentication(array)
#17 /srv/mediawiki/php-1.42.0-wmf.12/includes/auth/AuthManager.php(489): MediaWiki\Auth\AuthManager->continueAuthentication(array)
#18 /srv/mediawiki/php-1.42.0-wmf.12/includes/specialpage/AuthManagerSpecialPage.php(387): MediaWiki\Auth\AuthManager->beginAuthentication(array, string)
#19 /srv/mediawiki/php-1.42.0-wmf.12/includes/specialpage/AuthManagerSpecialPage.php(519): MediaWiki\SpecialPage\AuthManagerSpecialPage->performAuthenticationStep(string, array)
#20 /srv/mediawiki/php-1.42.0-wmf.12/includes/htmlform/HTMLForm.php(751): MediaWiki\SpecialPage\AuthManagerSpecialPage->handleFormSubmit(array, CodexHTMLForm)
#21 /srv/mediawiki/php-1.42.0-wmf.12/includes/specialpage/AuthManagerSpecialPage.php(450): HTMLForm->trySubmit()
#22 /srv/mediawiki/php-1.42.0-wmf.12/includes/specialpage/LoginSignupSpecialPage.php(337): MediaWiki\SpecialPage\AuthManagerSpecialPage->trySubmit()
#23 /srv/mediawiki/php-1.42.0-wmf.12/includes/specialpage/SpecialPage.php(727): MediaWiki\SpecialPage\LoginSignupSpecialPage->execute(NULL)
#24 /srv/mediawiki/php-1.42.0-wmf.12/includes/specialpage/SpecialPageFactory.php(1652): MediaWiki\SpecialPage\SpecialPage->run(NULL)
#25 /srv/mediawiki/php-1.42.0-wmf.12/includes/MediaWiki.php(359): MediaWiki\SpecialPage\SpecialPageFactory->executePath(string, RequestContext)
#26 /srv/mediawiki/php-1.42.0-wmf.12/includes/MediaWiki.php(954): MediaWiki->performRequest()
#27 /srv/mediawiki/php-1.42.0-wmf.12/includes/MediaWiki.php(607): MediaWiki->main()
#28 /srv/mediawiki/php-1.42.0-wmf.12/index.php(50): MediaWiki->run()
#29 /srv/mediawiki/php-1.42.0-wmf.12/index.php(46): wfIndexMain()
#30 /srv/mediawiki/w/index.php(3): require(string)
#31 {main}
Notes
  • Similar to T353620 but a different stacktrace
  • Seems to have increased since the rollout of wmf.12
    • 2024-01-03_belong-to-the-local-wiki.png (319×678 px, 16 KB)
  • Mostly happening on k8s hosts (appserver hosts show the stacktrace from T353620)

Details

Request URL
https://www.mediawiki.org/w/index.php?returnto=*&title=*
SubjectRepoBranchLines +/-
Revert "Support new block schema"mediawiki/extensions/CentralAuthmaster+60 -27
Revert "Support new block schema"mediawiki/extensions/CentralAuthwmf/1.42.0-wmf.12+60 -27
Make BlockUtils a wiki-aware servicemediawiki/coremaster+132 -16
Customize query in gerrit

Related Objects
Search...

Event Timeline

thcipriani created this task.Jan 3 2024, 6:04 PM
Restricted Application added a project: MediaWiki-Platform-Team. · View Herald TranscriptJan 3 2024, 6:04 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
• taavi triaged this task as Unbreak Now! priority.Jan 3 2024, 6:04 PM
• taavi added a parent task: T350088: 1.42.0-wmf.12 deployment blockers.

Possible cause: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CentralAuth/+/974718

• taavi added subscribers: tstarling, Zabe.Jan 3 2024, 6:07 PM
gerritbot added a comment.Jan 3 2024, 6:40 PM

Change 987460 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/core@master] Make BlockUtils a wiki-aware service

https://gerrit.wikimedia.org/r/987460

gerritbot added a project: Patch-For-Review.Jan 3 2024, 6:40 PM
gerritbot added a comment.Jan 4 2024, 3:54 AM

Change 987471 had a related patch set uploaded (by Tim Starling; author: Tim Starling):

[mediawiki/extensions/CentralAuth@master] Revert "Support new block schema"

https://gerrit.wikimedia.org/r/987471

tstarling mentioned this in T353620: Wikimedia\Assert\PreconditionException: Expected MediaWiki\Block\AbstractBlock to belong to the local wiki, but it belongs to 'commonswiki'.Jan 4 2024, 4:15 AM
gerritbot added a comment.Jan 4 2024, 5:25 AM

Change 987460 merged by jenkins-bot:

[mediawiki/core@master] Make BlockUtils a wiki-aware service

https://gerrit.wikimedia.org/r/987460

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.13; 2024-01-09 ).Jan 4 2024, 7:00 AM
gerritbot added a comment.Jan 4 2024, 10:37 AM

Change 987482 had a related patch set uploaded (by Zabe; author: Tim Starling):

[mediawiki/extensions/CentralAuth@wmf/1.42.0-wmf.12] Revert "Support new block schema"

https://gerrit.wikimedia.org/r/987482

gerritbot added a comment.Jan 4 2024, 12:56 PM

Change 987482 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@wmf/1.42.0-wmf.12] Revert "Support new block schema"

https://gerrit.wikimedia.org/r/987482

Stashbot added a comment.Jan 4 2024, 12:56 PM

Mentioned in SAL (#wikimedia-operations) [2024-01-04T12:56:52Z] <zabe@deploy2002> Started scap: Backport for [[gerrit:987483|Revert "Get blocks from DatabaseBlockStore instead of doing our own query" (T353620)]], [[gerrit:987482|Revert "Support new block schema" (T354298)]]

Stashbot added a comment.Jan 4 2024, 1:00 PM

Mentioned in SAL (#wikimedia-operations) [2024-01-04T13:00:29Z] <zabe@deploy2002> zabe: Backport for [[gerrit:987483|Revert "Get blocks from DatabaseBlockStore instead of doing our own query" (T353620)]], [[gerrit:987482|Revert "Support new block schema" (T354298)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

ReleaseTaggerBot edited projects, added MW-1.42-notes (1.42.0-wmf.12; 2024-01-02); removed MW-1.42-notes (1.42.0-wmf.13; 2024-01-09 ).Jan 4 2024, 1:00 PM
Stashbot added a comment.Jan 4 2024, 1:07 PM

Mentioned in SAL (#wikimedia-operations) [2024-01-04T13:06:58Z] <zabe@deploy2002> Finished scap: Backport for [[gerrit:987483|Revert "Get blocks from DatabaseBlockStore instead of doing our own query" (T353620)]], [[gerrit:987482|Revert "Support new block schema" (T354298)]] (duration: 10m 06s)

Zabe closed this task as Resolved.Jan 4 2024, 1:07 PM
Zabe claimed this task.
gerritbot added a comment.Jan 4 2024, 1:08 PM

Change 987471 abandoned by Zabe:

[mediawiki/extensions/CentralAuth@master] Revert "Support new block schema"

Reason:

I guess we don't need to merge this into master since https://gerrit.wikimedia.org/r/c/mediawiki/core/+/987460/ has been merged, feel free to restore if that turns out to be wrong.

https://gerrit.wikimedia.org/r/987471

Maintenance_bot removed a project: Patch-For-Review.Jan 4 2024, 1:30 PM
dduvall awarded a token.Jan 4 2024, 6:15 PM
• Urbanecm mentioned this in T358208: Wikimedia\Assert\PreconditionException: Expected MediaWiki\Block\AbstractBlock to belong to the local wiki, but it belongs to 'huwiki'.Feb 22 2024, 11:46 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits