Error when discarding changes with CodeMirror enabled (this.last is null)
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Samwilson
	Jan 4 2024, 5:41 AM

Description

Steps to replicate the issue (include links if applicable):

Start editing a page and make some changes.
Reload it, to trigger the Edit Recovery notification.
Click 'Discard changes'.

What happens?:

The text is reset, but the notification does not close, and the following error is shown in the console:

Uncaught TypeError: this.last is null
    addInner main.js:1
    add main.js:1
    of main.js:1
    set main.js:1
    update main.js:1
    update main.js:1
    applyTransaction main.js:1
    Y main.js:1
    yt main.js:1
    applyTransaction main.js:1
    get state main.js:1
    update main.js:1
    dispatchTransactions main.js:1
    dispatch main.js:1
    setSelection main.js:1
    textSelection jQuery
    loadData edit.js:161
    loadData edit.js:145
    onLoadData edit.js:110
    emit oojs.js:858
    onClick oojs-ui-core.js:2376
    jQuery 9
    setButtonElement oojs-ui-core.js:2316
    OoUiMixinButtonElement oojs-ui-core.js:2258
    OoUiButtonWidget oojs-ui-core.js:3976
    mwWidgetsEditRecoveryLoadNotification LoadNotification.js:11
    onLoadData edit.js:102
    promise callback*onLoadHandler/< edit.js:77
    promise callback*onLoadHandler edit.js:74
    add mediawiki.base.js:519
    js edit.js:17
…

What should have happened instead?:

The text reset, the caret positioned at the top, and the notification closed.

QA Results - Beta

AC	Status	Details
1	✅	https://phabricator.wikimedia.org/T354313 here

Details

	Subject	Repo	Branch	Lines +/-
	Edit Recovery: set caret position when loading form data	mediawiki/core	master	+1 -1

Customize query in gerrit

Related Objects

Mentioned Here: rMWdb5f7689d41b: Localisation updates from https://translatewiki.net.

Event Timeline

Samwilson created this task.Jan 4 2024, 5:41 AM

Restricted Application added a project: Community-Tech. · View Herald TranscriptJan 4 2024, 5:41 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Samwilson claimed this task.Jan 4 2024, 5:41 AM

Samwilson edited projects, added Community-Tech (CommTech-Kanban); removed Community-Tech.

Change 987516 had a related patch set uploaded (by Samwilson; author: Samwilson):

[mediawiki/core@master] Edit Recovery: set caret position when loading form data

https://gerrit.wikimedia.org/r/987516

gerritbot added a project: Patch-For-Review.Jan 4 2024, 5:45 AM

Samwilson moved this task from Ready 🎬 to Review/Feedback 💬 on the Community-Tech (CommTech-Kanban) board.Jan 4 2024, 5:46 AM

HMonroy moved this task from Review/Feedback 💬 to QA 🐛 on the Community-Tech (CommTech-Kanban) board.Jan 8 2024, 7:48 PM

Change 987516 merged by jenkins-bot:

[mediawiki/core@master] Edit Recovery: set caret position when loading form data

https://gerrit.wikimedia.org/r/987516

Maintenance_bot removed a project: Patch-For-Review.Jan 9 2024, 11:30 AM

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.14; 2024-01-16).Jan 9 2024, 12:00 PM

@Samwilson When I click Discard changes, there is no error and the notification closes as seen below. This will be moved to Done. Thanks for all your work!

Status: ✅PASS
Environment: Beta: 1.42.0-alpha (db5f768))
OS: macOS Sonoma 14.2.1
Browser: Chrome 120, Firefox 120, Safari 17.2, Edge 120
Skins. Vector 2022, 2010, Minerva, Monobook, Timeless
Device: MBA M2
Emulated Device:: n/a
Test Links:
https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Dog&action=edit