Page MenuHomePhabricator

mobilediff coloring does not match the header definitions
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

What happens?:

  • Notice that the coloring of the add/remove sections (red and green) do not match the coloring of them in header of the section (blue and yellow)

What should have happened instead?:

  • The coloring of the legend should match the coloring of the layout

Software version (skip for WMF-hosted wikis like Wikipedia):
WMF Production

Other information (browser name/version, screenshots, etc.):

image.png (704×770 px, 50 KB)

Event Timeline

Jdlrobson changed the task status from Open to Stalled.Jan 11 2024, 8:42 PM
Jdlrobson removed a project: MobileFrontend.
Jdlrobson subscribed.

This page is in tbe process of being removed (T350181) so probably not worth a short term fix.

Jdlrobson triaged this task as Medium priority.Jan 12 2024, 5:11 PM

We're just waiting on a fix for T353479 and then we'll begin removal of the MobileDiff page.

Jdlrobson lowered the priority of this task from Medium to Low.Jan 30 2024, 9:29 PM

Now fixed for logged in users.

Is this "fixed" as in "fixed but not deployed"? Because it is not fixed in production

To clarify: if you follow a link to diffs on mobile and are logged in you will be taken to the new diff page e.g. https://en.m.wikipedia.org/w/index.php?title=Angel_Aquino&diff=1204737636&oldid=1204731233&title=Angel_Aquino&diffonly=1 where this issue is not applicable.

If you navigate directly to the MobileDiff page or to a diff page as an anonymous user (which takes you there) it will still be broken.

To fix this the goal is to remove the page altogether (currently planned for next week or week after).

Jdlrobson claimed this task.

All users should be getting the desktop diff page now (unless they follow a direct link to Special:MobileDiff). The MobileDiff will be redirect to the diff page once T358293 is completed.