mobilediff coloring does not match the header definitions
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Xaosflux
	Jan 11 2024, 10:48 AM

Description

Steps to replicate the issue (include links if applicable):

Go a mobile diff output (e.g. https://test.wikipedia.org/w/index.php?title=Special:MobileDiff/586059 ) where content has been added and removed

What happens?:

Notice that the coloring of the add/remove sections (red and green) do not match the coloring of them in header of the section (blue and yellow)

What should have happened instead?:

The coloring of the legend should match the coloring of the layout

Software version (skip for WMF-hosted wikis like Wikipedia):
WMF Production

Other information (browser name/version, screenshots, etc.):

Related Objects

Mentioned Here: T358293: Decommision the Special:MobileDiff page
T350181: Enable desktop diff page on mobile site
T90948: Identify the best diff style (mobile or desktop) and use it on both mobile and desktop
T353479: Diff legend does not display in mobile HTML

Event Timeline

Xaosflux created this task.Jan 11 2024, 10:48 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 11 2024, 10:48 AM

Xaosflux updated the task description. (Show Details)Jan 11 2024, 10:50 AM

Possible relationship to T353479 ?

Xaosflux updated the task description. (Show Details)Jan 11 2024, 3:02 PM

Xaosflux added a subscriber: DMacks.Jan 11 2024, 4:03 PM

This page is in tbe process of being removed (T350181) so probably not worth a short term fix.

Jdlrobson added a project: MobileFrontend (MobileFrontend Special Pages).Jan 11 2024, 8:43 PM

Jdlrobson moved this task from Backlog to Diffs on the MobileFrontend (MobileFrontend Special Pages) board.

Jdlrobson triaged this task as Medium priority.Jan 12 2024, 5:11 PM

We're just waiting on a fix for T353479 and then we'll begin removal of the MobileDiff page.

Jdlrobson lowered the priority of this task from Medium to Low.Jan 30 2024, 9:29 PM

Now fixed for logged in users.

Is this "fixed" as in "fixed but not deployed"? Because it is not fixed in production

To clarify: if you follow a link to diffs on mobile and are logged in you will be taken to the new diff page e.g. https://en.m.wikipedia.org/w/index.php?title=Angel_Aquino&diff=1204737636&oldid=1204731233&title=Angel_Aquino&diffonly=1 where this issue is not applicable.

If you navigate directly to the MobileDiff page or to a diff page as an anonymous user (which takes you there) it will still be broken.

To fix this the goal is to remove the page altogether (currently planned for next week or week after).

All users should be getting the desktop diff page now (unless they follow a direct link to Special:MobileDiff). The MobileDiff will be redirect to the diff page once T358293 is completed.

mobilediff coloring does not match the header definitionsClosed, ResolvedPublicBUG REPORTActions

Description

Related Objects

Event Timeline

mobilediff coloring does not match the header definitions
Closed, ResolvedPublicBUG REPORT
Actions