Besides the colors, I just wish that we had never added those absolutely hideous-looking, space-wasting, rounded boxes around each single line of text in the diffs. Can we take this opportunity to do away with them?

If we are talking about ‘cultural’ considerations, one point that needs to be made is that it seems good that both additions and removals are marked with neutral and distinct colours that do not read as ‘X is bad, Y is good’. This is why so many different open source communities go away from the standard green-red colour scheme, to show that the additions and removals should not be treated as a win-lose situation. In that area, Wikimedia community probably did better by removing the old diff styling.

If we are talking about colour blindness issues, then it should be, as TheDJ pointed out, decided on whether inline diffs are legible and distinct to colour blind users. If they are not, then it should’ve been brought to standard, already decided colour scheme that is used on desktop. I, personally, don’t have colour blindness of any kind as far as I am aware, but I’ve tried to use diff colours from the mobile version on desktop some time ago (thought they looked ‘better’ at first glance) and after some time I’ve removed it because the diffs become really unreadable with very bright styling that mobile colours have.

In T90948#1100021, @TheDJ wrote:

[...] (It is the only working filter I could find, most online filters seem to have broken lately). [...]

Sidenote that I've updated the list of tools at w:WP:Color. Specific highlights are https://www.toptal.com/designers/colorfilter for webpage analysis or http://www.color-blindness.com/coblis-color-blindness-simulator/ for file analysis. Also these 2 browser-extensions: Colorblinding (chrome) NoCoffee (chrome) NoCoffee (firefox).

In T90948#4143886, @stjn wrote:

If we are talking about colour blindness issues, then it should be, as TheDJ pointed out, decided on whether inline diffs are legible and distinct to colour blind users.

Yes, all the existing official variations are accessible to people with almost all forms of color blindness. (with the very edge-case exception of people with achromatopsia, but that's one of the rarer forms and is generally accompanied by other severe vision impairments). The only slightly concerning color selection at the moment are the navpopups gadget diff colors.

In T90948#4143886, @stjn wrote:

If we are talking about ‘cultural’ considerations [...]

As mentioned above, yellow/blue can be unintuitive for inline diffs. E.g. this diff, when seen with WikEdDiff inline viewer, it is unclear whether the link is being added or removed.

However, inline diffs are better at displaying other things. E.g. paragraph breaks.

AFAICT, this task's actual goal is to decide on:
(1) which colors to use for the 2-column and the 1-column (inline) diffs, and
(2) whether they need to be the same colors as each other, and
(3) whether they should be any of the existing color variations.

To which my personal opinion/answers are:
(1) unclear,
(2) not necessarily, and
(3) possibly. :D
[As with much of life, if the answer seems simple/obvious, then we're probably not looking closely enough or have an ulterior motive!]

However, I lean towards:
(1) WikEdDiff's particular shades of yellow/blue for 2-column diffs, and a lighter variant of the red/green for 1-column diffs,
(2) no, and
(3) maybe, but we need a thorough overview of the existing variants first.
All of which is complicated by the fact that every diff-color variant is attached to a different diff-parser or visualization method, which completely influences the feedback anyone will give.
E.g. (clockwise) WikEdDiff, vector, navpopups, mobile (and there are more!):

I imagine we will continue trying new things (such as the use of strikethrough which navpopups has done for years) and user-testing those variations and doing further external research, for at least a few more years.
I do hope we tweak the mobile diff colors to be slightly more subtle in the meantime, but I don't think they need to be consistent immediately. Ditto (in reverse) for navpopups. But none of it is urgently worth arguing over. HTH!

In T90948#4145063, @Quiddity wrote:

Yes, all the existing official variations are accessible to people with almost all forms of color blindness. (with the very edge-case exception of people with achromatopsia, but that's one of the rarer forms and is generally accompanied by other severe vision impairments). The only slightly concerning color selection at the moment are the navpopups gadget diff colors.

Accessible as in ‘pass WCAG 2.0’ or ‘look distinct and intelligble’? I’ve tested a diff page with Colour Filter and at least with deuteranopia the colours are awfully similar to be distinct enough. They are distinct in desktop diffs, however.

In T90948#4145063, @Quiddity wrote:

As mentioned above, yellow/blue can be unintuitive for inline diffs. E.g. this diff, when seen with WikEdDiff inline viewer, it is unclear whether the link is being added or removed.

That’s more of a downside of reliance on colour, not of colours themselves. This is a major accessibility problem − but it should be solved by having other visual signifiers in inline diffs, such as icons (+/−), a legend somewhere on the page or text decoration (strikethrough for deleted fragments, for example). The problem with them won’t be solved with just changing it back to green-red (or blue-orange, in the other direction).

Good points overall.

I checked in with @alexhollender around this and he suggested the editing team would n eed to be involved in this change.

Seems there are too many considerations for us to do this right now as part of tech-debt.

Change 892990 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/MobileFrontend@master] Mobile diff: Change colours to the same accessible ones as desktop

https://gerrit.wikimedia.org/r/892990

Note from diff coordination meeting: With additional visual markers like +/- diffs don’t necessarily need to have strict contrast compliance on diffing colors!

…if those are applied consistently in inline settings as well, yes

Hi. I was forwarded here from another task :). I did a colour change for myself as I had problems remembering on mobile which colour is which. Changing to red-green helped with that.

Note that aside from colours I'm also using a strike-through line.

two columns	inline

This is the CSS that achieves above:

/**
	Two columns.
*/
.diff-addedline
{
	border-color: rgba(0,175,137,0.6) !important;
	background-color: rgba(0,175,137,0.01) !important;
	.diffchange
	{
		background: color-mix(in srgb, rgba(0,175,137) 35%, white);
	}
}
.diff-deletedline
{
	border-color: rgba(209,29,19,0.7) !important;
	background-color: rgba(209,29,19,0.005) !important;
	.diffchange
	{
		background: color-mix(in srgb, rgba(209,29,19) 15%, white);
		text-decoration: rgba(200,0,0,0.4) line-through;
	}
}
/**
	Inline (aka single column).
*/
:is(.mw-diff-inline-deleted, .mw-diff-inline-changed, .mw-diff-inline-moved) del
{
	background: color-mix(in srgb, rgba(209,29,19) 15%, white);
	text-decoration: rgba(200,0,0,0.4) line-through;
}
:is(.mw-diff-inline-added, .mw-diff-inline-changed, .mw-diff-inline-moved) ins
{
	background: color-mix(in srgb, rgba(0,175,137) 50%, white);
	outline: 1px solid rgba(0,175,137,0.6);
	outline-offset: -2px;
}
.mw-diff-table-prefix .mw-diff-inline-legend .mw-diff-inline-legend-ins
{
	background: color-mix(in srgb, rgba(0,175,137) 50%, white);
}
.mw-diff-table-prefix .mw-diff-inline-legend .mw-diff-inline-legend-del
{
	background: color-mix(in srgb, rgba(209,29,19) 15%, white);
	text-decoration: rgba(200,0,0,0.4) line-through;
}

Note that color-mix can be done in Sass/Less to get better browser support.

Change #892990 abandoned by Jdlrobson:

[mediawiki/extensions/MobileFrontend@master] Mobile diff: Change colours to the same accessible ones as desktop

Reason:

Special:MobileDiff no longer exists so I believe this can be safely abandoned!

https://gerrit.wikimedia.org/r/892990