Page MenuHomePhabricator

Visual diff shows legend and uses inconsistent and inaccessible colors to other diffs
Open, Needs TriagePublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

What happens?:

  • On Vector 2022 and Monobook skins I see a flash of the legend in the top left corner before it disappears.
  • In Minerva the diff legend never disappears

What should have happened instead?:

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Event Timeline

Added community tech based on contributions to https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/core/+blame/d96f37b412921956f9c96e255c1cea6694643658/resources/src/mediawiki.diff/inlineFormatToggle.js

For some reason the ID mw-diffPage-inline-toggle-switch-layout is added to all skins except Minerva...?

@Jdlrobson Is the diff legend the "yellow and blue" boxes that explain what the diffs are? If so, I didn't see that when I tried to open Vector22 or Monobook. Are you still able to reproduce?

Yes. You may need to slow down your internet connection:

legend.gif (694×1 px, 353 KB)

Note it is only present for less than a second in this screenshot as the page loads.

Jdlrobson renamed this task from Visual diff shows legend and uses inconsistent colors to other diffs to Visual diff shows legend and uses inconsistent and inaccessible colors to other diffs.Thu, Jun 13, 4:03 PM
Jdlrobson updated the task description. (Show Details)