Page MenuHomePhabricator

Diffs on recent changes RSS/Atom feeds should have the same formatting of the on wiki diffs
Open, NormalPublic

Details

Reference
bz34798

Event Timeline

bzimport raised the priority of this task from to Normal.Nov 22 2014, 12:11 AM
bzimport set Reference to bz34798.
bzimport added a subscriber: Unknown Object (MLST).
He7d3r created this task.Feb 29 2012, 4:50 PM

While you are at it, see also bug 34800 and bug 34801.

Let's clean this up for release, but this shouldn't be a deployment blocker.

updating milestones

sumanah wrote:

mybugs, thanks for the hints on how to fix this! Added to https://www.mediawiki.org/wiki/Annoying_little_bugs#Defects_to_fix .

Patch in gerrit: Icbfb6cfc by Rahul21.

Patch merged.

As you can check using [[User:Lupin/Anti-vandal tool]], the style of the some elements is still different from what they should be, because applyDiffStyle doesn't copy the styles of nested selectors such as
td.diff-addedline .diffchange,
td.diff-deletedline .diffchange {

border-radius: 0.33em;
padding: 0.25em 0;

}

td.diff-addedline .diffchange {

background: #d8ecff;

}

td.diff-deletedline .diffchange {

background: #feeec8;

}
which are defined at
https://git.wikimedia.org/blob/mediawiki%2Fcore.git/HEAD/resources%2Fmediawiki.action%2Fmediawiki.action.history.diff.css

See also [[User_talk:Lupin/Anti-vandal_tool#Red_coloring_in_diff_display]]

He7d3r renamed this task from Diffs on recent changes feed should have the same formatting of the on wiki diffs to Diffs on recent changes RSS/Atom feeds should have the same formatting of the on wiki diffs.Mar 12 2015, 1:38 PM
He7d3r updated the task description. (Show Details)
He7d3r added a project: UI-Standardization.
He7d3r set Security to None.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 7 2016, 9:03 PM