Page MenuHomePhabricator
Create Task
Maniphest T354950

Stop showing create an account message on Item and property editing UI for Wikibase instances that have temporary accounts enabled
Closed, ResolvedPublic
Actions

Description

Problem:
We are showing warnings when edits are made on Items or Properties and the user isn't logged in. This warning promps them to create an account or log in. With IP Masking this will no longer be required as we will be defering to a media wiki status bar: https://phabricator.wikimedia.org/T330510

This should apply for all edits to Items or Properties.

Example:

image.png (134×325 px, 11 KB)

When editing: https://wikidata.beta.wmflabs.org/wiki/Q620312 this warning box appears.

This warning box and message on a Item or Property page should be removed when editing an Item or Property and IP masking is enabled and the user isn't logged in.

But the warning should remain as is on wikis that don't have IP masking enabled e.g. 3rd party Wikibases

BDD
GIVEN an Item or Property
AND a user who isn't logged in
WHEN making an edit
AND IP Masking is enabled
THEN do not show the create an account prompt

Acceptance criteria:

  • Create an account prompt isn't shown when editing Item or Property when IP Masking is enabled

Details

SubjectRepoBranchLines +/-
Remove anonymous edit pop-up warning for TempUsersmediawiki/extensions/Wikibasemaster+2 -5
Customize query in gerrit

Related Objects
Search...

Event Timeline

Arian_Bozorg created this task.Jan 12 2024, 2:59 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 12 2024, 2:59 PM
Arian_Bozorg attached a referenced file: F41537830: image.png. (Show Details)Jan 12 2024, 2:59 PM
Arian_Bozorg added a parent task: T354951: Stop showing create an account message on editing UI for Wikibase instances that have temporary accounts enabled.Jan 12 2024, 3:05 PM
• karapayneWMDE moved this task from Incoming to Product Backlog on the Wikidata Dev Team board.Jan 16 2024, 3:15 PM
Arian_Bozorg renamed this task from Stop showing IP warning on Item and property editing UI for Wikibase instances that have temporary accounts enabled to Stop showing create an account message on Item and property editing UI for Wikibase instances that have temporary accounts enabled.Jan 17 2024, 11:47 AM
Arian_Bozorg updated the task description. (Show Details)
Arian_Bozorg moved this task from Product Backlog to Unified DOT Backlog on the Wikidata Dev Team board.Jan 17 2024, 11:54 AM
Lucas_Werkmeister_WMDE subscribed.EditedJan 22 2024, 11:31 AM

With IP Masking this will no longer be required as we will be defering to a media wiki status bar: https://phabricator.wikimedia.org/T330510

But this status bar is only implemented in Vector 2022 and Minerva, apparently (and T339377 doesn’t sound like this will soon change either), whereas anonymous users on Wikidata still get the old Vector skin.

ArthurTaylor subscribed.Jan 23 2024, 12:55 PM

@Arian_Bozorg What should we do here? Will Temporary Users also get the Vector skin? Should we keep the warning there for now?

ArthurTaylor mentioned this in T351973: Stop showing create an account message on Lexeme editing UI for Wikibase instances that have temporary accounts enabled.Jan 23 2024, 12:57 PM
ArthurTaylor mentioned this in T351974: Stop showing create an account message on EntitySchema editing UI for Wikibase instances that have temporary accounts enabled.
Arian_Bozorg added a comment.Jan 23 2024, 10:13 PM

Thanks for picking up on that Lucas. With Wikimedia products moving over to Vector 2022, Wikidata will probably make that transition this year as well. This would mean there would be only a small window of time between the temporary accounts and the move to Vector 2022.

So in this case with the login / sign-up warning, let's continue with the three tickets (this one, T351974 and T351973) and remove them for Wikibase instances that have temporary accounts enabled.

ArthurTaylor claimed this task.Jan 24 2024, 11:40 AM
ArthurTaylor edited projects, added Wikidata Dev Team (Wikidata.org Slice); removed Wikidata Dev Team.
ArthurTaylor moved this task from In Task Breakdown to In Development on the Wikidata Dev Team (Wikidata.org Slice) board.
gerritbot added a comment.Jan 26 2024, 7:59 AM

Change 993057 had a related patch set uploaded (by Arthur taylor; author: Arthur taylor):

[mediawiki/extensions/Wikibase@master] Remove anonymous edit pop-up warning for TempUsers

https://gerrit.wikimedia.org/r/993057

gerritbot added a project: Patch-For-Review.Jan 26 2024, 7:59 AM
ArthurTaylor moved this task from In Development to Ready for Peer Review on the Wikidata Dev Team (Wikidata.org Slice) board.Jan 26 2024, 8:33 AM
ArthurTaylor removed ArthurTaylor as the assignee of this task.Jan 26 2024, 11:07 AM
ArthurTaylor moved this task from Ready for Peer Review to Product Verification on the Wikidata Dev Team (Wikidata.org Slice) board.
gerritbot added a comment.Jan 26 2024, 11:21 AM

Change 993057 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Remove anonymous edit pop-up warning for TempUsers

https://gerrit.wikimedia.org/r/993057

Maintenance_bot removed a project: Patch-For-Review.Jan 26 2024, 11:30 AM
Arian_Bozorg closed this task as Resolved.Jan 29 2024, 7:01 AM
Arian_Bozorg claimed this task.
Arian_Bozorg moved this task from Product Verification to Done on the Wikidata Dev Team (Wikidata.org Slice) board.

Thanks so much! Looks good to me :)

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL