⚓ T355309 Don't use RENDER_NOW when generating thumbnails for PhotoDNA scans

	Subject	Repo	Branch	Lines +/-
	Remove RENDER_NOW from File::transform call to avoid job thumbnailing	mediawiki/extensions/MediaModeration	wmf/1.42.0-wmf.14	+1 -1
	Remove RENDER_NOW from File::transform call to avoid job thumbnailing	mediawiki/extensions/MediaModeration	master	+1 -1

Status	Assigned	Task
Stalled	None	T255792 Quibble runs core:unit tests twice!
Open	None	T328919 Upgrade to PHPUnit 10
Open	None	T338103 Micro-optimize ApiResult::isMetadataKey with str_starts_with once we support PHP8+
Open	None	T328921 Drop PHP 7.4 support from MediaWiki
Stalled	None	T334726 Use return type `never` in Wikibase
Open	None	T328922 Drop PHP 8.0 support from MediaWiki
Stalled	None	T319055 Upgrade to psr/container 2.x
Stalled	Krinkle	T319432 Migrate WMF production from PHP 7.4 to PHP 8.1
Open	None	T291916 Tracking task for Bullseye migrations in production
Stalled	None	T356293 Migrate MW appservers' base images to bullseye
Open	None	T290536 Serve production traffic via Kubernetes
Resolved	hnowlan	T349796 Move MediaWiki jobs to mw-on-k8s
Open	None	T260504 Get rid of remaining non-Thumbor MediaWiki image scaling in WMF production
Resolved	None	T355243 MediaModeration maintenance script scanFilesInScanTable.php indirectly calls $wgImageMagickConvertCommand
Resolved	Dreamy_Jazz	T355309 Don't use RENDER_NOW when generating thumbnails for PhotoDNA scans

Dreamy_Jazz created this task.Jan 18 2024, 11:53 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 18 2024, 11:53 AM

Dreamy_Jazz added a parent task: T355243: MediaModeration maintenance script scanFilesInScanTable.php indirectly calls $wgImageMagickConvertCommand.Jan 18 2024, 11:54 AM

Change 991545 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/MediaModeration@master] Remove RENDER_NOW from File::transform call to avoid job thumbnailing

https://gerrit.wikimedia.org/r/991545

gerritbot added a project: Patch-For-Review.Jan 18 2024, 11:54 AM

Change 991551 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/MediaModeration@wmf/1.42.0-wmf.14] Remove RENDER_NOW from File::transform call to avoid job thumbnailing

https://gerrit.wikimedia.org/r/991551

Change 991545 merged by jenkins-bot:

[mediawiki/extensions/MediaModeration@master] Remove RENDER_NOW from File::transform call to avoid job thumbnailing

https://gerrit.wikimedia.org/r/991545

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.15; 2024-01-23).Jan 18 2024, 1:00 PM

Dreamy_Jazz moved this task from Priority Backlog to Needs review on the Trust and Safety Product Sprint (Sprint Northumbrian smallpipes (8th Jan.‘24 - 19th Jan.'24)) board.Jan 18 2024, 1:50 PM

Dreamy_Jazz set the point value for this task to 1.

Dreamy_Jazz moved this task from Needs review to Needs QA on the Trust and Safety Product Sprint (Sprint Northumbrian smallpipes (8th Jan.‘24 - 19th Jan.'24)) board.

Dreamy_Jazz moved this task from Needs QA to Needs review on the Trust and Safety Product Sprint (Sprint Northumbrian smallpipes (8th Jan.‘24 - 19th Jan.'24)) board.

Change 991551 merged by jenkins-bot:

[mediawiki/extensions/MediaModeration@wmf/1.42.0-wmf.14] Remove RENDER_NOW from File::transform call to avoid job thumbnailing

https://gerrit.wikimedia.org/r/991551

Mentioned in SAL (#wikimedia-operations) [2024-01-18T14:03:58Z] <dreamyjazz@deploy2002> Started scap: Backport for [[gerrit:991551|Remove RENDER_NOW from File::transform call to avoid job thumbnailing (T355309)]]

Mentioned in SAL (#wikimedia-operations) [2024-01-18T14:05:15Z] <dreamyjazz@deploy2002> dreamyjazz: Backport for [[gerrit:991551|Remove RENDER_NOW from File::transform call to avoid job thumbnailing (T355309)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-01-18T14:11:48Z] <dreamyjazz@deploy2002> Finished scap: Backport for [[gerrit:991551|Remove RENDER_NOW from File::transform call to avoid job thumbnailing (T355309)]] (duration: 07m 50s)

Maintenance_bot removed a project: Patch-For-Review.Jan 18 2024, 2:30 PM

QA for this is difficult on a local wiki and requires access to production logstash. I would suggest therefore that QA be skipped, as I have been able to verify that the issue at hand was fixed.

Dreamy_Jazz mentioned this in T355177: Error creating thumbnail: mkdir: cannot create directory '/sys/fs/cgroup/memory/mediawiki/job/XXXXX':.Jan 18 2024, 2:51 PM

Dreamy_Jazz mentioned this in T355243: MediaModeration maintenance script scanFilesInScanTable.php indirectly calls $wgImageMagickConvertCommand.Jan 18 2024, 2:54 PM

ReleaseTaggerBot edited projects, added MW-1.42-notes (1.42.0-wmf.14; 2024-01-16); removed MW-1.42-notes (1.42.0-wmf.15; 2024-01-23).Jan 18 2024, 3:00 PM