Running the scanning script with the job queue option enabled has caused thumbnail generation to fail when the file has to be transformed. This is because the MediaWiki k8s containers are configured to not allow the thumbnail generation to occur. This caused a large chunk of errors, and so we need to remove the RENDER_NOW flag to prevent rendering the thumbnail in the job.
Description
Description
Details
Details
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| In Progress | None | T290536 Serve production traffic via Kubernetes | |||
| Resolved | hnowlan | T349796 Move MediaWiki jobs to mw-on-k8s | |||
| Open | None | T260504 Get rid of remaining non-Thumbor MediaWiki image scaling in WMF production | |||
| Resolved | None | T355243 MediaModeration maintenance script scanFilesInScanTable.php indirectly calls $wgImageMagickConvertCommand | |||
| Resolved | Dreamy_Jazz | T355309 Don't use RENDER_NOW when generating thumbnails for PhotoDNA scans |
Event Timeline
Comment Actions
Change 991545 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):
[mediawiki/extensions/MediaModeration@master] Remove RENDER_NOW from File::transform call to avoid job thumbnailing
Comment Actions
Change 991551 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):
[mediawiki/extensions/MediaModeration@wmf/1.42.0-wmf.14] Remove RENDER_NOW from File::transform call to avoid job thumbnailing
Comment Actions
Change 991545 merged by jenkins-bot:
[mediawiki/extensions/MediaModeration@master] Remove RENDER_NOW from File::transform call to avoid job thumbnailing
Comment Actions
Change 991551 merged by jenkins-bot:
[mediawiki/extensions/MediaModeration@wmf/1.42.0-wmf.14] Remove RENDER_NOW from File::transform call to avoid job thumbnailing
Comment Actions
Mentioned in SAL (#wikimedia-operations) [2024-01-18T14:03:58Z] <dreamyjazz@deploy2002> Started scap: Backport for [[gerrit:991551|Remove RENDER_NOW from File::transform call to avoid job thumbnailing (T355309)]]
Comment Actions
Mentioned in SAL (#wikimedia-operations) [2024-01-18T14:05:15Z] <dreamyjazz@deploy2002> dreamyjazz: Backport for [[gerrit:991551|Remove RENDER_NOW from File::transform call to avoid job thumbnailing (T355309)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)
Comment Actions
Mentioned in SAL (#wikimedia-operations) [2024-01-18T14:11:48Z] <dreamyjazz@deploy2002> Finished scap: Backport for [[gerrit:991551|Remove RENDER_NOW from File::transform call to avoid job thumbnailing (T355309)]] (duration: 07m 50s)
Comment Actions
QA for this is difficult on a local wiki and requires access to production logstash. I would suggest therefore that QA be skipped, as I have been able to verify that the issue at hand was fixed.
Comment Actions
I concur with Dreamy_Jazz's comment regarding QA so therefore I'm pushing this ticket to Done.