Page MenuHomePhabricator

Convert TimedMediaHandler to use BoxedCommand/Shellbox
Closed, ResolvedPublic

Description

We need to transform the shellouts in TimedMediaHandler to use BoxedCommand and shellbox and thus make it possible to execute shellouts remotely, solving some of the problems in porting videoscalers to k8s.

After analyzing the code, there's two major places where shellouts happen:

  • TimedMediaThumbnail::get, but this function is in practice never called in production as we delegate thumbnailing for videos as well to thumbor
  • WebVideoTranscodeJob, where we run both fluidsynth and ffmpeg to convert video/audio files, that will need to be converted.

Event Timeline

Joe triaged this task as High priority.Jan 31 2024, 7:46 AM
Joe created this task.

Change 992627 had a related patch set uploaded (by Giuseppe Lavagetto; author: Giuseppe Lavagetto):

[mediawiki/extensions/TimedMediaHandler@master] Convert midiToAudioEncode to use BoxedCommand

https://gerrit.wikimedia.org/r/992627

Change 993674 had a related patch set uploaded (by Giuseppe Lavagetto; author: Giuseppe Lavagetto):

[mediawiki/extensions/TimedMediaHandler@master] Convert ffmpegEncode to boxedCommand

https://gerrit.wikimedia.org/r/993674

Change 992627 merged by jenkins-bot:

[mediawiki/extensions/TimedMediaHandler@master] Convert midiToAudioEncode to use BoxedCommand

https://gerrit.wikimedia.org/r/992627

Change 993674 merged by jenkins-bot:

[mediawiki/extensions/TimedMediaHandler@master] Convert ffmpegEncode to boxedCommand

https://gerrit.wikimedia.org/r/993674

Change 995178 had a related patch set uploaded (by Giuseppe Lavagetto; author: Giuseppe Lavagetto):

[mediawiki/extensions/TimedMediaHandler@master] Minor fixes for WebVideoTranscodeJob

https://gerrit.wikimedia.org/r/995178

Change 995178 merged by jenkins-bot:

[mediawiki/extensions/TimedMediaHandler@master] Minor fixes for WebVideoTranscodeJob

https://gerrit.wikimedia.org/r/995178

Change #1020923 had a related patch set uploaded (by TheDJ; author: TheDJ):

[mediawiki/extensions/TimedMediaHandler@master] Remove unused ensureShellSafe function

https://gerrit.wikimedia.org/r/1020923

Change #1020923 merged by jenkins-bot:

[mediawiki/extensions/TimedMediaHandler@master] Remove unused ensureShellSafe function

https://gerrit.wikimedia.org/r/1020923