Page MenuHomePhabricator
Create Task
Maniphest T356468

Convert LogFormatter to use dependency injection
Closed, ResolvedPublic
Actions

Description

rMW9de0e23b48dc: Support dependency injection in log formatters converted $wgLogActionsHandler to use dependency injection, but on hindsight that isn't very useful in practice. Basically every log action handler extends core's LogFormatter which doesn't use dependency injection, and converting it means every child class will have to be updated, so it would be nice to get that in before the 1.42 release. To be able to hard deprecate the old way of constructing formatters, all Wikimedia extensions need to be updated.

  • MediaWiki core (28 files)
  • mediawiki/extensions/AbuseFilter (5 files)
  • mediawiki/extensions/CentralAuth (9 files)
  • mediawiki/extensions/CheckUser (4 files)
  • mediawiki/extensions/FlaggedRevs (2 files)
  • mediawiki/extensions/Flow (1 files)
  • mediawiki/extensions/GlobalBlocking (1 files)
  • mediawiki/extensions/GrowthExperiments (3 files)
  • mediawiki/extensions/IPInfo (2 files)
  • mediawiki/extensions/Interwiki (1 files)
  • mediawiki/extensions/LiquidThreads (1 files)
  • mediawiki/extensions/MassMessage (2 files)
  • mediawiki/extensions/Newsletter (1 files)
  • mediawiki/extensions/OAuth (1 files)
  • mediawiki/extensions/PageTriage (1 files)
  • mediawiki/extensions/SpamBlacklist (1 files)
  • mediawiki/extensions/Thanks (1 files)
  • mediawiki/extensions/Translate (1 files) - MLEB, not requires 1.42 yet
  • mediawiki/extensions/TranslationNotifications (1 files)
  • mediawiki/extensions/WikimediaMessages (1 files)

Details

Show related patches Customize query in gerrit

Related Objects

Event Timeline

Tgr created this task.Feb 2 2024, 12:55 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 2 2024, 12:55 AM
gerritbot added a comment.Feb 2 2024, 10:14 AM

Change 995184 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/core@master] [WIP] logging: Convert to dependency injection

https://gerrit.wikimedia.org/r/995184

gerritbot added a project: Patch-For-Review.Feb 2 2024, 10:14 AM

Change 995185 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/core@master] [WIP] logging: Add LogFormatterFactory

https://gerrit.wikimedia.org/r/995185

gerritbot added a comment.Feb 2 2024, 10:14 AM

Change 995186 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/core@master] [WIP] logging: Hard-deprecate instantiating core loggers without DI

https://gerrit.wikimedia.org/r/995186

Tgr updated the task description. (Show Details)Feb 3 2024, 3:41 AM
Tgr updated the task description. (Show Details)Feb 3 2024, 8:58 PM
gerritbot added a comment.Feb 4 2024, 4:41 AM

Change 995682 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/CentralAuth@master] Convert loggers to dependency injection

https://gerrit.wikimedia.org/r/995682

gerritbot added a comment.Feb 4 2024, 4:41 AM

Change 995843 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/AbuseFilter@master] Convert loggers to dependency injection

https://gerrit.wikimedia.org/r/995843

gerritbot added a comment.Feb 4 2024, 7:02 AM

Change 995925 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/OAuth@master] Update log formatter dependency injection

https://gerrit.wikimedia.org/r/995925

gerritbot added a comment.Feb 28 2024, 9:56 PM

Change 1007438 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] Inject services into LogFormatter base class and use it

https://gerrit.wikimedia.org/r/1007438

gerritbot added a comment.Feb 28 2024, 10:07 PM

Change 1007440 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] logging: Inject services into PageLangLogFormatter

https://gerrit.wikimedia.org/r/1007440

gerritbot added a comment.Feb 29 2024, 6:56 PM

Change 1007687 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] logging: Inject services into LegacyLogFormatter

https://gerrit.wikimedia.org/r/1007687

gerritbot added a comment.Mar 28 2024, 12:32 AM

Change #1007438 merged by jenkins-bot:

[mediawiki/core@master] logging: Inject services into LogFormatter base class and use it

https://gerrit.wikimedia.org/r/1007438

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.25; 2024-04-02).Mar 28 2024, 1:00 AM
gerritbot added a comment.Mar 28 2024, 1:53 AM

Change #1007440 merged by jenkins-bot:

[mediawiki/core@master] logging: Inject services into PageLangLogFormatter

https://gerrit.wikimedia.org/r/1007440

gerritbot added a comment.Mar 28 2024, 1:55 AM

Change #1007687 merged by jenkins-bot:

[mediawiki/core@master] logging: Inject services into LegacyLogFormatter

https://gerrit.wikimedia.org/r/1007687

matmarex subscribed.Mar 28 2024, 2:04 AM
Umherirrender updated the task description. (Show Details)Mar 28 2024, 9:53 PM
gerritbot added a comment.Mar 29 2024, 8:05 PM

Change #1015582 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/IPInfo@master] logging: Inject services into IPInfoLogFormatter

https://gerrit.wikimedia.org/r/1015582

gerritbot added a comment.Mar 29 2024, 8:09 PM

Change #1015583 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/MassMessage@master] logging: Use injected services in MassMessageSkipLogFormatter

https://gerrit.wikimedia.org/r/1015583

Umherirrender updated the task description. (Show Details)Mar 29 2024, 8:13 PM
gerritbot added a comment.Mar 29 2024, 8:38 PM

Change #1015588 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/AbuseFilter@master] logging: Inject services into AbuseLogHitFormatter

https://gerrit.wikimedia.org/r/1015588

gerritbot added a comment.Mar 29 2024, 8:43 PM

Change #1015589 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/CheckUser@master] logging: Inject services into LogFormatters

https://gerrit.wikimedia.org/r/1015589

gerritbot added a comment.Mar 29 2024, 8:50 PM

Change #1015591 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/FlaggedRevs@master] logging: Inject services into FlaggedRevsReviewLogFormatter

https://gerrit.wikimedia.org/r/1015591

gerritbot added a comment.Mar 30 2024, 1:51 AM

Change #1015588 merged by jenkins-bot:

[mediawiki/extensions/AbuseFilter@master] logging: Inject services into AbuseLogHitFormatter

https://gerrit.wikimedia.org/r/1015588

gerritbot added a comment.Mar 30 2024, 1:51 AM

Change #1015591 merged by jenkins-bot:

[mediawiki/extensions/FlaggedRevs@master] logging: Inject services into FlaggedRevsReviewLogFormatter

https://gerrit.wikimedia.org/r/1015591

gerritbot added a comment.Mar 30 2024, 1:53 AM

Change #1015589 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] logging: Inject services into LogFormatters

https://gerrit.wikimedia.org/r/1015589

gerritbot added a comment.Mar 30 2024, 1:53 AM

Change #1015582 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@master] logging: Inject services into IPInfoLogFormatter

https://gerrit.wikimedia.org/r/1015582

gerritbot added a comment.Mar 30 2024, 1:53 AM

Change #1015583 merged by jenkins-bot:

[mediawiki/extensions/MassMessage@master] logging: Use injected services in MassMessageSkipLogFormatter

https://gerrit.wikimedia.org/r/1015583

gerritbot added a comment.Apr 2 2024, 7:06 PM

Change #995184 abandoned by Bartosz Dziewoński:

[mediawiki/core@master] logging: Convert to dependency injection

Reason:

Superseded by https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1007438

https://gerrit.wikimedia.org/r/995184

gerritbot added a comment.Apr 2 2024, 7:07 PM

Change #995185 merged by jenkins-bot:

[mediawiki/core@master] logging: Add LogFormatterFactory

https://gerrit.wikimedia.org/r/995185

gerritbot added a comment.Apr 2 2024, 7:07 PM

Change #995843 abandoned by Bartosz Dziewoński:

[mediawiki/extensions/AbuseFilter@master] Convert loggers to dependency injection

Reason:

Superseded by https://gerrit.wikimedia.org/r/c/mediawiki/extensions/AbuseFilter/+/1015588

https://gerrit.wikimedia.org/r/995843

gerritbot added a comment.Apr 2 2024, 7:10 PM

Change #995682 abandoned by Bartosz Dziewoński:

[mediawiki/extensions/CentralAuth@master] Convert loggers to dependency injection

Reason:

No longer needed

https://gerrit.wikimedia.org/r/995682

gerritbot added a comment.Apr 2 2024, 7:28 PM

Change #995925 abandoned by Bartosz Dziewoński:

[mediawiki/extensions/OAuth@master] Update log formatter dependency injection

Reason:

No longer needed

https://gerrit.wikimedia.org/r/995925

matmarex added a subscriber: Umherirrender.Apr 2 2024, 7:49 PM

@Umherirrender's alternative solution https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1007438 means that we don't have to update every extension to accept services as LogFormatter constructor parameters, since they get injected by the LogFormatterFactory using setter methods.

I think this means that this is done?

The patch to add warnings when the services are not provided is now passing tests, and I'm not seeing any warnings with it locally either: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/995186

matmarex added a project: MediaWiki-Platform-Team.Apr 2 2024, 8:57 PM
matmarex moved this task from Inbox, needs triage to Current Sprint on the MediaWiki-Platform-Team board.
ReleaseTaggerBot edited projects, added MW-1.42-notes (1.42.0-wmf.26; 2024-04-09); removed MW-1.42-notes (1.42.0-wmf.25; 2024-04-02).Apr 3 2024, 3:02 PM
gerritbot added a comment.Apr 5 2024, 6:28 PM

Change #995186 merged by jenkins-bot:

[mediawiki/core@master] logging: Hard-deprecate instantiating core loggers without DI

https://gerrit.wikimedia.org/r/995186

matmarex closed this task as Resolved.Apr 5 2024, 6:59 PM
matmarex assigned this task to Umherirrender.
matmarex removed a project: Patch-For-Review.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL