The "Go" button is the one on the on-screen keyboard. (TouchPal)
Version: 1.0.0 (Android)
Severity: normal
Description
Description
Details
Details
- Reference
- bz33656
| Title | Reference | Author | Source Branch | Dest Branch | |
|---|---|---|---|---|---|
| runner: try to run without --legacy-peer-deps | repos/ci-tools/libup!19 | taavi | taavi/legacy-peer-depes | master | |
| Update Runner to Bookworm / Python 3.11 / Node 18 / Npm 9 | repos/ci-tools/libup!17 | taavi | taavi/upgrade-all-the-things | master | |
| Always compress text blobs | repos/ci-tools/libup!14 | ladsgroup | compress_all_the_things | master |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | None | T33805 Wikipedia Android App 1.1 tracking - current bugs | |||
| Resolved | yuvipanda | T35656 The search box should lose focus when a Go action is performed. |
Event Timeline
Comment Actions
philinje wrote:
Noticing a similar problem with hardware search key highlighting the search field.
Comment Actions
stagi.andrea wrote:
Fixed with my new pull request! https://github.com/wikimedia/WikipediaMobile/pull/122
Comment Actions
I'm not quite sure I understand this bug; in my testing on Nexus 1, focus seems to do what I expect offhand when hitting the 'go' button.
commit 3f6c44ba07b0fcaa014926a57f8ae7bdda65f865 in Andrea's branch appears to explicitly disable the search box during navigation, which worries me -- I think we'd want that to still work so if the load takes a long time you can start doing something else.
Comment Actions
stagi.andrea wrote:
I understand it in this way: please disable search box during navigation.. Anyway Brion I'm agree with you, anyway user could cancel the action of loading.. would you like I make a reverse commit? refactoring is to be considered anyway, I will remove only the part of disabling search box..
Comment Actions
(In reply to comment #4)
I understand it in this way: please disable search box during navigation..
Anyway Brion I'm agree with you, anyway user could cancel the action of
loading.. would you like I make a reverse commit? refactoring is to be
considered anyway, I will remove only the part of disabling search box..
See [[Focus (computing)]].
Comment Actions
stagi.andrea wrote:
Thanks for the reference ^^ thanks for reporting this bug, was not a graphical only question! this bug is fixed, someone merge this plz: https://github.com/wikimedia/WikipediaMobile/pull/128 .
Comment Actions
philinje wrote:
Hopefully this also fixed the bug about search box not losing focus after search with hardware search key.
Comment Actions
stagi.andrea wrote:
Uhm no sorry, they are not related.. anyway for that I opened another pull request, so will be fixed soon ^^