philinje wrote:

Noticing a similar problem with hardware search key highlighting the search field.

stagi.andrea wrote:

Fixed with my new pull request! https://github.com/wikimedia/WikipediaMobile/pull/122

I'm not quite sure I understand this bug; in my testing on Nexus 1, focus seems to do what I expect offhand when hitting the 'go' button.

commit 3f6c44ba07b0fcaa014926a57f8ae7bdda65f865 in Andrea's branch appears to explicitly disable the search box during navigation, which worries me -- I think we'd want that to still work so if the load takes a long time you can start doing something else.

stagi.andrea wrote:

I understand it in this way: please disable search box during navigation.. Anyway Brion I'm agree with you, anyway user could cancel the action of loading.. would you like I make a reverse commit? refactoring is to be considered anyway, I will remove only the part of disabling search box..

(In reply to comment #4)

I understand it in this way: please disable search box during navigation..
Anyway Brion I'm agree with you, anyway user could cancel the action of
loading.. would you like I make a reverse commit? refactoring is to be
considered anyway, I will remove only the part of disabling search box..

See [[Focus (computing)]].

stagi.andrea wrote:

Thanks for the reference ^^ thanks for reporting this bug, was not a graphical only question! this bug is fixed, someone merge this plz: https://github.com/wikimedia/WikipediaMobile/pull/128 .

philinje wrote:

Hopefully this also fixed the bug about search box not losing focus after search with hardware search key.

stagi.andrea wrote:

Uhm no sorry, they are not related.. anyway for that I opened another pull request, so will be fixed soon ^^