Maniphest T356750

🍦 Add existing request validation to SetSitelink
Closed, ResolvedPublic
Actions

Assigned To

Dima_Koushha_WMDE

Authored By

	Ollie.Shotton_WMDE
	Feb 6 2024, 10:34 AM

Tags

Referenced Files

None

Subscribers

Ollie.Shotton_WMDE

Description

Add validation for the parts of the request we already have request validating deserializers for, i.e.:

item_id
site_id
edit metadata

Details

Other Assignee: Ollie.Shotton_WMDE

	Subject	Repo	Branch	Lines +/-
	REST: Validate PUT sitelink request	mediawiki/extensions/Wikibase	master	+267 -108
	REST: Validate PUT sitelink request	mediawiki/extensions/Wikibase	master	+271 -114

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T344228 Functionality for REST API v1
		Resolved		Ifrahkhanyaree_WMDE	T342987 🍦 Create/replace a sitelink to an item on a given wiki
		Resolved		Dima_Koushha_WMDE	T356750 🍦 Add existing request validation to SetSitelink

Event Timeline

Ollie.Shotton_WMDE created this task.Feb 6 2024, 10:34 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 6 2024, 10:34 AM

Ollie.Shotton_WMDE moved this task from To Do to Peer Review on the Wikibase Product Platform Team WPP (Sprint 12) board.Feb 6 2024, 10:34 AM

Ollie.Shotton_WMDE updated Other Assignee, added: Ollie.Shotton_WMDE.

Ollie.Shotton_WMDE updated the task description. (Show Details)Feb 6 2024, 10:40 AM

WMDE-leszek edited projects, added Wikibase Product Platform Team WPP (Sprint 13); removed Wikibase Product Platform Team WPP (Sprint 12).Feb 6 2024, 10:48 AM

WMDE-leszek moved this task from To Do to Peer Review on the Wikibase Product Platform Team WPP (Sprint 13) board.

Change 998393 had a related patch set uploaded (by Dima koushha; author: Dima koushha):

[mediawiki/extensions/Wikibase@master] REST: Validate PUT sitelink request

https://gerrit.wikimedia.org/r/998393

gerritbot added a project: Patch-For-Review.Feb 7 2024, 12:39 PM

Change 998393 abandoned by Dima koushha:

[mediawiki/extensions/Wikibase@master] REST: Validate PUT sitelink request

Reason:

it was a mistake

https://gerrit.wikimedia.org/r/998393

Change 995036 had a related patch set uploaded (by Dima koushha; author: Dima koushha):

[mediawiki/extensions/Wikibase@master] REST: Validate PUT sitelink request

https://gerrit.wikimedia.org/r/995036

Change 995036 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Validate PUT sitelink request

https://gerrit.wikimedia.org/r/995036

Maintenance_bot removed a project: Patch-For-Review.Feb 7 2024, 3:30 PM

Dima_Koushha_WMDE moved this task from Peer Review to Done on the Wikibase Product Platform Team WPP (Sprint 13) board.Feb 7 2024, 3:33 PM

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.18; 2024-02-13).Feb 7 2024, 10:01 PM

Ifrahkhanyaree_WMDE closed this task as Resolved.Feb 20 2024, 1:32 PM