Page MenuHomePhabricator

[Java] Extract app version from pom file to populate MP Java lib version in user agent request property
Closed, DeclinedPublic

Description

Description

The current Metrics Platform Java library version is currently manually updated. Extract the ap version from the pom file and include this as a variable when sending user agent info with the event.

Technical Notes

Change set introduced in https://gitlab.wikimedia.org/repos/data-engineering/metrics-platform/-/merge_requests/29 provides a constant that must be updated manually with every release. There should be a way to extract this data from pom.xml as a variable and append it to the setting of the user agent request property in the default event sender.

See https://gitlab.wikimedia.org/repos/data-engineering/metrics-platform/-/blob/main/java/src/main/java/org/wikimedia/metrics_platform/EventSenderDefault.java?ref_type=heads#L41

Acceptance Criteria

  • Metrics Client Java library version is automatically updated in the user agent request property
  • MetricsClient:: METRICS_PLATFORM_LIBRARY_VERSION is removed
  • Test is added for verifying latest version number sent as a request property

Event Timeline

Aklapper added a subscriber: VirginiaPoundstone.

@VirginiaPoundstone: This seems to be about the Metrics Platform code base thus re-adding that project tag

Can I work on this? I tried assigning it to myself but I don't have edit permissions to do so.

Aklapper removed a subscriber: VirginiaPoundstone.

@Dut: Hi and welcome! Yes, you can work on this. :) I filed T403885 about the problem that you do not have edit permissions, sorry for that hassle...

phuedx subscribed.

Declining this as we're planning on moving the SDK to Kotlin and removing the Java SDK.

@Dut: I'm sorry that we didn't update this task sooner to reflect our thinking. T401023: [XL] xLab Client Library: Convert to Kotlin and bring into app repo. tracks the move to Kotlin. Please do comment on that task to see if/how you can contribute to the effort.