Unresolved resource attribute in Parsoid readview
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	ABreault-WMF
	Feb 14 2024, 6:29 PM

Description

From https://gerrit.wikimedia.org/r/c/mediawiki/extensions/TimedMediaHandler/+/977278/1#message-e4075b1d12fc16f252c2702acdc8aa400ba63353

Parsoid had traditionally emitted links relative to a base element in the head of the document <base href="//en.wikipedia.org/wiki/"/>. In read views, those are resolved,

<a rel="mw:WikiLink" href="//en.wikipedia.org/wiki/Help:Introduction_to_images_with_Wiki_Markup/1" class="mw-selflink selflink">...

but the resource attribute is left relative,

<img alt="Page semi-protected" resource="./File:Semi-protection-shackle.svg" ...

which is an issue on subpages.

It looks like the |link= media options is also affected,

<span typeof="mw:File" data-parsoid='{"optList":[...{"ck":"link","ak":"link=Wikipedia:Protection policy#semi"},...]}' data-mw='{"caption":"This page is semi-protected."}'><a href="./Wikipedia:Protection_policy#semi" title="This page is semi-protected." data-parsoid="{}">

Examples are from https://en.wikipedia.org/wiki/Help:Introduction_to_images_with_Wiki_Markup/1?useparsoid=1

Details

	Subject	Repo	Branch	Lines +/-
	Apply relative attr expansion to indicators	mediawiki/core	master	+16 -10
	Resolve relative resource attributes as well	mediawiki/core	master	+12 -4

Customize query in gerrit

Related Objects

Mentioned Here: T350952: After fixing subpage links in Parsoid read views, TOC links are broken

Event Timeline

ABreault-WMF created this task.Feb 14 2024, 6:29 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 14 2024, 6:29 PM

ABreault-WMF triaged this task as Medium priority.Feb 14 2024, 6:32 PM

ABreault-WMF added a project: Content-Transform-Team-WIP.

mw:WikiLinks were handled in T350952

It looks like the |link= media options is also affected,

That's surprising, given how it's implemented,
https://github.com/wikimedia/mediawiki/blob/master/includes/OutputTransform/Stages/ExtractBody.php#L36-L37

The issue is that the image is in a <div id="mw-indicator-pp-default" class="mw-indicator"> from an <indicator> extension and is equally true of mw:WikiLinks.

Change 1003540 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/core@master] [WIP] Resolve relative resource attributes as well

https://gerrit.wikimedia.org/r/1003540

gerritbot added a project: Patch-For-Review.Feb 14 2024, 9:15 PM

Change 1003562 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/core@master] [WIP] Apply relative attr expansion to indicators

https://gerrit.wikimedia.org/r/1003562

ABreault-WMF moved this task from Backlog to Code Review on the Content-Transform-Team-WIP board.Feb 14 2024, 11:07 PM

Change 1003540 merged by jenkins-bot:

[mediawiki/core@master] Resolve relative resource attributes as well

https://gerrit.wikimedia.org/r/1003540

Change 1003562 merged by jenkins-bot:

[mediawiki/core@master] Apply relative attr expansion to indicators

https://gerrit.wikimedia.org/r/1003562

Maintenance_bot removed a project: Patch-For-Review.Feb 15 2024, 3:30 AM

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.19; 2024-02-20).Feb 15 2024, 4:00 AM

MSantos moved this task from Needs Triage to Bugs & Crashers on the Parsoid board.Feb 15 2024, 3:08 PM

Arlolra moved this task from Code Review to To Verify on the Content-Transform-Team-WIP board.Feb 20 2024, 11:29 PM