Page MenuHomePhabricator
Create Task
Maniphest T350952

After fixing subpage links in Parsoid read views, TOC links are broken
Closed, ResolvedPublic
Actions

Description

Parsoid usually sets a <base href> in the document, but when embedded page in an article this doesn't exist so our links are all broken.

See the [[Opportunities for the Content Transform Team]] link at https://en.wikipedia.org/wiki/User:Cscott/Ideas?useparsoid=1

EDIT: After adding the missing <base href>, all TOC links are broken; see comment below.

Details

SubjectRepoBranchLines +/-
[parsoid] Fix Parsoid relative linksmediawiki/coremaster+27 -8
[parsoid] Fix Parsoid relative linksmediawiki/corewmf/1.42.0-wmf.5+27 -8
[parsoid] Fix Parsoid relative links, take 2mediawiki/coremaster+19 -15
Fix Parsoid <base href>mediawiki/coremaster+6 -0
Customize query in gerrit

Related Objects

Event Timeline

cscott created this task.Nov 10 2023, 4:04 PM
Restricted Application added a project: Parsoid. · View Herald TranscriptNov 10 2023, 4:04 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
ssastry added a comment.Nov 10 2023, 4:25 PM

I think we should fix this sooner than later .. I suspect officewiki has subpage links.

cscott added a comment.Nov 10 2023, 4:32 PM

The solution to this might also fix T310520, if we're implementing a parsoid-read-views-specific href rewriting postprocessing pass.

Things to be careful of:

  • Don't break VE or other Parsoid clients who probably rely on href="./ in edit-mode HTML
  • Don't break links in the skin (ie, can we "just" change the <base href> on the page like parsoid does, or will that break other stuff surrounding the article?)
gerritbot added a comment.Nov 10 2023, 4:56 PM

Change 973361 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: C. Scott Ananian):

[mediawiki/core@master] Fix Parsoid <base href>

https://gerrit.wikimedia.org/r/973361

gerritbot added a project: Patch-For-Review.Nov 10 2023, 4:56 PM
gerritbot added a comment.Nov 10 2023, 5:35 PM

Change 973361 merged by jenkins-bot:

[mediawiki/core@master] Fix Parsoid <base href>

https://gerrit.wikimedia.org/r/973361

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.5; 2023-11-14).Nov 10 2023, 6:00 PM
Maintenance_bot removed a project: Patch-For-Review.Nov 10 2023, 6:10 PM
ssastry added a comment.Nov 10 2023, 6:26 PM

I merged and pushed to beta, but TOC link fragments are broken (see https://en.wikipedia.beta.wmflabs.org/wiki/African_linsang?useparsoid=1 )

cscott renamed this task from Parsoid read views don't handle subpage links to After fixing subpage links in Parsoid read views, TOC links are broken.Nov 15 2023, 3:54 PM
cscott updated the task description. (Show Details)
MSantos triaged this task as High priority.Nov 16 2023, 3:20 PM
MSantos edited projects, added Content-Transform-Team-WIP; removed Content-Transform-Team.
MSantos moved this task from Needs Triage to Bugs & Crashers on the Parsoid board.
MSantos moved this task from Uncategorized to Phase 1 - DiscussionTools support on the Parsoid-Read-Views board.Nov 16 2023, 3:26 PM
MSantos edited projects, added Parsoid-Read-Views (Phase 1 - DiscussionTools support); removed Parsoid-Read-Views.
gerritbot added a comment.Nov 16 2023, 5:20 PM

Change 975051 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] [parsoid] Fix Parsoid relative links

https://gerrit.wikimedia.org/r/975051

gerritbot added a project: Patch-For-Review.Nov 16 2023, 5:20 PM
cscott mentioned this in T310520: Parsoid content not compatible with `index.php?title=` URLs.Nov 16 2023, 8:52 PM
gerritbot added a comment.Nov 16 2023, 8:52 PM

Change 975081 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] [parsoid] Fix Parsoid relative links, take 2

https://gerrit.wikimedia.org/r/975081

matmarex subscribed.Nov 16 2023, 9:20 PM
gerritbot added a comment.Nov 17 2023, 7:45 PM

Change 975051 merged by jenkins-bot:

[mediawiki/core@master] [parsoid] Fix Parsoid relative links

https://gerrit.wikimedia.org/r/975051

ReleaseTaggerBot edited projects, added MW-1.42-notes (1.42.0-wmf.7; 2023-11-28); removed MW-1.42-notes (1.42.0-wmf.5; 2023-11-14).Nov 17 2023, 8:00 PM
MSantos assigned this task to cscott.Nov 20 2023, 4:17 PM
MSantos moved this task from Backlog to Code Review on the Content-Transform-Team-WIP board.
MSantos moved this task from Code Review to To Deploy on the Content-Transform-Team-WIP board.
MSantos moved this task from To Deploy to Code Review on the Content-Transform-Team-WIP board.
gerritbot added a comment.Nov 20 2023, 4:20 PM

Change 975081 abandoned by C. Scott Ananian:

[mediawiki/core@master] [parsoid] Fix Parsoid relative links, take 2

Reason:

Abandoned in favor of I60165a9946a35cfb42a78ed2f833c34570fefffc

https://gerrit.wikimedia.org/r/975081

gerritbot added a comment.Nov 20 2023, 4:22 PM

Change 975596 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@wmf/1.42.0-wmf.5] [parsoid] Fix Parsoid relative links

https://gerrit.wikimedia.org/r/975596

gerritbot added a comment.Nov 20 2023, 10:27 PM

Change 975596 merged by jenkins-bot:

[mediawiki/core@wmf/1.42.0-wmf.5] [parsoid] Fix Parsoid relative links

https://gerrit.wikimedia.org/r/975596

Stashbot added a comment.Nov 20 2023, 10:27 PM

Mentioned in SAL (#wikimedia-operations) [2023-11-20T22:27:22Z] <catrope@deploy2002> Started scap: Backport for [[gerrit:975596|[parsoid] Fix Parsoid relative links (T350952)]]

Stashbot added a comment.Nov 20 2023, 10:28 PM

Mentioned in SAL (#wikimedia-operations) [2023-11-20T22:28:40Z] <catrope@deploy2002> catrope and cscott: Backport for [[gerrit:975596|[parsoid] Fix Parsoid relative links (T350952)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Maintenance_bot removed a project: Patch-For-Review.Nov 20 2023, 10:30 PM
Stashbot added a comment.Nov 20 2023, 10:46 PM

Mentioned in SAL (#wikimedia-operations) [2023-11-20T22:46:54Z] <catrope@deploy2002> Finished scap: Backport for [[gerrit:975596|[parsoid] Fix Parsoid relative links (T350952)]] (duration: 19m 32s)

ReleaseTaggerBot edited projects, added MW-1.42-notes (1.42.0-wmf.5; 2023-11-14); removed MW-1.42-notes (1.42.0-wmf.7; 2023-11-28).Nov 20 2023, 11:00 PM
cscott added a comment.Nov 20 2023, 11:17 PM

Merged and backported to production; you might need ?action=purge on Parsoid Read Views pages for a while to get the sidebar links correct, since we need to regenerate the page without the <base href> in the ParserOutput::addHeadItems.

cscott moved this task from Code Review to To Deploy on the Content-Transform-Team-WIP board.Nov 27 2023, 4:06 PM
cscott moved this task from To Deploy to To Verify on the Content-Transform-Team-WIP board.
MSantos closed this task as Resolved.Dec 4 2023, 4:13 PM
ABreault-WMF mentioned this in T357573: Unresolved resource attribute in Parsoid readview.Feb 14 2024, 8:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits