Maniphest T358025

Lookup with initial suggestions: include Guidelines in Codex
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	bmartinezcalvo
	Feb 20 2024, 5:47 PM

Tags

Referenced Files

	F41983312: lookup-types-suggestions.svg
	Feb 20 2024, 5:47 PM

Subscribers

Description

Background & Goal

In T350946: Lookup: Option to open menu when field is focused we implemented the Lookup with initial suggestions. We need to include the Guidelines for this use case as we do with the rest of props for this and other components

Guidelines documentation

Doc with Guidelines to include in Codex

Acceptance criteria (or Done)

Design

Document this use case in the component's guidelines. Provide the info to include and the image (this will be included in the Lookup > Guidelines > Types) section.

lookup-types-suggestions.svg57 KBDownload

Code

Update the Guidelines in Codex to include this use case (as provided by the designer)

Details

	Subject	Repo	Branch	Lines +/-
	Update Codex from v1.3.3 to v1.3.4	mediawiki/core	master	+2 K -635
	docs: add guidelines for Lookup with initial suggestions	design/codex	main	+59 -6

Customize query in gerrit

Related Objects

Mentioned In: T350946: Lookup: Option to open menu when field is focused
Mentioned Here: T350946: Lookup: Option to open menu when field is focused

Event Timeline

bmartinezcalvo created this task.Feb 20 2024, 5:47 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 20 2024, 5:47 PM

bmartinezcalvo mentioned this in T350946: Lookup: Option to open menu when field is focused.Feb 20 2024, 5:48 PM

bmartinezcalvo moved this task from Inbox to Up Next on the Design-System-Team board.

bmartinezcalvo attached a referenced file: F41983312: lookup-types-suggestions.svg. (Show Details)Feb 20 2024, 6:10 PM

CCiufo-WMF assigned this task to bmartinezcalvo.Feb 20 2024, 6:54 PM

CCiufo-WMF triaged this task as Medium priority.

CCiufo-WMF moved this task from Up Next to DST-Sprint-17 (2024-02-20 to 2024-03-01) on the Design-System-Team board.

CCiufo-WMF edited projects, added Design-System-Team (DST-Sprint-17 (2024-02-20 to 2024-03-01)); removed Design-System-Team.

bmartinezcalvo moved this task from Committed to In Progress on the Design-System-Team (DST-Sprint-17 (2024-02-20 to 2024-03-01)) board.Feb 21 2024, 9:29 AM

Change 1005497 had a related patch set uploaded (by Bmartinezcalvo; author: Bmartinezcalvo):

[design/codex@main] docs: add guidelines for Lookup with initial suggestions

https://gerrit.wikimedia.org/r/1005497

gerritbot added a project: Patch-For-Review.Feb 21 2024, 12:24 PM

bmartinezcalvo moved this task from In Progress to Code Review on the Design-System-Team (DST-Sprint-17 (2024-02-20 to 2024-03-01)) board.Feb 21 2024, 5:26 PM

Change 1005497 merged by jenkins-bot:

[design/codex@main] docs: add guidelines for Lookup with initial suggestions

https://gerrit.wikimedia.org/r/1005497

bmartinezcalvo updated the task description. (Show Details)Feb 22 2024, 5:37 PM

bmartinezcalvo moved this task from Code Review to Pending Release on the Design-System-Team (DST-Sprint-17 (2024-02-20 to 2024-03-01)) board.

Volker_E removed a project: Patch-For-Review.Feb 22 2024, 6:05 PM

Change 1008950 had a related patch set uploaded (by LWatson; author: LWatson):

[mediawiki/core@master] Update Codex from v1.3.3 to v1.3.4

https://gerrit.wikimedia.org/r/1008950

gerritbot added a project: Patch-For-Review.Mar 5 2024, 8:50 PM

Test wiki created on Patch demo by ATomasevich (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/cd11cbf23a/w

Change 1008950 merged by jenkins-bot:

[mediawiki/core@master] Update Codex from v1.3.3 to v1.3.4

https://gerrit.wikimedia.org/r/1008950

Maintenance_bot removed a project: Patch-For-Review.Mar 5 2024, 11:31 PM

lwatson closed this task as Resolved.Mar 6 2024, 10:10 PM