etc.
Open, In Progress, LowPublic
Actions

Assigned To

None

Authored By

	GrounderUK
	Feb 27 2024, 12:14 PM

Description

View the evaluation details (metadata) in any (?) language other than English. The value for Implementation Type is an English word (“BuiltIn”, “Evaluated” or “Composition”).

It should be text in the selected language, if available, but it seems there is nowhere to translate this. It should presumably take the appropriate value from the Z14K2, Z14K3 or Z14K4.

This may be a bug or a missing feature. Queried by @Amire80 in Telegram and described by @DVrandecic as “weird”.

Examples in French and Hebrew:

Details

	Subject	Repo	Branch	Lines +/-
	wikifunctions: Upgrade orchestrator from 2024-03-05-140533 to 2024-04-04-132719	operations/deployment-charts	master	+1 -1

Customize query in gerrit

	Title	Reference	Author	Source Branch	Dest Branch
	execute.addImplementationMetadata: Use Z14Kx values not hard-coded English strings in response	repos/abstract-wiki/wikifunctions/function-orchestrator!140	jforrester	T358571	main

Customize query in GitLab

Event Timeline

GrounderUK created this task.Feb 27 2024, 12:14 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 27 2024, 12:15 PM

Maintenance_bot added a project: Abstract Wikipedia team.Feb 27 2024, 12:30 PM

Jdforrester-WMF renamed this task from Implementation Type is untranslated in evaluation details pop-up to Evaluation type is the English-language string rather than a looked-up Z14K2/Z14K3/etc..Feb 29 2024, 5:46 PM

Jdforrester-WMF triaged this task as Low priority.

Jdforrester-WMF added a project: function-orchestrator.

Jdforrester-WMF moved this task from To triage to Backlog on the Abstract Wikipedia team board.

Jdforrester-WMF changed the task status from Open to In Progress.Mar 4 2024, 4:24 PM

Jdforrester-WMF claimed this task.

Jdforrester-WMF moved this task from Backlog to In Progress on the Abstract Wikipedia team board.

jforrester opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/140

execute.addImplementationMetadata: Use Z14Kx values not hard-coded English strings in response

apine merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/140

execute.addImplementationMetadata: Use Z14Kx values not hard-coded English strings in response

Maintenance_bot removed a project: Patch-For-Review.Mar 5 2024, 6:31 PM

OK, this will now say Type: Z14K4 etc.; we now need a change in the front-end code to dereference the key into its appropriate label.

Jdforrester-WMF removed Jdforrester-WMF as the assignee of this task.Mar 8 2024, 2:59 PM

Jdforrester-WMF moved this task from In Progress to Backlog on the Abstract Wikipedia team board.

Jdforrester-WMF subscribed.

Amire80 updated the task description. (Show Details)Mar 9 2024, 3:14 PM

Amire80 edited subscribers, added: Amire80; removed: Aaharoni-WMF.

Change #1017060 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2024-03-05-140533 to 2024-04-04-132719

https://gerrit.wikimedia.org/r/1017060

gerritbot added a project: Patch-For-Review.Apr 4 2024, 1:44 PM

Change #1017060 merged by jenkins-bot: