Page MenuHomePhabricator
Create Task
Maniphest T358958

TableFixups: reparse failures
Open, LowPublicPRODUCTION ERROR
Actions

Description

Error
normalized_message
[error/wt2html] TableFixups: Failed to successfully reparse  title="{{{drużyna3}}}-{{{drużyna2}}}" | as table cell attributes
exception.trace
Impact
Notes

Details

Request URL
https://pl.wikipedia.org/w/rest.php/pl.wikipedia.org/v3/page/pagebundle/Szablon%3AFb-wyniki-kluby-4/72945890
SubjectRepoBranchLines +/-
Bump wikimedia/parsoid to 0.20.0-a25mediawiki/vendormaster+615 -271
Remove stripDoubleTDs passmediawiki/services/parsoidmaster+67 -93
Bump wikimedia/parsoid to 0.20.0-a23mediawiki/vendormaster+2 K -1 K
Exit early from combineAttrsWithPreviousCell if prev had trailing barmediawiki/services/parsoidmaster+47 -2
Customize query in gerrit

Related Objects

Event Timeline

ssastry created this task.Mar 2 2024, 6:48 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 2 2024, 6:48 PM
MSantos moved this task from Needs Triage to Bugs & Crashers on the Parsoid board.Mar 7 2024, 3:25 PM
MSantos removed a project: Content-Transform-Team.
ssastry added a project: Content-Transform-Team-WIP.Mar 8 2024, 9:51 PM
ssastry added a comment.Mar 8 2024, 9:57 PM

The plwiki URL is a template page and is a mess that Parsoid doesn't know how to render properly ... I consider that an edge case. The use of the template itself on article pages seems to render fine. So, for now, ignoring that page.

Other urls triggering this in the last 3 weeks:

  • /w/rest.php/ru.wikipedia.org/v3/page/pagebundle/Arular/125627855
  • /w/rest.php/id.wikipedia.org/v3/page/pagebundle/4_Minutes/17883825
ssastry claimed this task.Mar 8 2024, 9:58 PM
thcipriani moved this task from Untriaged to Mar 2024 on the Wikimedia-production-error board.Mar 21 2024, 3:26 PM
ssastry added a comment.Apr 3 2024, 5:11 AM

/w/rest.php/id.wikipedia.org/v3/page/pagebundle/4_Minutes/17883825

https://id.wikipedia.org/wiki/4_Minutes#Charts shows that the markup is broken.

/w/rest.php/ru.wikipedia.org/v3/page/pagebundle/Arular/125627855

https://ru.wikipedia.org/wiki/Arular#%D0%A7%D0%B0%D1%80%D1%82%D1%8B also shows that the markup is similarly broken as on the idwiki page.

The better fix in both these cases is to fix the wikitext on the page.

ssastry added a comment.EditedApr 3 2024, 5:15 AM

Looks like I previously created this sandbox page on ruwiki for testing / possible fixing, but at this time I am inclined to leave these cases as wont-fix.

ssastry added a comment.Apr 3 2024, 5:18 AM

https://ru.wikipedia.org/wiki/%D0%A8%D0%B0%D0%B1%D0%BB%D0%BE%D0%BD%3ACountyrow is a template page and similar to the plwiki template case.

ssastry triaged this task as Low priority.Apr 3 2024, 5:20 AM

If I exclude all these titles from the logstash filter, in the last month, there are no other pages that emit this warning. So, I am inclined to leave this as a low-priority task as a possible wont-fix. Given the low rate of errors, I am also inclined to not bother trying to figure how to selectively suppress these errors.

MSantos moved this task from Uncategorized to Phase 1 - DiscussionTools support on the Parsoid-Read-Views board.Apr 11 2024, 2:29 PM
MSantos edited projects, added Parsoid-Read-Views (Phase 1 - DiscussionTools support); removed Parsoid-Read-Views.
ihurbain subscribed.EditedAug 29 2024, 9:07 AM

It also seems to trigger on /w/rest.php/pt.wikipedia.org/v3/page/pagebundle/Lista_de_ilhas_por_ponto_mais_alto/68032329, on /w/rest.php/pt.wikipedia.org/v3/page/pagebundle/Bra%C8%99ov/67088874 and on /w/rest.php/en.wikipedia.org/v3/page/pagebundle/Turkey_women%27s_national_under-19_football_team/1218103296.

Both seem to trigger on a pattern like "TableFixups: Failed to successfully reparse [[Robles Point]] || as table cell attributes", which might be worth investigating.

ihurbain added a comment.Aug 29 2024, 9:36 AM

Found a some more in the past 48 hours, so let me add the explicit list:

  • /w/rest.php/pt.wikipedia.org/v3/page/pagebundle/Lista_de_ilhas_por_ponto_mais_alto/68032329
  • /w/rest.php/en.wikipedia.org/v3/page/pagebundle/Turkey_women%27s_national_under-19_football_team/1218103296 and /w/rest.php/en.wikipedia.org/v3/page/pagebundle/Turkey_women%27s_national_under-17_football_team/1173833577
  • /w/rest.php/pt.wikipedia.org/v3/page/pagebundle/Bra%C8%99ov/67088874
  • /w/rest.php/pt.wikipedia.org/v3/page/pagebundle/Subdivis%C3%B5es_da_Rep%C3%BAblica_Dominicana/65341343
  • /w/rest.php/pt.wikipedia.org/v3/page/pagebundle/Tulum_(munic%C3%ADpio)/64312515
  • /w/rest.php/pt.wikipedia.org/v3/page/pagebundle/Siachen_Muztagh/67389808
  • /w/rest.php/ru.wikipedia.org/v3/page/pagebundle/%D0%A1%D0%B1%D0%BE%D1%80%D0%BD%D0%B0%D1%8F_%D0%93%D0%B5%D1%80%D0%BC%D0%B0%D0%BD%D0%B8%D0%B8_%D0%BF%D0%BE_%D1%84%D1%83%D1%82%D0%B1%D0%BE%D0%BB%D1%83/139844511
  • /w/rest.php/th.wikipedia.org/v3/page/pagebundle/%E0%B8%9F%E0%B8%B8%E0%B8%95%E0%B8%9A%E0%B8%AD%E0%B8%A5%E0%B8%97%E0%B8%B5%E0%B8%A1%E0%B8%8A%E0%B8%B2%E0%B8%95%E0%B8%B4%E0%B8%AA%E0%B8%A7%E0%B8%B4%E0%B8%95%E0%B9%80%E0%B8%8B%E0%B8%AD%E0%B8%A3%E0%B9%8C%E0%B9%81%E0%B8%A5%E0%B8%99%E0%B8%94%E0%B9%8C/11598002
  • /w/rest.php/ru.wikipedia.org/v3/page/pagebundle/%D0%A3%D1%87%D0%B0%D1%81%D1%82%D0%BD%D0%B8%D0%BA%3AIvan_A._Krestinin%2F%D0%90%D0%BA%D1%82%D1%83%D0%B0%D0%BB%D1%8C%D0%BD%D0%BE%D1%81%D1%82%D1%8C_%D0%B4%D0%B0%D0%BD%D0%BD%D1%8B%D1%85_%D0%BF%D0%BE_%D0%BD%D0%B0%D1%81%D0%B5%D0%BB%D1%91%D0%BD%D0%BD%D1%8B%D0%BC_%D0%BF%D1%83%D0%BD%D0%BA%D1%82%D0%B0%D0%BC/135396268
  • /w/rest.php/pt.wikipedia.org/v3/page/pagebundle/Cant%C3%A1bria/67079515
  • /w/rest.php/pt.wikipedia.org/v3/page/pagebundle/Ella_(Seri_Lanca)/67941214

triggering roughly 500 times over 48 hours.

ABreault-WMF subscribed.Sep 9 2024, 9:17 PM

Both seem to trigger on a pattern like "TableFixups: Failed to successfully reparse [[Robles Point]] || as table cell attributes", which might be worth investigating.

Hmm, I thought this regression was fixed in T371745, I'll take a look.

cscott subscribed.Sep 14 2024, 1:13 AM

Still occurring on Sept 14, eg reqid f811f908-ce17-41e9-bcd2-b8d06c43feea

cscott mentioned this in T374356: CTT tasks week of 06-Sept-2024.Sep 14 2024, 1:14 AM
gerritbot added a comment.Sep 23 2024, 11:33 PM

Change #1075086 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/services/parsoid@master] Exit early from combineAttrsWithPreviousCell if prev had trailing bar

https://gerrit.wikimedia.org/r/1075086

gerritbot added a project: Patch-For-Review.Sep 23 2024, 11:33 PM
gerritbot added a comment.Sep 24 2024, 9:23 PM

Change #1075086 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Exit early from combineAttrsWithPreviousCell if prev had trailing bar

https://gerrit.wikimedia.org/r/1075086

Maintenance_bot removed a project: Patch-For-Review.Sep 24 2024, 9:32 PM
gerritbot added a comment.Sep 30 2024, 7:50 PM

Change #1076829 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.20.0-a23

https://gerrit.wikimedia.org/r/1076829

gerritbot added a project: Patch-For-Review.Sep 30 2024, 7:50 PM
gerritbot added a comment.Sep 30 2024, 10:52 PM

Change #1076829 merged by jenkins-bot:

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.20.0-a23

https://gerrit.wikimedia.org/r/1076829

Maintenance_bot removed a project: Patch-For-Review.Sep 30 2024, 11:31 PM
gerritbot added a comment.Oct 8 2024, 7:32 PM

Change #1078741 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/services/parsoid@master] Remove stripDoubleTDs pass

https://gerrit.wikimedia.org/r/1078741

gerritbot added a project: Patch-For-Review.Oct 8 2024, 7:32 PM
gerritbot added a comment.Oct 10 2024, 2:44 AM

Change #1078741 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Remove stripDoubleTDs pass

https://gerrit.wikimedia.org/r/1078741

Maintenance_bot removed a project: Patch-For-Review.Oct 10 2024, 3:30 AM
gerritbot added a comment.Oct 14 2024, 9:13 AM

Change #1079939 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.20.0-a25

https://gerrit.wikimedia.org/r/1079939

gerritbot added a project: Patch-For-Review.Oct 14 2024, 9:13 AM
gerritbot added a comment.Oct 14 2024, 12:51 PM

Change #1079939 merged by jenkins-bot:

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.20.0-a25

https://gerrit.wikimedia.org/r/1079939

Maintenance_bot removed a project: Patch-For-Review.Oct 14 2024, 1:32 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits