Page MenuHomePhabricator
Create Task
Maniphest T358962

Heading collapse button doesn't fully transition to the margin when opening mobile VE
Closed, ResolvedPublic
Actions

Description

When loading mobile VE, the expand/collapse icon disappears and the margin animates away.

At the moment the margin doesn't fully animate away, and there is a jump when the editor finishes loading.

Screenshot_20240302-205946.png (2×1 px, 307 KB)
Screenshot_20240302-205954.png (2×1 px, 226 KB)

Details

SubjectRepoBranchLines +/-
VE: Transition margin instead of padding on new codex iconmediawiki/extensions/MobileFrontendmaster+2 -2
Customize query in gerrit

Event Timeline

Esanders created this task.Mar 2 2024, 9:03 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 2 2024, 9:03 PM
Esanders updated the task description. (Show Details)Mar 2 2024, 9:04 PM
Maintenance_bot added a project: VisualEditor.Mar 2 2024, 9:29 PM
Esanders renamed this task from Heading don't fully transition to the margin to Heading collapse button doesn't fully transition to the margin when opening mobile VE.Mar 5 2024, 9:51 PM
gerritbot added a comment.Mar 5 2024, 9:53 PM

Change 1008961 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/MobileFrontend@master] VE: Transition margin instead of padding on new codex icon

https://gerrit.wikimedia.org/r/1008961

gerritbot added a project: Patch-For-Review.Mar 5 2024, 9:53 PM
Esanders added a comment.Mar 5 2024, 9:54 PM

This was a Codex regression, as the icon went from having padding to having margin.

Esanders claimed this task.Mar 5 2024, 9:54 PM
Esanders added a project: Editing-team (Kanban Board).
Esanders moved this task from Incoming to Code Review on the Editing-team (Kanban Board) board.
DLynch moved this task from To Triage to Triaged on the VisualEditor board.Mar 7 2024, 5:10 PM
DLynch moved this task from Code Review to QA on the Editing-team (Kanban Board) board.Mar 7 2024, 5:12 PM
DLynch added a project: Editing QA.
gerritbot added a comment.Mar 7 2024, 5:34 PM

Change 1008961 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] VE: Transition margin instead of padding on new codex icon

https://gerrit.wikimedia.org/r/1008961

Maintenance_bot removed a project: Patch-For-Review.Mar 7 2024, 6:30 PM
ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.22; 2024-03-12).Mar 7 2024, 7:00 PM
Ryasmeen closed this task as Resolved.Mar 11 2024, 9:48 PM
Ryasmeen moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.
Ryasmeen edited projects, added Verified; removed Editing QA.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL