Page MenuHomePhabricator

Signatures containing score are not recognized by DiscussionTools
Closed, DeclinedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • Place score tag in signature

What happens?:
https://zh.wikipedia.org/wiki/Special:PermanentLink/81781039
src:

[[User:Example|Example]] {{5~|{{#time:c}}}}
: [[User:Example|Example]] {{5~|{{#time:c}}}}
[[User:Example|<math>Example</math>]] {{5~|{{#time:c}}}}
: [[User:Example|<math>Example</math>]] {{5~|{{#time:c}}}}
[[User:Example|<chem>Example</chem>]] {{5~|{{#time:c}}}}
: [[User:Example|<chem>Example</chem>]] {{5~|{{#time:c}}}}
[[User:Example|<score>{a'4}</score>]] {{5~|{{#time:c}}}}
: [[User:Example|<score>{a'4}</score>]] {{5~|{{#time:c}}}}

image.png (436×560 px, 41 KB)

Signatures containing the tag are not recognized by DiscussionTools and reply buttons are missing.

What should have happened instead?:
Since signatures do not prohibit score tags, DiscussionTools should be able to recognize this signature

Event Timeline

Esanders subscribed.

Anything that generates block level HTML should be disallowed in a signature, if not automatically by our signature validator, then by policy.

Yeah, I agree with that. Score isn't recognized in signatures because it outputs a <div> tag. It doesn't work for the same reasons that <math display="block"> and <pre> don't work.

The weird thing is that it outputs a block <div> tag, but it's changed in CSS to look like an inline tag. Maybe it should use a <span>, if this was intended to be supported.

If this is intended can we close this task as declined to clarify?

Shouldn’t have there been a follow-up that made these signatures illegal in the current signature parser? Because right now <math display="block"> is saveable into the prefs, and I’m sure <score> is too.