Page MenuHomePhabricator
Create Task
Maniphest T359263

Migrate MediaWiki.centralauth.* to statslib
Open, Needs TriagePublic
Actions

Description

Follow the migration process as outlined below.

Secure/Conduct code review(s).
Deploy the changes to production via the train (https://wikitech.wikimedia.org/wiki/Deployments/Train).
Verify that the changes have been successfully implemented.
Update the relevant dashboard(s) by replacing the old Graphite metric(s) with the new Prometheus metric(s).
Please follow the guidelines and standards outlined in the provided documentation:

https://www.mediawiki.org/wiki/Manual:Stats for detailed guidance on the conversion process.
https://drive.google.com/file/d/12yQEuOapkML1vb9MgCaX1QzbLBdXE6X2/view for a video tutorial on the conversion process.
https://docs.google.com/presentation/d/1SZWf_D3mWNX-XHN8PHYI84LDZr6GUQC2AMhZ9mQXCI0/edit#slide=id.g2795460c956_0_23 for slides on the best practices for converting metrics to statslib.

  • MediaWiki.centralauth.session.write.sample_rate
  • MediaWiki.centralauth.session.write.p*
  • MediaWiki.centralauth.session.read.sample_rate
  • MediaWiki.centralauth.session.read.p*
  • MediaWiki.centralAuth.IpReputation.$statsdKey." ...
  • MediaWiki.centralauth.centrallogin_errors.*

Details

SubjectRepoBranchLines +/-
Migrate IpReputationPreAuthProvider metrics to StatsLibmediawiki/extensions/CentralAuthmaster+33 -26
Customize query in gerrit

Related Objects
Search...

Event Timeline

lmata created this task.Mar 6 2024, 4:25 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 6 2024, 4:25 AM
lmata mentioned this in T350592: EPIC: migrate in use metrics and dashboards to statslib.Mar 6 2024, 4:30 AM
DAlangi_WMF changed the task status from Open to In Progress.Mar 20 2024, 8:35 AM
DAlangi_WMF claimed this task.
DAlangi_WMF triaged this task as Medium priority.
DAlangi_WMF merged a task: T360458: Migrate CentralAuth to use StatsLib.
DAlangi_WMF added a project: MediaWiki-Platform-Team.
DAlangi_WMF moved this task from Inbox, needs triage to Current Sprint on the MediaWiki-Platform-Team board.
DAlangi_WMF added subscribers: DAlangi_WMF, colewhite.
DAlangi_WMF updated the task description. (Show Details)Apr 17 2024, 9:45 AM

T360458: Migrate CentralAuth to use StatsLib has covered some of the metrics marked as done in the task in the patch: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CentralAuth/+/1012734

DAlangi_WMF moved this task from Current Sprint to Blocked/waiting on the MediaWiki-Platform-Team board.Apr 17 2024, 9:47 AM
gerritbot added a comment.Apr 17 2024, 7:11 PM

Change #1020903 had a related patch set uploaded (by D3r1ck01; author: Derick Alangi):

[mediawiki/extensions/CentralAuth@master] WIP: Migrate IpReputationPreAuthProvider metrics to StatsLib

https://gerrit.wikimedia.org/r/1020903

gerritbot added a project: Patch-For-Review.Apr 17 2024, 7:11 PM
DAlangi_WMF changed the task status from In Progress to Open.May 27 2024, 2:58 PM
DAlangi_WMF removed DAlangi_WMF as the assignee of this task.
DAlangi_WMF raised the priority of this task from Medium to Needs Triage.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits