Page MenuHomePhabricator
Create Task
Maniphest T359357

Migrate MediaModeration Extension to statslib
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

Follow the migration process as outlined below.

Secure/Conduct code review(s).
Deploy the changes to production via the train (https://wikitech.wikimedia.org/wiki/Deployments/Train).
Verify that the changes have been successfully implemented.
Update the relevant dashboard(s) by replacing the old Graphite metric(s) with the new Prometheus metric(s).
Please follow the guidelines and standards outlined in the provided documentation:

https://www.mediawiki.org/wiki/Manual:Stats for detailed guidance on the conversion process.
https://drive.google.com/file/d/12yQEuOapkML1vb9MgCaX1QzbLBdXE6X2/view for a video tutorial on the conversion process.
https://docs.google.com/presentation/d/1SZWf_D3mWNX-XHN8PHYI84LDZr6GUQC2AMhZ9mQXCI0/edit#slide=id.g2795460c956_0_23 for slides on the best practices for converting metrics to statslib.

  • MediaWiki.$wiki.MediaModeration.PhotoDNAServiceProvider.Execute.Error.count
  • MediaWiki.$wiki.MediaModeration.PhotoDNAServiceProvider.Execute.Error.rate
  • MediaWiki.$wiki.MediaModeration.PhotoDNAServiceProvider.Execute.OK.count
  • MediaWiki.$wiki.MediaModeration.PhotoDNAServiceProvider.Execute.OK.rate
  • MediaWiki.$wiki.MediaModeration.PhotoDNAServiceProvider.Execute.RuntimeException.count
  • MediaWiki.$wiki.MediaModeration.PhotoDNAServiceProvider.Execute.SourceFileUsedForFileObject.count
  • MediaWiki.$wiki.MediaModeration.PhotoDNAServiceProvider.Execute.StatusCode*.count
  • MediaWiki.$wiki.MediaModeration.PhotoDNAServiceProviderRequestTime.p75
  • MediaWiki.$wiki.MediaModeration.PhotoDNAServiceProviderRequestTime.p95
  • MediaWiki.$wiki.MediaModeration.PhotoDNAServiceProviderThumbnailTransform.p75
  • MediaWiki.$wiki.MediaModeration.PhotoDNAServiceProviderThumbnailTransform.p95
  • MediaWiki.$wiki.MediaModeration.ScanTable.Scanned
  • MediaWiki.$wiki.MediaModeration.ScanTable.TotalCount
  • MediaWiki.$wiki.MediaModeration.ScanTable.Unscanned
  • MediaWiki.$wiki.MediaModeration.ScanTable.UnscannedWithLastCheckedDefined

source code

Alerts

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Update maintenance script metrics to use StatsFactorymediawiki/extensions/MediaModerationmaster+74 -84
Update metrics to use StatsFactorymediawiki/extensions/MediaModerationmaster+368 -160
Refactor MediaModerationImageContentsLookup::getThumbnailForFilemediawiki/extensions/MediaModerationmaster+15 -21
Refactor MediaModerationFileScannerTest into an integration testmediawiki/extensions/MediaModerationmaster+94 -68
Customize query in gerrit

Related Objects
Search...

Event Timeline

• lmata created this task.Mar 6 2024, 1:48 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 6 2024, 1:48 PM
• lmata renamed this task from Migrate <metric(s)> to statslib to Migrate MediaWiki.$wiki.MediaModeration.* to statslib.Mar 6 2024, 1:48 PM
• lmata mentioned this in T350592: EPIC: migrate in use metrics and dashboards to statslib.
colewhite renamed this task from Migrate MediaWiki.$wiki.MediaModeration.* to statslib to Migrate MediaModeration Extension to statslib.Apr 26 2024, 5:08 PM
colewhite updated the task description. (Show Details)
colewhite mentioned this in T363584: Hackathon 2024: Stats!.
Dreamy_Jazz added projects: Trust and Safety Product Team, MediaModeration.May 22 2024, 9:22 AM
kostajh updated the task description. (Show Details)May 29 2024, 3:09 PM
kostajh mentioned this in T375205: MediaModeration logs are intermittently dropping.Sep 19 2024, 2:59 PM
kostajh subscribed.Sep 19 2024, 6:28 PM

If it's OK, @lmata, could we defer this migration until December or January? The one-off scan of all images on Commons should be done by then (graph). Once that's done, we could do this work and replace the old metrics with new ones.

• lmata added a comment.EditedSep 19 2024, 11:31 PM

Hi @kostajh, sure, this can wait until then if it makes the migration more convenient for you and the team; I am also adding it to our board for tracking; please reach out if you need assistance; thanks!

• lmata added a project: SRE Observability (FY2024/2025-Q3).Sep 19 2024, 11:31 PM
kostajh changed the task status from Open to Stalled.Sep 20 2024, 8:51 AM
In T359357#10163094, @lmata wrote:

Hi @kostajh, sure, this can wait until then if it makes the migration more convenient for you and the team; I am also adding it to our board for tracking; please reach out if you need assistance; thanks!

OK, cool. Marking this as stalled on T375260: Process backlog of images on Commons.

Dreamy_Jazz mentioned this in T380609: Maintenance scripts do not emit StatsLib metrics.Dec 3 2024, 11:36 AM
Dreamy_Jazz added a project: Trust and Safety Product Sprint (Sprint Chimes (Dec. 9 - Jan. 17)).Dec 4 2024, 12:17 PM
Dreamy_Jazz added a subtask: T380609: Maintenance scripts do not emit StatsLib metrics.Dec 4 2024, 1:53 PM
Dreamy_Jazz changed the task status from Stalled to Open.Dec 11 2024, 5:38 PM
Dreamy_Jazz subscribed.

The subtask (T380609) seems mostly resolved now.

Dreamy_Jazz moved this task from Priority Backlog to In Progress on the Trust and Safety Product Sprint (Sprint Chimes (Dec. 9 - Jan. 17)) board.Dec 11 2024, 5:44 PM
Dreamy_Jazz set the point value for this task to 2.Dec 11 2024, 5:46 PM
gerritbot added a comment.Dec 11 2024, 7:14 PM

Change #1102371 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/MediaModeration@master] [WIP] Update metrics to use StatsFactory

https://gerrit.wikimedia.org/r/1102371

gerritbot added a project: Patch-For-Review.Dec 11 2024, 7:14 PM
Dreamy_Jazz claimed this task.Dec 12 2024, 6:47 PM
colewhite closed subtask T380609: Maintenance scripts do not emit StatsLib metrics as Resolved.Dec 12 2024, 7:59 PM
gerritbot added a comment.Dec 13 2024, 12:50 PM

Change #1103319 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/MediaModeration@master] Refactor MediaModerationFileScannerTest into an integration test

https://gerrit.wikimedia.org/r/1103319

gerritbot added a comment.Dec 13 2024, 12:58 PM

Change #1103320 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/MediaModeration@master] Refactor MediaModerationImageContentsLookup::getThumbnailForFile

https://gerrit.wikimedia.org/r/1103320

gerritbot added a comment.Dec 13 2024, 1:09 PM

Change #1103320 abandoned by Dreamy Jazz:

[mediawiki/extensions/MediaModeration@master] Refactor MediaModerationImageContentsLookup::getThumbnailForFile

https://gerrit.wikimedia.org/r/1103320

gerritbot added a comment.Dec 13 2024, 1:16 PM

Change #1103320 restored by Dreamy Jazz:

[mediawiki/extensions/MediaModeration@master] Refactor MediaModerationImageContentsLookup::getThumbnailForFile

https://gerrit.wikimedia.org/r/1103320

gerritbot added a comment.Dec 13 2024, 1:25 PM

Change #1103325 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/MediaModeration@master] [WIP] Update maintenance script metrics to use StatsFactory

https://gerrit.wikimedia.org/r/1103325

Dreamy_Jazz moved this task from In Progress to Needs Review on the Trust and Safety Product Sprint (Sprint Chimes (Dec. 9 - Jan. 17)) board.Dec 13 2024, 3:15 PM
gerritbot added a comment.Dec 16 2024, 12:04 PM

Change #1103319 merged by jenkins-bot:

[mediawiki/extensions/MediaModeration@master] Refactor MediaModerationFileScannerTest into an integration test

https://gerrit.wikimedia.org/r/1103319

gerritbot added a comment.Dec 16 2024, 12:11 PM

Change #1103320 merged by jenkins-bot:

[mediawiki/extensions/MediaModeration@master] Refactor MediaModerationImageContentsLookup::getThumbnailForFile

https://gerrit.wikimedia.org/r/1103320

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.8; 2024-12-17).Dec 16 2024, 1:00 PM
gerritbot added a comment.Dec 16 2024, 2:38 PM

Change #1102371 merged by jenkins-bot:

[mediawiki/extensions/MediaModeration@master] Update metrics to use StatsFactory

https://gerrit.wikimedia.org/r/1102371

gerritbot added a comment.Dec 16 2024, 2:38 PM

Change #1103325 merged by jenkins-bot:

[mediawiki/extensions/MediaModeration@master] Update maintenance script metrics to use StatsFactory

https://gerrit.wikimedia.org/r/1103325

Dreamy_Jazz added a comment.EditedJan 3 2025, 4:39 PM

I've created https://grafana-rw.wikimedia.org/d/ab43c410-afca-4777-8244-53cea7ce2a2c/mediamoderation-photodna-stats?orgId=1&refresh=5m which uses the Prometheus data. One issue I've found is that the data isn't being displayed when all wikis are selected, and only displays when a subset of these are selected.

I think further work on it is needed, but I'll need to ask to see how we can fix this issue.

colewhite subscribed.Jan 3 2025, 10:31 PM
In T359357#10429442, @Dreamy_Jazz wrote:

... data isn't being displayed when all wikis are selected, and only displays when a subset of these are selected.

I added a regex string associated with the "all" option - did this resolve the issue you were seeing?

kostajh added a comment.Jan 6 2025, 10:47 AM
In T359357#10430082, @colewhite wrote:
In T359357#10429442, @Dreamy_Jazz wrote:

... data isn't being displayed when all wikis are selected, and only displays when a subset of these are selected.

I added a regex string associated with the "all" option - did this resolve the issue you were seeing?

That seems to work (using "allValue": ".+",), thanks @colewhite!

Dreamy_Jazz added a comment.Jan 6 2025, 12:08 PM
In T359357#10431982, @kostajh wrote:
In T359357#10430082, @colewhite wrote:
In T359357#10429442, @Dreamy_Jazz wrote:

... data isn't being displayed when all wikis are selected, and only displays when a subset of these are selected.

I added a regex string associated with the "all" option - did this resolve the issue you were seeing?

That seems to work (using "allValue": ".+",), thanks @colewhite!

That also works for me. Thanks!

Dreamy_Jazz updated the task description. (Show Details)EditedJan 7 2025, 5:31 PM

The dashboard using the Prometheus metrics has been created and is at https://grafana.wikimedia.org/d/ab43c410-afca-4777-8244-53cea7ce2a2c/mediamoderation-photodna-stats?orgId=1&refresh=5m. Review of that can now be performed. The requests per month graph will not display any data until 30 days have past since we were collecting data via Prometheus, so does not display anything for now. This graph displaying data isn't as important now that we have processed the backlog and are no longer concerned about exceeding the monthly request limit.

kostajh closed this task as Resolved.Jan 13 2025, 9:23 AM
kostajh moved this task from Needs Review to Done on the Trust and Safety Product Sprint (Sprint Chimes (Dec. 9 - Jan. 17)) board.
In T359357#10437992, @Dreamy_Jazz wrote:

The dashboard using the Prometheus metrics has been created and is at https://grafana.wikimedia.org/d/ab43c410-afca-4777-8244-53cea7ce2a2c/mediamoderation-photodna-stats?orgId=1&refresh=5m. Review of that can now be performed. The requests per month graph will not display any data until 30 days have past since we were collecting data via Prometheus, so does not display anything for now. This graph displaying data isn't as important now that we have processed the backlog and are no longer concerned about exceeding the monthly request limit.

LGTM, thank you for your work on this!

• lmata moved this task from Inbox to Done on the SRE Observability (FY2024/2025-Q3) board.Jun 17 2025, 1:52 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits