Page MenuHomePhabricator

Missing escaping in search-as-you-type suggestions of Monobook skin
Closed, ResolvedPublic

Description

Author: Amalthea.wikimedia

Description:
Suggestion popup.

I have an alternate account named [User:Amalthea'"&lt] to test escaping issues in tools.
Using Monobook skin, when I type [User:Amalthea'] into the search input field, the search-as-you-type suggestion popup displays [User:Amalthea'"<].
I interpret this as my browser auto-correcting the broken entity [&lt] and displaying it as [<], which in turn means that the ampersand is not escaped properly when it's written into the suggestion popup.

Since page names are heavily sanitized I don't see a way that this can be exploited, but it should be fixed nonetheless.
Vector skin is behaving correctly.


Version: unspecified
Severity: minor

Attached:

search-as-you-type-missing-escaping.png (88×176 px, 4 KB)

Details

Reference
bz33963

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 12:07 AM
bzimport set Reference to bz33963.
bzimport added a subscriber: Unknown Object (MLST).