Page MenuHomePhabricator

Legacy URL of /tool/book.php does not work
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

Generation of books ona wikisource (tested on Pl-WS and oldwikisource) fails.

What happens?:

One gets information "File not found. "

What should have happened instead?:

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

In both cases ws-export.wmcloud.org is used. Is this server/service down?

@Draco_flavus can you provide a link to the work you're trying to export?

https://ws-export.wmcloud.org/ is up and working in my quick tests.

This appears to be a fault in the URL rewriting. We're supposedly handling /tool/book.php in the app:

	 * @Route("/", name="home")
	 * @Route("book.php")
	 * @Route("tool/book.php")

But that maybe isn't working because that URL isn't being passed to the app. It does have DirectoryIndex index.php book.php which I thought maybe was confusing it, but nope.

As these old URLs have been working for years, I wonder if this break is related to the recent change to using FPM for T335553; @tstarling do you think that's related? I don't have time right now to look into it further, but will get back to it on Monday.

In the meantime, a workaround (and probably good thing to do anyway!) is to change whatever templates are using that old URL to use the new one of just https://ws-export.wmcloud.org/?lang=pl&format=epub&page=Bajki+nowe (i.e. without the tool/book.php.

Actually, scratch that: I've added a redirect for that URL, and all should now be working correctly again. Still not sure what happened to the rewrite rules!

I've added both legacy URLs to the Apache config (change), and made a PR for removing them from the app routes: https://github.com/wikimedia/ws-export/pull/509

Samwilson renamed this task from Ws Export does not work to Legacy URL of /tool/book.php does not work.Mar 11 2024, 5:07 AM

The same issue was with https://ws-export.wmcloud.org/statistics

The issue was the new /fpm-status route, which was being skipped incorrectly with this rewrite condition:

RewriteCond %{REQUEST_URI} ="/fpm-status"

I changed it to:

RewriteCond %{REQUEST_URI} !^/fpm-status

And all URLs are now working again (including the new fpm-status).

I see https://github.com/wikimedia/ws-export/pull/509 was abandoned, and the Wikitech docs have been updated. I'm guessing it's safe to close as resolved now.