Page MenuHomePhabricator

SX: URL parameters should always include the selected page and section title
Closed, ResolvedPublic

Description

When a page or a section are selected for translation in Section Translation application (which includes the Unified Dashboard), the URL should be updated to include the following parameters:

  • from, for the translation source language
  • to, for the translation target language
  • page, for the translation source page title.

If a specific section has been selected (not just a page), the section URL parameter should also be set, for the source section title.

All those URL parameters should also be properly set when continuing a draft translation.

Currently, these URL params are not set inside several steps:

*Confirm a translation*

"Confirm Translation" step: Missing URL parameter (988×1 px, 423 KB)

*Compare contents*

"Compare contents" step: Missing URL parameter (988×1 px, 196 KB)

*Pick a sentence*

"Pick a sentence" step: Missing URL parameter (988×1 px, 186 KB)

Event Timeline

ngkountas changed the task status from Open to In Progress.Mar 14 2024, 10:37 AM
ngkountas triaged this task as Medium priority.
ngkountas updated the task description. (Show Details)
ngkountas moved this task from Backlog to Core workflow on the SectionTranslation board.

Change 1011271 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] SX: Add the appropriate URL parameters before each step

https://gerrit.wikimedia.org/r/1011271

Change 1011271 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] SX: Add the appropriate URL parameters before each step

https://gerrit.wikimedia.org/r/1011271

Change #1015979 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.2.0+20240401

https://gerrit.wikimedia.org/r/1015979

Change #1015979 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.2.0+20240401

https://gerrit.wikimedia.org/r/1015979

test status: QA PASS

Comparator

Screenshot 2024-05-28 at 11.31.06 PM.png (906×1 px, 297 KB)

Page uRL

Screenshot 2024-05-28 at 11.29.21 PM.png (834×1 px, 500 KB)

Pick a sentence

Screenshot 2024-05-28 at 11.32.56 PM.png (890×1 px, 257 KB)

Pginer-WMF subscribed.

When trying this on Igbo Wikipedia I found that the URL updates on each step in Section Translation, but copying it and opening it in another tab does not return to the same step. Instead, the Content Translation version is opened on mobile despite the ".m." in the URL. This is illustrated below:

Moving this back to "Done" column, since the issue mentioned above is not related to this task.