Clean up code in PageRenderingHandler::onSkinTemplateNavigation__Universal to use wfArrayToCgi()
Open, In Progress, LowestPublic
Actions

Assigned To

Authored By

	Jdforrester-WMF
	Mar 15 2024, 7:46 PM

Description

We have various lines of constructing the various GET parameters for the href value by appending strings together; instead, we should add values to an array and at the end set it once with the wfArrayToCgi() built-in MediaWiki function.

Event Timeline

Jdforrester-WMF created this task.Mar 15 2024, 7:46 PM

Philipnelson99 subscribed.Mar 19 2024, 9:38 PM

DVrandecic triaged this task as Lowest priority.Mar 21 2024, 4:48 PM

DVrandecic moved this task from To triage to Backlog on the Abstract Wikipedia team board.

I'll be submitting a patchset for this soon.

In T360229#9672177, @Philipnelson99 wrote:

I'll be submitting a patchset for this soon.

Brilliant. If you need any help/advice, please shout!

Hey @Jdforrester-WMF just want to clarify if only PageRenderingHandler::onSkinTemplateNavigation__Universal should use wfArrayToCgi() and not the other functions present in PageRenderingHandler. Thanks!

In T360229#9691441, @Philipnelson99 wrote:

Hey @Jdforrester-WMF just want to clarify if only PageRenderingHandler::onSkinTemplateNavigation__Universal should use wfArrayToCgi() and not the other functions present in PageRenderingHandler. Thanks!

Yup, sorry for the delay, that's right.

Clean up code in PageRenderingHandler::onSkinTemplateNavigation__Universal to use wfArrayToCgi()Open, In Progress, LowestPublicActions

Description

Event Timeline

Clean up code in PageRenderingHandler::onSkinTemplateNavigation__Universal to use wfArrayToCgi()
Open, In Progress, LowestPublic
Actions