Page MenuHomePhabricator

Clean up code in PageRenderingHandler::onSkinTemplateNavigation__Universal to use wfArrayToCgi()
Open, In Progress, LowestPublic

Description

We have various lines of constructing the various GET parameters for the href value by appending strings together; instead, we should add values to an array and at the end set it once with the wfArrayToCgi() built-in MediaWiki function.

Event Timeline

DVrandecic triaged this task as Lowest priority.Mar 21 2024, 4:48 PM
DVrandecic moved this task from To triage to Backlog on the Abstract Wikipedia team board.

I'll be submitting a patchset for this soon.

Jdforrester-WMF changed the task status from Open to In Progress.Apr 1 2024, 6:04 PM
Jdforrester-WMF moved this task from Backlog to In Progress on the Abstract Wikipedia team board.

I'll be submitting a patchset for this soon.

Brilliant. If you need any help/advice, please shout!

Hey @Jdforrester-WMF just want to clarify if only PageRenderingHandler::onSkinTemplateNavigation__Universal should use wfArrayToCgi() and not the other functions present in PageRenderingHandler. Thanks!

Hey @Jdforrester-WMF just want to clarify if only PageRenderingHandler::onSkinTemplateNavigation__Universal should use wfArrayToCgi() and not the other functions present in PageRenderingHandler. Thanks!

Yup, sorry for the delay, that's right.