Page MenuHomePhabricator

Clean up code in PageRenderingHandler::onSkinTemplateNavigation__Universal to use wfArrayToCgi()
Open, In Progress, LowestPublic

Description

We have various lines of constructing the various GET parameters for the href value by appending strings together; instead, we should add values to an array and at the end set it once with the wfArrayToCgi() built-in MediaWiki function.

Event Timeline

DVrandecic triaged this task as Lowest priority.Mar 21 2024, 4:48 PM
DVrandecic moved this task from To triage to Backlog on the Abstract Wikipedia team board.

I'll be submitting a patchset for this soon.

Jdforrester-WMF changed the task status from Open to In Progress.Apr 1 2024, 6:04 PM
Jdforrester-WMF moved this task from Backlog to In Progress on the Abstract Wikipedia team board.

I'll be submitting a patchset for this soon.

Brilliant. If you need any help/advice, please shout!

Hey @Jdforrester-WMF just want to clarify if only PageRenderingHandler::onSkinTemplateNavigation__Universal should use wfArrayToCgi() and not the other functions present in PageRenderingHandler. Thanks!

Hey @Jdforrester-WMF just want to clarify if only PageRenderingHandler::onSkinTemplateNavigation__Universal should use wfArrayToCgi() and not the other functions present in PageRenderingHandler. Thanks!

Yup, sorry for the delay, that's right.

Sorry, I'm going to remove myself from being assigned for time being. I did make some progress but got too busy IRL and forgot all about it.

Pppery changed the task status from In Progress to Open.Aug 11 2024, 11:40 PM

Change #1065263 had a related patch set uploaded (by Aditya0545; author: Aditya0545):

[mediawiki/extensions/WikiLambda@master] PageRenderingHandler::onSkinTemplateNavigation_Universal to use wfArrayToCgi()

https://gerrit.wikimedia.org/r/1065263

Adityakumar0545 claimed this task.
Adityakumar0545 subscribed.

I have fixed this bug, could you please check it and give me review ?

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikiLambda/+/1065263

Pppery subscribed.

Not fixed until the patch is merged.

Adityakumar0545 changed the task status from Open to In Progress.Aug 25 2024, 5:36 PM

ok I am resolving it

Change #1066314 had a related patch set uploaded (by Aditya0545; author: Aditya0545):

[mediawiki/extensions/WikiLambda@master] PageRenderingHandler::onSkinTemplateNavigation_Universal to use wfArrayToCgi()

https://gerrit.wikimedia.org/r/1066314

Change #1066314 abandoned by Aditya0545:

[mediawiki/extensions/WikiLambda@master] PageRenderingHandler::onSkinTemplateNavigation_Universal to use wfArrayToCgi()

https://gerrit.wikimedia.org/r/1066314