Page MenuHomePhabricator

Enable Extension:DarkMode persistence for anons on Vector
Closed, ResolvedPublic

Description

Background

Currently dark mode extension does not work for anonymous users using the Vector skin. This is because the Vector skin needs to set clientPrefEnabled.

User story

As a third party using the Vector skin I want a dark mode experience for my anonymous users.

Acceptance criteria

  • The DarkMode extension should check the skin capabilities and inform the users in situations where it doesn't persist that they must log in.
  • Vector skin should be enabled.

Communication criteria - does this need an announcement or discussion?

  • Add communication criteria

QA steps

  • In incognito window load the Vector skin with Extension:DarkMode enabled
  • Click "Dark mode" toggle
  • Refresh page

Dark mode should persist on page load.

Event Timeline

Change 1013075 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/DarkMode@master] Check skin capabilities before enabling for anons

https://gerrit.wikimedia.org/r/1013075

Change 1013077 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Extension:DarkMode should persist for anons

https://gerrit.wikimedia.org/r/1013077

Jdlrobson renamed this task from Enable Extension:DarkMode for anons on Vector to Enable Extension:DarkMode persistence for anons on Vector.Mar 20 2024, 3:23 PM
Jdlrobson updated the task description. (Show Details)
Jdlrobson updated the task description. (Show Details)

FYI, the 1.42 branch point is in a matter of hours; will this get this done by then?

Change #1013077 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Extension:DarkMode should persist for anons

https://gerrit.wikimedia.org/r/1013077

Change #1020232 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@REL1_42] Extension:DarkMode should persist for anons

https://gerrit.wikimedia.org/r/1020232

Change #1020232 merged by jenkins-bot:

[mediawiki/skins/Vector@REL1_42] Extension:DarkMode should persist for anons

https://gerrit.wikimedia.org/r/1020232

Resolved and backported to 1.42.

Change #1013075 abandoned by Jdlrobson:

[mediawiki/extensions/DarkMode@master] Check skin capabilities when enabling for anons

Reason:

Not working on this any more. Feel free to restore if useful.

https://gerrit.wikimedia.org/r/1013075