Implement response classes for the CheckUser API
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

Classes that extend ApiQueryCheckUserAbstractResponse that implement providing a response for a particular request type need to be created. These classes will be initially untested, but will be tested by using these classes in T341827 through the existing integration tests on ApiQueryCheckUser. This is done to avoid duplication for the tests and to avoid writing tests that verify incorrect behaviour which causes a change in the response by ApiQueryCheckUser

Acceptance criteria

Create ApiQueryCheckUserUserIpsResponse
Create ApiQueryCheckUserIpUsersResponse
Create ApiQueryCheckUserActionsResponse

Details

Subject	Repo	Branch	Lines +/-
Combine the summary and actiontext if both are available for a row	mediawiki/extensions/CheckUser	master	+130 -10
Add ApiQueryCheckUserActionsResponse	mediawiki/extensions/CheckUser	master	+284 -0
Add ipusers and userips response classes the for CheckUser API	mediawiki/extensions/CheckUser	master	+275 -1

Customize query in gerrit

Related Objects
Search...

View Standalone Graph

This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.

Status	Assigned	Task
		· · ·
Resolved	Dreamy_Jazz	T341827 Add read new support to the CheckUser API
Resolved	Dreamy_Jazz	T360963 Implement response classes for the CheckUser API
Resolved	Dreamy_Jazz	T360961 Create ApiQueryCheckUserAbstractResponse
Resolved	Dreamy_Jazz	T360453 Create the CheckUserLookupUtils service
		· · ·

Event Timeline

Dreamy_Jazz created this task.Mar 25 2024, 11:43 PM

Restricted Application removed a project: Patch-For-Review. · View Herald TranscriptMar 25 2024, 11:43 PM

Dreamy_Jazz added a subtask: T360961: Create ApiQueryCheckUserAbstractResponse.Mar 25 2024, 11:43 PM

Change #1013435 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Add ipusers and userips response classes the for CheckUser API

https://gerrit.wikimedia.org/r/1013435

Change #1013436 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] [WIP] Add ApiQueryCheckUserActionsResponse

https://gerrit.wikimedia.org/r/1013436

Change #1013433 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Combine the summary and actiontext if both are available for a row

https://gerrit.wikimedia.org/r/1013433

Dreamy_Jazz claimed this task.Mar 26 2024, 12:34 AM

Dreamy_Jazz set the point value for this task to 3.

Dreamy_Jazz added a project: Trust and Safety Product Sprint (Sprint Gangan (11th - 22nd March)).

Dreamy_Jazz moved this task from Priority Backlog to Needs review on the Trust and Safety Product Sprint (Sprint Gangan (11th - 22nd March)) board.

Dreamy_Jazz added a subtask: T360453: Create the CheckUserLookupUtils service.Mar 26 2024, 12:48 AM

Change #1013435 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Add ipusers and userips response classes the for CheckUser API

https://gerrit.wikimedia.org/r/1013435

Change #1013436 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Add ApiQueryCheckUserActionsResponse

https://gerrit.wikimedia.org/r/1013436

Dreamy_Jazz closed subtask T360961: Create ApiQueryCheckUserAbstractResponse as Resolved.Mar 28 2024, 5:43 PM

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.25; 2024-04-02).Mar 28 2024, 6:00 PM

Change #1013433 merged by jenkins-bot: